| 31 Jul 2023 |
 Lily Foster | Weird. I didn't read the whole derivation so I'll look later. Was on mobile and just happened to notice that and thought it was weird | 12:00:09 |
 gdamjan |
mweinelt (Martin Weinelt) already merged the PR - but I'd like to see what improvements can be done to it | 12:23:42 |
| gdamjan | * mweinelt (Martin Weinelt) already merged the PR - but I'd like to see what improvements can be done to it | 12:23:47 |
| Lily Foster | In reply to @gdamjan:spodeli.org
mweinelt (Martin Weinelt) already merged the PR - but I'd like to see what improvements can be done to it Oh dang that was fast. Yeah I'm fine to review post-merge for possible fixups. It's probably for the best a security fix got merged quickly anyway | 12:27:35 |
 hexa | sorry, I missed any conversdation here apparently | 12:28:16 |
| hexa | * sorry, I missed any conversation here apparently | 12:28:20 |
| gdamjan | oh, wait, you're Martin :) | 12:36:32 |
| gdamjan | TIL | 12:36:38 |
 raitobezarius | :'DDDDDDDD | 14:01:05 |
| hexa | fck | 19:21:09 |
| hexa |
ERROR:CLI Error: Could not find package.json up from /nix/store/qvpjwskw6j9n4g8749snwj5b6nk9xsb1-matrix-appservice-irc-1.0.1/bin/matrix-appservice-irc
| 19:21:13 |
| hexa | cc gdamjan they want the package.json | 19:32:33 |
 dotlambda | I'm trying to package https://github.com/microsoft/pyright/tree/main and I need the dependencies from both package-lock.json and packages/pyright/package-lock.json. Any idea how to achieve that? | 20:13:13 |
| dotlambda | Btw they use something called Lerna to manage this monorepo. | 20:18:12 |
| raitobezarius | sorry for you | 20:20:22 |
| Lily Foster | l e r n a | 20:30:09 |
| Lily Foster | I am also sorry for you | 20:30:17 |
| Lily Foster | Lerna does weird things | 20:30:24 |
| Lily Foster | You can kinda sorta do a merge across the JSON packages field and pray | 20:30:47 |
| Lily Foster | If you really are needing deps from both in the same cache | 20:31:06 |
| Lily Foster | I wonder if we should support caching from multiple lockfiles | 20:31:55 |
| dotlambda | In reply to @lily:lily.flowers
If you really are needing deps from both in the same cache Webpack (from /packages/pyright/package.json) needs glob (from /package.json). No idea why it's not automatically included as a dependency of the former | 20:50:34 |
| gdamjan | In reply to @hexa:lossy.network
cc gdamjan they want the package.json this Martin guy lied me | 20:52:01 |
| Lily Foster | In reply to @robert:funklause.de
Webpack (from /packages/pyright/package.json) needs glob (from /package.json). No idea why it's not automatically included as a dependency of the former Because lerna is hell | 20:53:56 |
| Lily Foster | Wait you need from two package-lock.json files right? Two package.json files is normal for monorepos with npm workspaces or something | 20:54:40 |
| dotlambda | In reply to @lily:lily.flowers
Wait you need from two package-lock.json files right? Two package.json files is normal for monorepos with npm workspaces or something Yes indeed. Glob is not present in packages/pyright/package-lock.json. | 20:56:04 |
| Lily Foster | Alright. I might make a PR to support passing multiple lockfiles for the same hash though | 20:57:08 |
| Lily Foster | * Alright. I might make a PR to support passing multiple lockfiles for the same hash then | 20:57:15 |
| Lily Foster | * Alright. I might make a PR to support passing multiple lockfiles for the same cache then | 20:59:20 |
| dotlambda | Actually glob does exist in packages/pyright/package-lock.json so I'm not sure why I get
[webpack-cli] Failed to load '/build/source/packages/pyright/webpack.config.js' config
[webpack-cli] Error: Cannot find module 'glob'
Require stack:
- /build/source/build/lib/webpack.js
- /build/source/packages/pyright/webpack.config.js
- /build/source/packages/pyright/node_modules/webpack-cli/lib/webpack-cli.js
- /build/source/packages/pyright/node_modules/webpack-cli/lib/bootstrap.js
- /build/source/packages/pyright/node_modules/webpack-cli/bin/cli.js
- /build/source/packages/pyright/node_modules/webpack/bin/webpack.js
at Module._resolveFilename (node:internal/modules/cjs/loader:1077:15)
at Module._load (node:internal/modules/cjs/loader:922:27)
at Module.require (node:internal/modules/cjs/loader:1143:19)
at require (node:internal/modules/cjs/helpers:110:18)
at Object.<anonymous> (/build/source/build/lib/webpack.js:3:14)
at Module._compile (node:internal/modules/cjs/loader:1256:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
at Module.load (node:internal/modules/cjs/loader:1119:32)
at Module._load (node:internal/modules/cjs/loader:960:12)
at Module.require (node:internal/modules/cjs/loader:1143:19) {
code: 'MODULE_NOT_FOUND',
requireStack: [
'/build/source/build/lib/webpack.js',
'/build/source/packages/pyright/webpack.config.js',
'/build/source/packages/pyright/node_modules/webpack-cli/lib/webpack-cli.js',
'/build/source/packages/pyright/node_modules/webpack-cli/lib/bootstrap.js',
'/build/source/packages/pyright/node_modules/webpack-cli/bin/cli.js',
'/build/source/packages/pyright/node_modules/webpack/bin/webpack.js'
]
}
| 21:04:39 |
