Nix NodeJS

Sender	Message	Time
30 Jul 2023
Lily Foster	In reply to @lily:lily.flowers No all phases are evaluated in the same bash instance in stdenv (Unless you call bash again in your phase I guess)	12:32:36
gdamjan	you're right. thanks.	12:33:59
gdamjan	https://github.com/NixOS/nixpkgs/compare/master...gdamjan:nixpkgs:bump-matrix-appservice-irc-2?expand=1 here's that in pre-PR form :D	12:42:06
Lily Foster	Sweet! I'll be able to take a look in like ~6 hours (feel free to remind me if I forget too....)	12:43:15
gdamjan	I'll open a PR for the mkDerivation if this is the better approach than mkYarnPackage	12:44:53
Lily Foster	I think it probably will be, but I'm also biased in that I want to kill yarn2nix 🙈	12:45:33
gdamjan	:D	12:46:18
gdamjan	I'm ok with biases	12:46:30
gdamjan	btw, what is `passthru.updateScript` ?	12:49:03
gdamjan	it's funny how `yarn install --offline` calls the `prepare` or `build` script from `package.json` without the --offline flag :/	13:03:17
gdamjan	not very happy with that `--ignore-scripts` there, but without it, it fails to build the code?! yarn install v1.22.19 [150/1989][1/5] Validating package.json... [2/5] Resolving packages... [3/5] Fetching packages... [4/5] Linking dependencies... [5/5] Building fresh packages... $ yarn run build yarn run v1.22.19 warning You don't appear to have an internet connection. Try the --offline flag to use the cache for registry queries. $ yarn run build:app && yarn run build:widget warning You don't appear to have an internet connection. Try the --offline flag to use the cache for registry queries. $ tsc --project ./tsconfig.json /bin/sh: tsc: not found error Command failed with exit code 127.	13:07:17
gdamjan	and one more nitpick, `./result/bin/matrix-appservice-irc` prints this message: `Usage: Generating an application service registration file: /nix/store/5vm8fh4q21xlk7i1y6rqykqar296dglr-nodejs-slim-18.16.1/bin/node -r [-f /path/to/save/registration.yaml] -u 'http://localhost:6789' -c CONFIG_FILE [-l my-app-service]` is there some better wrapper in nix I can use instead of https://github.com/matrix-org/matrix-appservice-irc/blob/develop/bin/matrix-appservice-irc ?	13:08:56
gdamjan	In reply to @gdamjan:spodeli.org not very happy with that `--ignore-scripts` there, but without it, it fails to build the code?! yarn install v1.22.19 [150/1989][1/5] Validating package.json... [2/5] Resolving packages... [3/5] Fetching packages... [4/5] Linking dependencies... [5/5] Building fresh packages... $ yarn run build yarn run v1.22.19 warning You don't appear to have an internet connection. Try the --offline flag to use the cache for registry queries. $ yarn run build:app && yarn run build:widget warning You don't appear to have an internet connection. Try the --offline flag to use the cache for registry queries. $ tsc --project ./tsconfig.json /bin/sh: tsc: not found error Command failed with exit code 127. there = https://github.com/NixOS/nixpkgs/pull/246188/files	13:09:17
Lily Foster	In reply to @gdamjan:spodeli.org it's funny how `yarn install --offline` calls the `prepare` or `build` script from `package.json` without the --offline flag :/ That's entirely upstream's fault: https://github.com/matrix-org/matrix-appservice-irc/blob/0afb064635d37e039067b5b3d6423448b93026d3/package.json#L14	13:12:38
gdamjan	yeah, Im inclined to maybe `sed` it out	13:52:41
gdamjan	hexa: will you give it a go on your staging environment? you do have staging, right, RIGHT :)	14:32:38
hexa	no, I do not	14:33:18
hexa	this is a community network that I tend to in my spare time	14:33:27
hexa	but I don't suppose we're going to find any smaller user on short notice	14:34:56
hexa	because most individual users will have switched to heisenbridge	14:37:09
gdamjan	ok, I'll try to cook something up	14:47:08
dotlambda	In reply to @lily:lily.flowers That's entirely upstream's fault: https://github.com/matrix-org/matrix-appservice-irc/blob/0afb064635d37e039067b5b3d6423448b93026d3/package.json#L14 What would be a better thing to put in `package.json`?	15:41:21
Lily Foster	Honestly, idk. I'd rather either package.json have a direct way to chain lifecycle scripts or yarn just had a config setting for offline so flags wouldn't have to be propagated	15:43:05
dotlambda	I'm improving `remove-attr.py` slightly in https://github.com/NixOS/nixpkgs/pull/246155	15:47:13
Lily Foster	In reply to @robert:funklause.de I'm improving `remove-attr.py` slightly in https://github.com/NixOS/nixpkgs/pull/246155 I'll try to review tonight! (US eastern tz)	15:49:51
31 Jul 2023
dotlambda	I get `Error: invalid HTTP request Caused by: invalid format` when running `prefetch-npm-deps` on https://github.com/cloudflare/workers-sdk/blob/wrangler%403.3.0/package-lock.json Is that because of the empty string key? `{ "name": "wrangler-root", "version": "0.0.0", "lockfileVersion": 2, "requires": true, "packages": { "": {`	06:17:58
gdamjan	https://github.com/matrix-org/matrix-appservice-irc/releases/tag/1.0.1	09:14:11
gdamjan	all in all, I like the fetchYarnDeps + mkDerivation combo. less magic, more control, and it's not that hard at all	09:30:37
gdamjan	one question about https://github.com/NixOS/nixpkgs/pull/246188 … I have nodejs-slim in nativeBuildInputs, so that makes it depend on slim at runtime. Is this a good approach? `nativeBuildInputs = [ prefetch-yarn-deps nodejs-slim nodejs.pkgs.yarn nodejs.pkgs.node-gyp-build ];`	09:34:26
gdamjan	although, nodejs-slim-18.16.1 still depends on icu4c-73.2-dev, openssl-3.0.9-dev, openssl-3.0.9-dev and zlib-1.2.13-dev :/ - not more than 10MB but still	09:41:36

Lily Foster

In reply to @lily:lily.flowers
No all phases are evaluated in the same bash instance in stdenv

(Unless you call bash again in your phase I guess)

12:32:36

gdamjan

you're right. thanks.

12:33:59

gdamjan

https://github.com/NixOS/nixpkgs/compare/master...gdamjan:nixpkgs:bump-matrix-appservice-irc-2?expand=1 here's that in pre-PR form :D

12:42:06

Lily Foster

Sweet! I'll be able to take a look in like ~6 hours (feel free to remind me if I forget too....)

12:43:15

gdamjan

I'll open a PR for the mkDerivation if this is the better approach than mkYarnPackage

12:44:53

Lily Foster

I think it probably will be, but I'm also biased in that I want to kill yarn2nix 🙈

:D

I'm ok with biases

btw, what is passthru.updateScript ?

12:49:03

gdamjan

it's funny how yarn install --offline calls the prepare or build script from package.json without the --offline flag :/

13:03:17

gdamjan

not very happy with that --ignore-scripts there, but without it, it fails to build the code?!

yarn install v1.22.19                                                                                                                           [150/1989][1/5] Validating package.json...                                             
[2/5] Resolving packages...                                                  
[3/5] Fetching packages...                                                                                                                                
[4/5] Linking dependencies...                                                                                                                             
[5/5] Building fresh packages...                                             
$ yarn run build                                                                                                                                          
yarn run v1.22.19                                                                                                                                         
warning You don't appear to have an internet connection. Try the --offline flag to use the cache for registry queries.                                    
$ yarn run build:app && yarn run build:widget                                
warning You don't appear to have an internet connection. Try the --offline flag to use the cache for registry queries.                                    
$ tsc --project ./tsconfig.json       
/bin/sh: tsc: not found                                                                                                                                   
error Command failed with exit code 127.

13:07:17

gdamjan

and one more nitpick, ./result/bin/matrix-appservice-irc prints this message:

Usage:                                                                       

Generating an application service registration file:                                                                                                      
/nix/store/5vm8fh4q21xlk7i1y6rqykqar296dglr-nodejs-slim-18.16.1/bin/node -r [-f /path/to/save/registration.yaml] -u 'http://localhost:6789' -c CONFIG_FILE
 [-l my-app-service]

is there some better wrapper in nix I can use instead of https://github.com/matrix-org/matrix-appservice-irc/blob/develop/bin/matrix-appservice-irc ?

13:08:56

gdamjan

In reply to @gdamjan:spodeli.org

not very happy with that --ignore-scripts there, but without it, it fails to build the code?!

yarn install v1.22.19                                                                                                                           [150/1989][1/5] Validating package.json...                                             
[2/5] Resolving packages...                                                  
[3/5] Fetching packages...                                                                                                                                
[4/5] Linking dependencies...                                                                                                                             
[5/5] Building fresh packages...                                             
$ yarn run build                                                                                                                                          
yarn run v1.22.19                                                                                                                                         
warning You don't appear to have an internet connection. Try the --offline flag to use the cache for registry queries.                                    
$ yarn run build:app && yarn run build:widget                                
warning You don't appear to have an internet connection. Try the --offline flag to use the cache for registry queries.                                    
$ tsc --project ./tsconfig.json       
/bin/sh: tsc: not found                                                                                                                                   
error Command failed with exit code 127.

there = https://github.com/NixOS/nixpkgs/pull/246188/files

13:09:17

Lily Foster

In reply to @gdamjan:spodeli.org
it's funny how yarn install --offline calls the prepare or build script from package.json without the --offline flag :/

That's entirely upstream's fault: https://github.com/matrix-org/matrix-appservice-irc/blob/0afb064635d37e039067b5b3d6423448b93026d3/package.json#L14

13:12:38

gdamjan

yeah, Im inclined to maybe `sed` it out

13:52:41

gdamjan

hexa: will you give it a go on your staging environment? you do have staging, right, RIGHT :)

no, I do not

this is a community network that I tend to in my spare time

14:33:27

hexa

but I don't suppose we're going to find any smaller user on short notice

14:34:56

hexa

because most individual users will have switched to heisenbridge

14:37:09

gdamjan

ok, I'll try to cook something up

14:47:08

dotlambda

In reply to @lily:lily.flowers
That's entirely upstream's fault: https://github.com/matrix-org/matrix-appservice-irc/blob/0afb064635d37e039067b5b3d6423448b93026d3/package.json#L14

What would be a better thing to put in package.json?

15:41:21

Lily Foster

Honestly, idk. I'd rather either package.json have a direct way to chain lifecycle scripts or yarn just had a config setting for offline so flags wouldn't have to be propagated

15:43:05

dotlambda

I'm improving remove-attr.py slightly in https://github.com/NixOS/nixpkgs/pull/246155

15:47:13

Lily Foster

In reply to @robert:funklause.de
I'm improving remove-attr.py slightly in https://github.com/NixOS/nixpkgs/pull/246155

I'll try to review tonight! (US eastern tz)

15:49:51

dotlambda

I get

Error: invalid HTTP request

Caused by:
    invalid format

when running prefetch-npm-deps on https://github.com/cloudflare/workers-sdk/blob/wrangler%403.3.0/package-lock.json
Is that because of the empty string key?

{
  "name": "wrangler-root",
  "version": "0.0.0",
  "lockfileVersion": 2,
  "requires": true,
  "packages": {
    "": {

06:17:58

gdamjan

https://github.com/matrix-org/matrix-appservice-irc/releases/tag/1.0.1

09:14:11

gdamjan

all in all, I like the fetchYarnDeps + mkDerivation combo. less magic, more control, and it's not that hard at all

09:30:37

gdamjan

one question about https://github.com/NixOS/nixpkgs/pull/246188 … I have nodejs-slim in nativeBuildInputs, so that makes it depend on slim at runtime. Is this a good approach?


  nativeBuildInputs = [
    prefetch-yarn-deps
    nodejs-slim
    nodejs.pkgs.yarn
    nodejs.pkgs.node-gyp-build
  ];

09:34:26

gdamjan

although, nodejs-slim-18.16.1 still depends on icu4c-73.2-dev, openssl-3.0.9-dev, openssl-3.0.9-dev and zlib-1.2.13-dev :/ - not more than 10MB but still

09:41:36

Load older messages

Show newer messages