Nix NodeJS | 204 Members | |
| 58 Servers |
| Sender | Message | Time |
|---|---|---|
| 30 Jul 2023 | ||
| * I'm guessing the mktemp HOME was removed between the phases? | 12:27:08 | |
In reply to @gdamjan:spodeli.orgOh yeah it's because of this https://gist.github.com/gdamjan/08901abe49baadf083034e93ed32ccbe#file-default-2-nix-L58 | 12:27:27 | |
| Is that necessary? | 12:27:33 | |
In reply to @lily:lily.flowersI've seen it used in nixpkgs, but let's check | 12:28:04 | |
| but afaik HOME is where yarn config stores the config, and without it, nix sets HOME to a non-existent directory, doesn't it? | 12:29:25 | |
| No i mean why set home twice? | 12:30:16 | |
| It should just be needed once | 12:30:20 | |
| I thought it was a different shell instance | 12:31:18 | |
| No all phases are evaluated in the same bash instance in stdenv | 12:32:05 | |
| let me see | 12:32:09 | |
In reply to @lily:lily.flowers(Unless you call bash again in your phase I guess) | 12:32:36 | |
| you're right. thanks. | 12:33:59 | |
| https://github.com/NixOS/nixpkgs/compare/master...gdamjan:nixpkgs:bump-matrix-appservice-irc-2?expand=1 here's that in pre-PR form :D | 12:42:06 | |
| Sweet! I'll be able to take a look in like ~6 hours (feel free to remind me if I forget too....) | 12:43:15 | |
| I'll open a PR for the mkDerivation if this is the better approach than mkYarnPackage | 12:44:53 | |
| I think it probably will be, but I'm also biased in that I want to kill yarn2nix 🙈 | 12:45:33 | |
| :D | 12:46:18 | |
| I'm ok with biases | 12:46:30 | |
btw, what is passthru.updateScript ? | 12:49:03 | |
it's funny how yarn install --offline calls the prepare or build script from package.json without the --offline flag :/ | 13:03:17 | |
| not very happy with that
| 13:07:17 | |
| and one more nitpick,
is there some better wrapper in nix I can use instead of https://github.com/matrix-org/matrix-appservice-irc/blob/develop/bin/matrix-appservice-irc ? | 13:08:56 | |
In reply to @gdamjan:spodeli.orgthere = https://github.com/NixOS/nixpkgs/pull/246188/files | 13:09:17 | |
In reply to @gdamjan:spodeli.orgThat's entirely upstream's fault: https://github.com/matrix-org/matrix-appservice-irc/blob/0afb064635d37e039067b5b3d6423448b93026d3/package.json#L14 | 13:12:38 | |
| yeah, Im inclined to maybe `sed` it out | 13:52:41 | |
| hexa: will you give it a go on your staging environment? you do have staging, right, RIGHT :) | 14:32:38 | |
| no, I do not | 14:33:18 | |
| this is a community network that I tend to in my spare time | 14:33:27 | |
| but I don't suppose we're going to find any smaller user on short notice | 14:34:56 | |
| because most individual users will have switched to heisenbridge | 14:37:09 | |