| 4 Jul 2023 |
Lily Foster | If you're trying to get something specific working, there is a yarn v2+ to yarn v1 lockfile rewriter in nixpkgs that some packages have used | 08:53:05 |
Janne Heß | In reply to @lily:lily.flowers If you're trying to get something specific working, there is a yarn v2+ to yarn v1 lockfile rewriter in nixpkgs that some packages have used That's possible? 👀 | 08:53:19 |
Lily Foster | I thought it was. I may be misremembering?
(If it is though, it might be easier if yarn berry turns out to be a lot of trouble to create new tooling for atm) | 08:54:09 |
Janne Heß | So good news: a yarn offline cache appears to be reproducible | 10:56:58 |
Janne Heß | offlineCache = stdenvNoCC.mkDerivation {
name = "cal.com-${version}-offline-cache";
inherit src;
nativeBuildInputs = [ yarn ];
HOME = "/build";
buildPhase = ''
yarn config set enableTelemetry 0
yarn config set cacheFolder $out
yarn
'';
outputHashAlgo = "sha256";
outputHashMode = "recursive";
outputHash = "sha256-w/nwiMntMsi+G55iZF9QwdA7ZFe/XOtA19AUqboLFWA=";
};
| 10:57:05 |
Janne Heß | (we will see if this also builds in a couple of months…) | 10:57:39 |
Lily Foster | In reply to @janne.hess:helsinki-systems.de (we will see if this also builds in a couple of months…) Wait this would still be yarn v1 right? We don't have yarn-berry in nixpkgs yet I thought | 11:02:39 |
Lily Foster | (Oops meant to set that as a reply to the other message) | 11:02:55 |
Lily Foster | * (Oops, meant to set that as a reply to the other message) | 11:03:03 |
Janne Heß | In reply to @lily:lily.flowers Wait this would still be yarn v1 right? We don't have yarn-berry in nixpkgs yet I thought interesting… still manages to parse the v2 lockfile | 11:49:39 |
Janne Heß | In reply to @lily:lily.flowers Wait this would still be yarn v1 right? We don't have yarn-berry in nixpkgs yet I thought
yarn set version 3.4.1
| 13:37:00 |
| 5 Jul 2023 |
adamcstephens | mkYarnPackage reads the package.json from src. This should work as expected right? in https://github.com/NixOS/nixpkgs/pull/241314 the submitter is saying they're receiving this error when trying to build without copying package.json into nixpkgs: https://gist.github.com/GrahamcOfBorg/77965b591af2aef7b6a5c40bb0d08391 | 13:45:33 |
adamcstephens | when i remove it and build everything works correctly | 13:46:05 |
adamcstephens | * when i remove it and build everything works correctly locally | 13:46:57 |
Lily Foster | In reply to @adam:valkor.net mkYarnPackage reads the package.json from src. This should work as expected right? in https://github.com/NixOS/nixpkgs/pull/241314 the submitter is saying they're receiving this error when trying to build without copying package.json into nixpkgs: https://gist.github.com/GrahamcOfBorg/77965b591af2aef7b6a5c40bb0d08391 That's IFD | 14:01:40 |
adamcstephens | i see, so it's expected to copy the package.json into nixpkgs? | 14:02:16 |
Lily Foster | With yarn2nix, yeah unfortunately | 14:09:53 |
Lily Foster | You also need the yarn.lock and yarn.nix... it's, uh, unfortunate | 14:10:13 |
adamcstephens | In reply to @lily:lily.flowers You also need the yarn.lock and yarn.nix... it's, uh, unfortunate so that PR should have both those files included a well? | 14:11:50 |
Lily Foster | I didn't look at the PR, but probably? Try to build with --no-import-from-derivation and see what it needs | 14:12:45 |
adamcstephens | ok, yeah that reproduces the error | 14:15:08 |
adamcstephens | yarn.lock isn't necessary it seems | 14:15:49 |
Lily Foster | Oh really? I may be misremembering then. I try to think about yarn2nix as little as I can | 14:16:27 |
adamcstephens | i was looking at pnpm-lock-export yesterday to see if i could add the newer lock file format. so you're telling me we probably don't want to go pnpm->yarn :) | 14:17:44 |
adamcstephens | I'd like to help find a solution for pnpm before too long since woodpecker is using it | 14:25:02 |
Lily Foster | Well I hope to dump yarn2nix at some point. We're cooking up newer tooling for yarn but it'll be a bit | 14:30:08 |
adamcstephens | the quickest route for pnpm is probably to update the lock exporter, if i can wrap my head around what it's doing | 14:31:18 |
@ambroisie:belanyi.fr | In reply to @adam:valkor.net i was looking at pnpm-lock-export yesterday to see if i could add the newer lock file format. so you're telling me we probably don't want to go pnpm->yarn :) I think using yarn as a stopgap is good enough for our purposes | 19:08:52 |
@ambroisie:belanyi.fr | And thanks for looking into it ❤️ | 19:09:10 |
Lily Foster | In reply to @lily:lily.flowers Well I hope to dump yarn2nix at some point. We're cooking up newer tooling for yarn but it'll be a bit (We have that project board now for anyone who wants to see the rough priority/ordering for stuff. And of course help on any of the "todo" items is very appreciated) | 19:22:20 |