| 21 May 2023 |
hexa | and https://github.com/NixOS/nixpkgs/pull/230991? 😲 | 19:50:04 |
hexa | should we merge botamusique and navidrome with the npmCOnfigHook reschedule hack? | 19:50:34 |
hexa | * should we merge botamusique and navidrome with the npmConfigHook reschedule hack? | 19:50:39 |
Lily Foster | In reply to @hexa:lossy.network should we merge botamusique and navidrome with the npmConfigHook reschedule hack? Given it unblocks those packages, I was starting to think we should just go ahead and merge the npmRoot PR and do further review items in follow-up PRs (and backport post branchoff) | 20:43:35 |
Lily Foster | I would like npmRoot, I was just still wondering if we wanted it on the other hooks so that it worked with buildNpmPackage and wondering if we wanted it also on fetchNpmDeps. But that doesn't need to be a blocker | 20:44:37 |
hexa | Did the npmRoot change work for botamusique? Because it caused problems with navidrome. | 20:44:41 |
Lily Foster | In reply to @hexa:lossy.network Did the npmRoot change work for botamusique? Because it caused problems with navidrome. Oh really? I hadn't tested yet | 20:44:55 |
hexa | https://github.com/NixOS/nixpkgs/pull/230991#issuecomment-1552133508 | 20:45:17 |
Lily Foster | In reply to @hexa:lossy.network https://github.com/NixOS/nixpkgs/pull/230991#issuecomment-1552133508 Weird 🤔 | 20:46:07 |