4 Sep 2023 |
vcunat | These limits are inherited into descendant processes. | 15:34:33 |
vcunat | So each of these processes should be able to use a million file-descriptors. | 15:35:05 |
hexa | except for the test runner, which is stuck with 1024 for some reason | 15:35:23 |
vcunat | Yes, we must be missing something. | 15:35:46 |
vcunat | The systemd option says to set both soft and hard limit, so I assume that's not it. | 15:36:07 |
vcunat | In reply to @hexa:lossy.network except for the test runner, which is stuck with 1024 for some reason Did you see 1024 in some logs? | 15:36:36 |
hexa | I think so | 15:36:55 |
hexa | diff --git a/nixos/tests/firefox.nix b/nixos/tests/firefox.nix
index 3f9cea6662fb..6e311259a6eb 100644
--- a/nixos/tests/firefox.nix
+++ b/nixos/tests/firefox.nix
@@ -58,8 +58,19 @@ in
};
+ extraPythonPackages = ps: with ps; [
+ psutil
+ types-psutil
+ ];
+
testScript = ''
from contextlib import contextmanager
+ import psutil
+
+
+ def sample_open_files():
+ for proc in psutil.process_iter():
+ machine.log(f"{proc.name()}={proc.num_fds()}")
@contextmanager
@@ -95,6 +106,8 @@ in
machine.wait_for_x()
+ sample_open_files()
+
with subtest("Wait until Firefox has finished loading the Valgrind docs page"):
machine.execute(
"xterm -e '${firefoxPackage'.unwrapped.binaryName} file://${pkgs.valgrind.doc}/share/doc/valgrind/html/index.html' >&2 &"
@@ -102,6 +115,8 @@ in
machine.wait_for_window("Valgrind")
machine.sleep(40)
+ sample_open_files()
+
with subtest("Check whether Firefox can play sound"):
with record_audio(machine):
machine.succeed(
| 17:11:19 |
hexa | this is how I sampled open files fwiw | 17:11:24 |
hexa | * this is how I sampled open fds fwiw | 17:11:31 |
nbp | I wonder if this could be the file system bound of the nix store in the VM, but I would not expect Firefox to be the first to hit this limit. | 18:34:25 |
nbp | * I wonder if this could be the file system mound of the nix store in the VM, but I would not expect Firefox to be the first to hit this limit. | 18:36:45 |
nbp | * I wonder if this could be the file system mount of the nix store in the VM, but I would not expect Firefox to be the first to hit this limit. | 18:36:50 |
5 Sep 2023 |
ajs124 | anyone got any time to review https://github.com/NixOS/nixpkgs/pull/252547?
looks like a release with few changes, but I'd rather not self-merge if I can avoid it | 14:09:40 |
hexa | not before nixcon | 14:10:03 |
ajs124 | understandable. I'll take a look at the timeline, when we need this. Then again, since we've split nss, we can just land this with the firefox release that actually requires it. | 14:22:19 |
6 Sep 2023 |
vcunat | September 26 is the closest date with major FF update. We surely don't need it before that. | 06:37:28 |
vcunat | (for stable releases at least) | 06:37:39 |
vcunat | Now I see
++ [ (if (lib.versionAtLeast version "103") then nss_latest else nss_esr) ]
and nss_esr is 3.90 - I wonder if the condition would better be "116".
| 06:58:39 |
vcunat | Uh, confusing. Wiki says "3.92 ESR" is the one for FF 115.
https://wiki.mozilla.org/NSS:Release_Versions | 07:00:49 |
hexa | yeah, sorry. Forgot to update that | 08:22:15 |
hexa | it's a bit annoying when both esr and latest are on the same major version | 08:22:35 |
vcunat | I added the change into that PR. | 15:38:18 |
vcunat | Well, actually I just created the commit and ajs124 added it. | 15:39:28 |
ajs124 | In reply to @vcunat:matrix.org Uh, confusing. Wiki says "3.92 ESR" is the one for FF 115. https://wiki.mozilla.org/NSS:Release_Versions you can poke them in #nss:mozilla.org, if you feel motivated. I think they know their docs aren't in the best shape. Seems like someone worked on that wiki page today. It was even worse before that. | 15:59:50 |
vcunat | I see 3.91 now :-/ | 16:00:43 |
vcunat | But I don't feel motivated for this. | 16:01:46 |
hexa | before nixcon 🙂 | 23:16:15 |
hexa | https://github.com/NixOS/nixpkgs/pull/253739 | 23:19:51 |
9 Sep 2023 |
vcunat | It's high time to default to TB 115 on 23.05, too:
https://github.com/NixOS/nixpkgs/pull/254215 | 10:37:48 |