| 25 Apr 2024 |
| David Mell (zraexy) changed their display name from David Mell to David Mell (zraexy). | 23:51:57 |
| 26 Apr 2024 |
| @antong:mozilla.org left the room. | 18:20:49 |
| pxc changed their display name from pxc to pxc (why). | 23:32:09 |
| pxc changed their display name from pxc (why) to pxc. | 23:32:16 |
| 27 Apr 2024 |
| pxc set a profile picture. | 00:46:04 |
| pxc removed their profile picture. | 00:48:04 |
| @ygt:matrix.org joined the room. | 18:21:46 |
| 28 Apr 2024 |
hexa | vcunat: https://thunderbird.topicbox.com/groups/planning/Tf458e19e4446e1c6 🙂 | 15:29:07 |
vcunat | Oh, interesting. | 15:30:18 |
vcunat | Though I suppose nixpkgs will wait for those months to pass, until upstream deems those versions as suitable defaults. | 15:30:50 |
hexa | certainly | 15:33:26 |
| 29 Apr 2024 |
| NixOS Moderation Botchanged room power levels. | 15:29:39 |
| 30 Apr 2024 |
| @glaringweakness:nope.chat joined the room. | 09:02:15 |
| @glaringweakness:nope.chat changed their display name from glaringweakness to GlaringWeakness. | 09:56:28 |
| 1 May 2024 |
| NixOS Moderation Botchanged room power levels. | 15:06:57 |
| @daschw:matrix.org joined the room. | 18:53:18 |
| 3 May 2024 |
vcunat | Forgot thunderbird 102: https://github.com/NixOS/nixpkgs/pull/308820 | 15:49:56 |
| 13 May 2024 |
hexa | https://github.com/NixOS/nixpkgs/pull/311498 | 23:18:07 |
| 14 May 2024 |
hexa | requires a newer dump_syms version on release-23.11 | 11:38:26 |
hexa | but newer versions fail to build on release-23.11 | 11:38:36 |
hexa | dump_syms> Compiling anstream v0.5.0
dump_syms> error[E0446]: private type `DecodeFailed` in public interface
dump_syms> --> /build/dump_syms-2.3.1-vendor.tar.gz/lzxd/src/bitstream.rs:42:5
dump_syms> |
dump_syms> 42 | pub fn read_bit(&mut self) -> Result<u16, DecodeFailed> {
dump_syms> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't leak private type
dump_syms> |
dump_syms> ::: /build/dump_syms-2.3.1-vendor.tar.gz/lzxd/src/lib.rs:99:1
dump_syms> |
dump_syms> 99 | enum DecodeFailed {
dump_syms> | ----------------- `DecodeFailed` declared as private
dump_syms>
dump_syms> error[E0446]: private type `DecodeFailed` in public interface
dump_syms> --> /build/dump_syms-2.3.1-vendor.tar.gz/lzxd/src/bitstream.rs:85:5
dump_syms> |
dump_syms> 85 | pub fn read_bits(&mut self, bits: u8) -> Result<u32, DecodeFailed> {
dump_syms> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't leak private type
dump_syms> |
dump_syms> ::: /build/dump_syms-2.3.1-vendor.tar.gz/lzxd/src/lib.rs:99:1
dump_syms> |
dump_syms> 99 | enum DecodeFailed {
dump_syms> | ----------------- `DecodeFailed` declared as private
dump_syms>
dump_syms> error[E0446]: private type `DecodeFailed` in public interface
dump_syms> --> /build/dump_syms-2.3.1-vendor.tar.gz/lzxd/src/bitstream.rs:143:5
dump_syms> |
dump_syms> 143 | pub fn read_u32_le(&mut self) -> Result<u32, DecodeFailed> {
dump_syms> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't leak private type
dump_syms> |
dump_syms> ::: /build/dump_syms-2.3.1-vendor.tar.gz/lzxd/src/lib.rs:99:1
dump_syms> |
dump_syms> 99 | enum DecodeFailed {
dump_syms> | ----------------- `DecodeFailed` declared as private
dump_syms>
dump_syms> error[E0446]: private type `DecodeFailed` in public interface
dump_syms> --> /build/dump_syms-2.3.1-vendor.tar.gz/lzxd/src/bitstream.rs:149:5
dump_syms> |
dump_syms> 149 | pub fn read_u24_be(&mut self) -> Result<u32, DecodeFailed> {
dump_syms> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't leak private type
dump_syms> |
dump_syms> ::: /build/dump_syms-2.3.1-vendor.tar.gz/lzxd/src/lib.rs:99:1
dump_syms> |
dump_syms> 99 | enum DecodeFailed {
dump_syms> | ----------------- `DecodeFailed` declared as private
dump_syms>
dump_syms> error[E0446]: private type `DecodeFailed` in public interface
dump_syms> --> /build/dump_syms-2.3.1-vendor.tar.gz/lzxd/src/bitstream.rs:155:5
dump_syms> |
dump_syms> 155 | pub fn align(&mut self) -> Result<(), DecodeFailed> {
dump_syms> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't leak private type
dump_syms> |
dump_syms> ::: /build/dump_syms-2.3.1-vendor.tar.gz/lzxd/src/lib.rs:99:1
dump_syms> |
dump_syms> 99 | enum DecodeFailed {
dump_syms> | ----------------- `DecodeFailed` declared as private
dump_syms>
dump_syms> error[E0446]: private type `DecodeFailed` in public interface
dump_syms> --> /build/dump_syms-2.3.1-vendor.tar.gz/lzxd/src/bitstream.rs:165:5
dump_syms> |
dump_syms> 165 | pub fn read_raw(&mut self, output: &mut [u8]) -> Result<(), DecodeFailed> {
dump_syms> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't leak private type
dump_syms> |
dump_syms> ::: /build/dump_syms-2.3.1-vendor.tar.gz/lzxd/src/lib.rs:99:1
dump_syms> |
dump_syms> 99 | enum DecodeFailed {
dump_syms> | ----------------- `DecodeFailed` declared as private
dump_syms>
dump_syms> error[E0446]: private type `DecodeFailed` in public interface
dump_syms> --> /build/dump_syms-2.3.1-vendor.tar.gz/lzxd/src/tree.rs:40:5
dump_syms> |
dump_syms> 40 | pub fn create_instance_allow_empty(&self) -> Result<Option<Tree>, DecodeFailed> {
dump_syms> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't leak private type
dump_syms> |
dump_syms> ::: /build/dump_syms-2.3.1-vendor.tar.gz/lzxd/src/lib.rs:99:1
dump_syms> |
dump_syms> 99 | enum DecodeFailed {
dump_syms> | ----------------- `DecodeFailed` declared as private
dump_syms>
dump_syms> error[E0446]: private type `DecodeFailed` in public interface
dump_syms> --> /build/dump_syms-2.3.1-vendor.tar.gz/lzxd/src/tree.rs:98:5
dump_syms> |
dump_syms> 98 | pub fn create_instance(&self) -> Result<Tree, DecodeFailed> {
dump_syms> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't leak private type
dump_syms> |
dump_syms> ::: /build/dump_syms-2.3.1-vendor.tar.gz/lzxd/src/lib.rs:99:1
dump_syms> |
dump_syms> 99 | enum DecodeFailed {
dump_syms> | ----------------- `DecodeFailed` declared as private
dump_syms>
dump_syms> error[E0446]: private type `DecodeFailed` in public interface
dump_syms> --> /build/dump_syms-2.3.1-vendor.tar.gz/lzxd/src/tree.rs:104:5
dump_syms> |
dump_syms> 104 | / pub fn update_range_with_pretree(
dump_syms> 105 | | &mut self,
dump_syms> 106 | | bitstream: &mut Bitstream,
dump_syms> 107 | | range: Range<usize>,
dump_syms> 108 | | ) -> Result<(), DecodeFailed> {
dump_syms> | |_________________________________^ can't leak private type
dump_syms> |
dump_syms> ::: /build/dump_syms-2.3.1-vendor.tar.gz/lzxd/src/lib.rs:99:1
dump_syms> |
dump_syms> 99 | enum DecodeFailed {
dump_syms> | ----------------- `DecodeFailed` declared as private
dump_syms>
dump_syms> error[E0446]: private type `DecodeFailed` in public interface
dump_syms> --> /build/dump_syms-2.3.1-vendor.tar.gz/lzxd/src/tree.rs:187:5
dump_syms> |
dump_syms> 187 | pub fn from_path_lengths(path_lengths: Vec<u8>) -> Result<Self, DecodeFailed> {
dump_syms> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't leak private type
dump_syms> |
dump_syms> ::: /build/dump_syms-2.3.1-vendor.tar.gz/lzxd/src/lib.rs:99:1
dump_syms> |
dump_syms> 99 | enum DecodeFailed {
dump_syms> | ----------------- `DecodeFailed` declared as private
dump_syms>
dump_syms> error[E0446]: private type `DecodeFailed` in public interface
dump_syms> --> /build/dump_syms-2.3.1-vendor.tar.gz/lzxd/src/tree.rs:191:5
dump_syms> |
dump_syms> 191 | pub fn decode_element(&self, bitstream: &mut Bitstream) -> Result<u16, DecodeFailed> {
dump_syms> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't leak private type
dump_syms> |
dump_syms> ::: /build/dump_syms-2.3.1-vendor.tar.gz/lzxd/src/lib.rs:99:1
dump_syms> |
dump_syms> 99 | enum DecodeFailed {
dump_syms> | ----------------- `DecodeFailed` declared as private
dump_syms>
dump_syms> error[E0446]: private type `DecodeFailed` in public interface
dump_syms> --> /build/dump_syms-2.3.1-vendor.tar.gz/lzxd/src/window.rs:126:5
dump_syms> |
dump_syms> 126 | / pub fn copy_from_bitstream(
dump_syms> 127 | | &mut self,
dump_syms> 128 | | bitstream: &mut Bitstream,
dump_syms> 129 | | len: usize,
dump_syms> 130 | | ) -> Result<(), DecodeFailed> {
dump_syms> | |_________________________________^ can't leak private type
dump_syms> |
dump_syms> ::: /build/dump_syms-2.3.1-vendor.tar.gz/lzxd/src/lib.rs:99:1
dump_syms> |
dump_syms> 99 | enum DecodeFailed {
dump_syms> | ----------------- `DecodeFailed` declared as private
dump_syms>
dump_syms> error[E0446]: private type `DecodeFailed` in public interface
dump_syms> --> /build/dump_syms-2.3.1-vendor.tar.gz/lzxd/src/window.rs:149:5
dump_syms> |
dump_syms> 149 | pub fn past_view(&mut self, len: usize) -> Result<&mut [u8], DecodeFailed> {
dump_syms> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't leak private type
dump_syms> |
dump_syms> ::: /build/dump_syms-2.3.1-vendor.tar.gz/lzxd/src/lib.rs:99:1
dump_syms> |
dump_syms> 99 | enum DecodeFailed {
dump_syms> | ----------------- `DecodeFailed` declared as private
dump_syms>
dump_syms> For more information about this error, try `rustc --explain E0446`.
dump_syms> error: could not compile `lzxd` (lib) due to 13 previous errors
dump_syms> warning: build failed, waiting for other jobs to finish...
| 11:39:04 |
hexa | also tried against rust 1.73 | 11:39:31 |
hexa | wondering if I need to go even newer? | 11:39:43 |
nbp | One alternative would be to add a pub keyword in front of the enum, but this is indeed strange. | 12:37:30 |
@yannis:mozilla.org | Seems like it could be a bug introduced by https://github.com/Lonami/lzxd/commit/7fe722dde4ed6add5176bba7c5662b5fff09759e | 13:37:30 |
@yannis:mozilla.org | (well that's quite old though) | 13:58:15 |
nbp | have we vendored a newer version since? | 14:01:10 |
hexa | I think the vendor tarball is what our builder creates 🤔 | 14:06:27 |
hexa | nvm, I have 1.76 as the newer version, not 1.73 | 14:11:15 |
hexa | and with 1.76 it builds | 14:11:18 |