| 12 Mar 2025 |
 emily | and push to the branch the PR is on | 01:30:19 |
| emily | yeah | 01:30:20 |
 colemickens | which, it was hard to imagine how else it might've worked | 01:30:23 |
| emily | it's a toggle they can turn on/off | 01:30:24 |
 K900 | That was weird timing | 01:34:23 |
| K900 | I got woken up literally right now | 01:34:35 |
| K900 | It's 4:30AM | 01:34:39 |
 Artturin | yeah gh pr checkout just does that for you | 01:36:54 |
| K900 | @colemickens:matrix.org for devedition (and in general), branch is just the attr name in the JSON blob, and channel is a weird magic thing that firefox-unwrapped-bin uses | 01:39:09 |
| K900 | https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/networking/browsers/firefox-bin/default.nix#L30 | 01:40:15 |
| K900 | So it needs to match the actual executable name. | 01:40:44 |
| K900 | You can probably just see what it's set to in the nixpkgs Firefox-devedition-bin | 01:42:00 |
| K900 | (also writing this here and not on gh because I'm on my phone) | 01:43:09 |
| colemickens | no worries, thanks for replying. | 01:51:05 |
| colemickens | I fixed it up, should be good. I'll merge it in a bit if there are no concerns raised. | 01:51:19 |
| K900 | Seems fine at a glance at least | 01:53:28 |
| colemickens | cool thanks, I'll merge it | 01:55:11 |
| colemickens | thanks as always K900 ! | 02:02:07 |
