| 28 Mar 2025 |
 eveeifyeve | and apply a custom mozilla config. | 14:56:23 |
 emily | yes, I don't know how that works with buildMozillaMach though | 14:56:53 |
| eveeifyeve | * and apply a custom mozilla config.
https://github.com/zen-browser/desktop/blob/dev/configs/macos/mozconfig | 14:56:54 |
 vcunat | You can put whatever derivation into src =, i.e. construct the desired source in whatever way beforehand. | 14:57:13 |
| vcunat | * You could alternatively put whatever derivation into src =, i.e. construct the desired source in whatever way beforehand. | 14:57:29 |
| emily | I am not sure we would want to use their mozconfigs totally verbatim? it may be a good idea to diff them against the upstream ones. but I don't know that much about how the mach build actually works, so I defer to active packagers of Mozilla stuff here | 14:58:14 |
| vcunat | I've done just routine updates and testing as far as I recall, really. | 15:00:09 |
| vcunat | I don't understand/remember what's happening inside. | 15:00:33 |
| eveeifyeve | How exactly would that be possible from the firefox source? | 15:10:26 |
| eveeifyeve | * How exactly would that be possible from the firefox source? cause I don't see any functions that would do that. | 15:10:43 |
| emily | buildMozillaMach takes arguments for patches | 15:11:08 |
| emily | not sure if it can take globs or not | 15:11:29 |
| emily | the usual patches can | 15:11:36 |
| eveeifyeve | could you provide me an example because I tired extraPatches = ["${zensource}/src/**/*.patch"]; which is the fetchFromGitHub | 15:11:57 |
| eveeifyeve | and it said no directry found | 15:12:14 |
| eveeifyeve | * and it said no directory found | 15:12:19 |
| eveeifyeve | zen-browser-unwrapped> /nix/store/c2g9v6m9qp4lf93ck4apw848cws78wzj-stdenv-darwin/setup: line 1421: /nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/**/*.patch: No such file or directory | 15:12:28 |
| emily | my guess is extglob isn't on so ** isn't matching as expected? it might make sense to do it in unpackPhase instead or something. | 15:14:33 |
| eveeifyeve | Redacted or Malformed Event | 15:20:23 |
| eveeifyeve | Since there is patchs also in surfer that will have to be included as well. | 15:39:47 |
| eveeifyeve | Also there is js/css files in browser repo do I add those to source? | 15:40:08 |
| emily | wait, where? | 15:42:17 |
| eveeifyeve | /nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/app/profile/zen-browser.js
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-animations.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-branding.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-browser-container.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-browser-ui.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-buttons.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-compact-mode.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-decks.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-folders.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-glance.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-gradient-generator.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-media-controls.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-panel-ui.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-panels/bookmarks.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-panels/dialog.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-panels/extensions.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-panels/print.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-popup.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-rices.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-sidebar-panels.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-sidebar.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-single-components.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-tabs.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-tabs/horizontal-tabs.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-tabs/vertical-tabs-topbar.inc.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-tabs/vertical-tabs-topbuttons-fix.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-tabs/vertical-tabs.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-theme.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-toolbar.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-urlbar.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-welcome.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-styles/zen-workspaces.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zen-vendor/tsparticles.confetti.bundle.min.js
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/base/content/zenThemeModifier.js
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/components/places/content/zenNewWebPanel.js
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/components/preferences/zen-settings.js
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/themes/shared/preferences/zen-preferences.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/themes/shared/zen-icons/icons.css
/nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/browser/themes/shared/zen-icons/lin/icons.css
| 15:42:49 |
| eveeifyeve | This is directly from zen source but in a nix store. | 15:43:24 |
| emily | I meant the patches in surfer | 15:44:18 |
| eveeifyeve | https://github.com/zen-browser/surfer/tree/main/template/src/browser/themes.optional | 15:44:54 |
| emily | that's an example template. | 15:51:15 |
| emily | hopefully the example template is not load-bearing. | 15:51:25 |
| eveeifyeve | I also ran into:
> /nix/store/c2g9v6m9qp4lf93ck4apw848cws78wzj-stdenv-darwin/setup: line 1771: /nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/**/*.patch: ambiguous redirect
| 15:53:05 |
| eveeifyeve | * I also ran into:
> /nix/store/c2g9v6m9qp4lf93ck4apw848cws78wzj-stdenv-darwin/setup: line 1771: /nix/store/fbck76hxp37rdsaiqqjdaq7g2yp97imc-source/src/**/*.patch: ambiguous redirect
| 15:53:09 |
