| 16 Oct 2024 |
|  @yannis:mozilla.org changed their display name from yannis|pto back oct 16 to yannis. | 06:58:56 |
 Artturin | https://github.com/NixOS/nixpkgs/pull/349116 | 19:26:19 |
| 22 Oct 2024 |
 hexa | I'm not sure how I feel about about the PR to add darwin support for firefox-unwrapped | 11:20:12 |
| hexa | especially from a relatively new maintainer | 11:20:40 |
| hexa | there's probably little choice than given it a shot? | 11:21:24 |
 K900 ⚡️ | It was discussed in the Mac room a bunch the other day | 11:25:20 |
| K900 ⚡️ | Maybe you should talk to the Darwin people about it | 11:25:36 |
| K900 ⚡️ | They probably have a better idea of how annoying it'll be to maintain | 11:25:55 |
 vcunat | An alternative would be to separate it. | 11:26:05 |
| vcunat | Because what do we do on updates when darwin version breaks and isn't easy to fix? | 11:26:26 |
| vcunat | Maybe it won't ever happen that way and we could split at that point, though. | 11:28:01 |
| hexa | * there's probably little choice than giving it a shot? | 11:34:32 |
| 23 Oct 2024 |
|  @luna-null:matrix.org changed their display name from Autumn to luna-null. | 09:49:30 |
| 24 Oct 2024 |
|  jopejoe1 (4094@39c3) set a profile picture. | 07:34:43 |
| 25 Oct 2024 |
|  lholh joined the room. | 03:54:23 |
|  chrispickard left the room. | 18:51:21 |
| 27 Oct 2024 |
|  ritiek joined the room. | 23:19:15 |
| 29 Oct 2024 |
| vcunat | https://github.com/NixOS/nixpkgs/pull/352161 | 19:33:23 |
|  Scrumplex joined the room. | 20:07:42 |
| Scrumplex | both -devedition and -beta fail to apply /nix/store/9lx1746yy56pn3dpc35l1xr6l3lykbin-env_var_for_system_dir-ff111.patch in the PR above | 20:10:38 |
| Scrumplex | Looking at the trunk (tip?) it just seems like it was moved around in the file. I will try to update the patch for 133 onwards | 20:11:20 |
|  syd installs gentoo (they/them) joined the room. | 20:13:37 |
| hexa | ok | 20:17:36 |
| Scrumplex | Current patch versus new patch. Seems like the function signature has changed slightly:
--- pkgs/applications/networking/browsers/firefox/env_var_for_system_dir-ff111.patch 2024-08-10 21:13:22.142083987 +0200
+++ pkgs/applications/networking/browsers/firefox/env_var_for_system_dir-ff133.patch 2024-10-29 21:25:17.412737463 +0100
@@ -10,13 +10,13 @@
#include "prprf.h"
#include "nsIAppStartup.h"
-@@ -309,7 +310,8 @@ static nsresult GetSystemParentDirectory(nsIFile** aFile) {
+@@ -297,7 +297,8 @@ static nsresult GetSystemParentDirectory(nsIFile** aFile) {
"/usr/lib/mozilla"_ns
# endif
;
-- rv = NS_NewNativeLocalFile(dirname, false, getter_AddRefs(localDir));
+- rv = NS_NewNativeLocalFile(dirname, getter_AddRefs(localDir));
+ const char* pathVar = PR_GetEnv("MOZ_SYSTEM_DIR");
-+ rv = NS_NewNativeLocalFile((pathVar && *pathVar) ? nsDependentCString(pathVar) : reinterpret_cast<const nsCString&>(dirname), false, getter_AddRefs(localDir));
++ rv = NS_NewNativeLocalFile((pathVar && *pathVar) ? nsDependentCString(pathVar) : reinterpret_cast<const nsCString&>(dirname), getter_AddRefs(localDir));
# endif
if (NS_SUCCEEDED(rv)) {
| 20:26:49 |
| Scrumplex | This new patch applied successfully. Let's see if it will build | 20:27:55 |
| Scrumplex | Nope :(
> 1:02.52(B checking for nss >= 3.106... no(B(B
> 1:02.52(B ERROR: Requested 'nss >= 3.106' but version of NSS is 3.105.0(B(B
| 20:29:39 |
| hexa | on staging | 20:29:44 |
| Scrumplex | I see. Sooo rebase the PR on staging? | 20:30:00 |
| hexa | because ... reasons | 20:30:02 |
| hexa | let me check | 20:30:14 |
