| 24 Nov 2023 |
 hexa | In reply to @nbp:mozilla.org
hum … it does not use the extra computer :/ I think you probably need to reference the bull configuration in --builders, unless you reference a host from /etc/nix/machines | 16:53:16 |
| hexa | In reply to @nbp:mozilla.org
hum … it does not use the extra computer :/ * I think you need to reference the bull configuration in --builders, unless you reference a host from /etc/nix/machines | 16:53:20 |
| hexa | * I think you need to reference the full configuration in --builders, unless you reference a host from /etc/nix/machines | 16:53:27 |
| hexa | $ nm -D result/bin/.firefox-wrapped| grep _S_initialize
$
| 17:03:54 |
| hexa | diff --git a/pkgs/applications/networking/browsers/firefox/common.nix b/pkgs/applications/networking/browsers/firefox/common.nix
index aadbb32d6e02..a0c151a99c11 100644
--- a/pkgs/applications/networking/browsers/firefox/common.nix
+++ b/pkgs/applications/networking/browsers/firefox/common.nix
@@ -506,6 +506,10 @@ buildStdenv.mkDerivation ({
cd ..
'';
+ NIX_LDFLAGS = lib.optionals stdenv.cc.isGNU [
+ "-L${stdenv.cc.cc.lib}/lib"
+ ];
+
makeFlags = extraMakeFlags;
separateDebugInfo = enableDebugSymbols;
enableParallelBuilding = true;
| 17:04:13 |
| hexa | https://github.com/NixOS/nixpkgs/pull/269680 | 17:26:18 |
 vcunat | In reply to @hexa:lossy.network
https://github.com/NixOS/nixpkgs/pull/269680 If you've tested that it fixes the issue for you, I see no reason to wait. | 17:40:25 |
| hexa | In reply to @hexa:lossy.network
$ nm -D result/bin/.firefox-wrapped| grep _S_initialize
$
the only test I did | 17:41:28 |
| hexa | I had to change locations in between | 17:41:42 |
| hexa | I can try whether webgl works now, just have to grab the output | 17:41:56 |
| hexa | nope, probably broken for other reasons | 17:45:49 |
| vcunat | But it doesn't crash anymore at least? | 17:47:54 |
| hexa | I was unable to reproduce with the 23.05 binary on unstable | 17:48:08 |
| vcunat | That one was crashing for me within minutes of my normal usage, repeatedly. | 17:49:05 |
| vcunat | Let me try. I'm building it already. | 17:49:29 |
| hexa | ok, thanks | 17:50:04 |
| vcunat | It'll probably have 16 threads for itself, but even so it will surely take some time to build. | 17:52:09 |
| vcunat | But if 119 had working webgl on 23.05 and this way 120 still won't have it working... | 17:53:08 |
| vcunat | https://webglsamples.org/aquarium/aquarium.html running for me | 18:36:44 |
| hexa | nevertheless I would revert this change on staging-23.05, because we most likely identified the treewide fix | 18:37:44 |
| hexa | I therefore lack interest in clarifying the comment any further | 18:38:12 |
| hexa | * I therefore lack interest to clarify the comment any further, the commit message holds all the interesting references | 18:38:29 |
| hexa | trigger eval on 23.05 | 18:41:33 |
| hexa | * triggered eval on 23.05 | 18:42:33 |
| hexa | * triggered eval on release-23.05 | 18:42:36 |
| hexa | * triggered eval on nixos/release-23.05 | 18:42:41 |
| vcunat | I cancelled the previous one. They'd often be useless builds. | 18:45:03 |
| vcunat | Images and tests get relativeely expensive on Hydra. | 18:45:32 |
| vcunat | * Images and tests get relatively expensive on Hydra. | 18:45:34 |
| hexa | tested as probably done, so it will advance anyway, right? | 18:46:12 |
