| 20 Sep 2023 |
 K900 ⚡️ | https://github.com/nix-community/flake-firefox-nightly/commit/7ea3ab1750b95bf498ea21e2065d6ddcc99904af | 15:28:29 |
| K900 ⚡️ | The bot immediately sniped you lol | 15:28:32 |
 colemickens | yeah, the CI doesn't block on the test... ugh. | 15:29:17 |
| colemickens | issue opened, new revert merged | 15:30:29 |
| colemickens | hopefully this'll do the trick : https://github.com/nix-community/flake-firefox-nightly/pull/19 | 15:32:44 |
| colemickens | welp, gotta wash my hands of this for now, at least it should stay not-broken for users: https://github.com/nix-community/flake-firefox-nightly/issues/20 | 15:46:49 |
| colemickens | * welp, gotta wash my hands of this for now, at least it should stay not-broken for users: https://github.com/nix-community/flake-firefox-nightly/issues/20 (test can't run in actions, it wants kvm) | 15:47:00 |
 Artturin | colemickens: maybe the action should be run once per hour or longer so we don't use up all the minutes on nscloud | 17:56:31 |
| colemickens | Yes. Also: https://github.com/nix-community/flake-firefox-nightly/issues/16 | 17:57:02 |
| colemickens | Looks like the latest try is "working" but indeed, burning minutes due to #16. | 17:57:23 |
| Artturin | there was a another update which wasn't reverted https://github.com/nix-community/flake-firefox-nightly/commit/592c85e8b49d6f84d5976a41e6e91ec521cf0bc7 | 18:04:21 |
| Artturin | * there was a another update made before blocking on tests which wasn't reverted https://github.com/nix-community/flake-firefox-nightly/commit/592c85e8b49d6f84d5976a41e6e91ec521cf0bc7 | 18:04:45 |
| colemickens | dear god | 18:06:12 |
| colemickens | thx | 18:06:14 |
| colemickens | I might force push it instead of sending a revert. | 18:06:32 |
| colemickens | As soon as I get this cron syntax :/ | 18:06:37 |
| colemickens | cron: '*/60 * * * *' should be it tho | 18:06:57 |
| colemickens | I think | 18:06:58 |
| Artturin | wait_for_window doesn't have a timeout parameter like wait_until_succeeds https://github.com/NixOS/nixpkgs/blob/008c18a71c0052996010f63b1ac322bf3f10270f/nixos/lib/test-driver/test_driver/machine.py#L1173 | 18:07:24 |
| Artturin | it uses retry and wait_until_succeed does too | 18:08:41 |
| Artturin | gonna try to add one | 18:08:48 |
| Artturin | * gonna try to add timeout | 18:08:50 |
| colemickens | wdyt, I can just move the nix flake check to a separate step and add a time out for it? | 18:08:56 |
| colemickens | I'll wait for you | 18:09:02 |
| colemickens | * I'll wait for you (and not make the most recent change) gonna force push right now | 18:09:17 |
| colemickens | feel free to push it if you get it going, I've gotta get some air and food. | 18:10:18 |
| colemickens | (manually canceling runs for now to save the minutes) | 18:11:10 |
| Artturin | found https://github.com/NixOS/nixpkgs/pull/192593 gonna rebase it to resolve conflicts | 18:21:58 |
| colemickens | You thinking of patching the input nixpkgs with that, then? (also, nice!) | 18:31:49 |
| Artturin | Ok
BTW
https://github.com/NixOS/nix/pull/6530 will have support for patchFiles in inputs | 18:43:07 |
