| 19 Sep 2023 |
nbp | good point. | 14:07:24 |
K900 ⚡️ | nspr itself looks like a normal ELF | 14:08:38 |
K900 ⚡️ | Ish | 14:08:40 |
vcunat | Don't we pull our nspr into the binaries? | 14:08:46 |
K900 ⚡️ | That's Nightly so we shouldn't | 14:08:53 |
vcunat | (I'm not really familiar with that flake.) | 14:09:26 |
vcunat | * (OK, I'm not really familiar with that flake.) | 14:09:29 |
nbp | if the flake is done like nixpkgs-mozilla, it just replace the source of firefox-bin. | 14:10:45 |
vcunat | firefox-bin in nixpkgs takes lots of libs including nspr and stuffs it into RPATH. | 14:11:57 |
vcunat | * firefox-bin in nixpkgs takes lots of libs including nspr and stuffs them into RPATH. | 14:12:11 |
vcunat | * firefox-bin in nixpkgs takes lots of libs including nspr and patchelfs them into RPATH. | 14:12:37 |
K900 ⚡️ | @nbp so uh | 14:23:28 |
K900 ⚡️ | Any idea what "relrhack" is | 14:23:34 |
K900 ⚡️ | https://hg.mozilla.org/mozilla-central/rev/032b87ff55061bcbdc7a85d9e18fde814797073a | 14:23:35 |
K900 ⚡️ | That's the only sus commit I've found | 14:23:51 |
nbp | elfhack used to be a mechanism to re-order the symbol of the binary such that they appear in the order in which the CPU would read them. | 14:50:02 |
nbp | It is possible that patchelf does not like patching binaries produced by elfhack. | 14:50:59 |
nbp | I do not know what relrhack is. | 14:51:43 |
K900 ⚡️ | And relrhack, seemingly, is a ... reimplementation of elfhack? Maybe? | 14:51:49 |
nbp | * It is possible that patchelf does not like patching binaries produced by relrhack. | 14:51:52 |
K900 ⚡️ | Or something? | 14:52:14 |
hexa | https://glandium.org/blog/?p=4297 | 14:52:39 |
K900 ⚡️ | Yeah I definitely suspect patchelf fuckery then | 14:54:14 |
vcunat | Bugs in patchelf do get discovered occasionally. | 15:08:39 |
nbp | well, is this patchelf or relrhack? | 15:52:42 |
K900 ⚡️ | patchelf is the thing we use | 16:15:29 |
K900 ⚡️ | relrhack is the thing you (now?) use | 16:15:36 |
nbp | patchelf, is the thing Nixpkgs uses to make binary lookup their dependencies with a custom RPATH. relrhack is something Mozilla recently added. | 16:16:44 |
vcunat | I suspect it will be more like which side is easier to fix than which side has larger blame. | 16:16:52 |
nbp | valgrind for example does not care about patchelf-ed binaries … | 16:18:02 |