| 24 Jan 2022 |
 CRTified | Just a visual artifact? | 23:40:13 |
 samueldr | not sure | 23:40:28 |
| CRTified | Other simple definitions only use 3 ID bytes, too: https://github.com/torvalds/linux/blob/master/drivers/mtd/spi-nor/xmc.c | 23:41:08 |
| samueldr | should be fine, comparison happens against .id_len | 23:41:47 |
| samueldr | from the expansion of the INFO macro | 23:42:03 |
| CRTified | I think I can see what went wrong | 23:43:42 |
| CRTified | The patch supplies five arguments to INFO | 23:43:51 |
| CRTified | * The patch supplies five arguments to INFO | 23:43:56 |
| CRTified | but it expects only 4 🤔 | 23:44:03 |
| samueldr | I was about to say | 23:44:09 |
| samueldr | something else | 23:44:15 |
| CRTified | That seems a bit off | 23:44:22 |
| samueldr | Used when the "_ext_id" is two bytes at most | 23:44:20 |
| samueldr | there was a change recently enough | 23:44:30 |
| CRTified | (At least in comparison with the xmc.c definition) | 23:44:34 |
| samueldr | so this patch is bitrotted a little | 23:44:40 |
| CRTified | Oh okay, I already fixed it so that the Makefile patch applies | 23:44:55 |
| CRTified | Thanks, that might be the culprit then | 23:45:07 |
| samueldr | two changes even
| 23:45:25 |
| samueldr | ignore the latter one, I guess it could be fine | 23:45:45 |
| samueldr | * ignore the latter one, I guess it could be fine | 23:46:09 |
| CRTified | Guess I'll have to source the other flash listed in that patch to test both definitions before resubmitting that patch 😀 | 23:47:56 |
| 25 Jan 2022 |
| CRTified | Okay, I was targeting 5.10, whereas the changes came afterwards | 00:04:00 |
| CRTified | Oviously failed to compile, and INFO takes 5 args there | 00:04:16 |
| CRTified | But then what might cause it to not work? 🤔 | 00:05:47 |
| CRTified | Guess I found the culprit. https://github.com/torvalds/linux/blob/4aa1b8257fba5931511a7e152bcbbb3dd673c6c1/drivers/mtd/spi-nor/core.c#L1831-L1850 It doesn't get added to this list | 00:27:03 |
| CRTified | [ 0.000000] GICv3: 256 SPIs implemented
[ 0.000000] GICv3: 0 Extended SPIs implemented
[ 2.456530] spi-nor spi1.0: xt25f32b (4096 Kbytes)
That looks successful 🙂
| 01:11:23 |
| CRTified | Thanks for your help samueldr | 01:11:29 |
 K900 | Good news | 11:12:54 |
| K900 | https://www.bloomberg.com/news/articles/2022-01-25/nvidia-is-said-to-quietly-prepare-to-abandon-takeover-of-arm | 11:12:58 |
