!UNVBThoJtlIiVwiDjU:nixos.org

Staging

187 Members
Staging merges | Running staging cycles: https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+is%3Aopen+head%3Astaging-next+head%3Astaging-next-24.05 | Review Reports: https://malob.github.io/nix-review-tools-reports/70 Servers

Load older messages


SenderMessageTime
17 Oct 2024
@k900:0upti.meK900I think we need to do it at pkgconfig level11:06:33
@qyliss:fairydust.spaceAlyssa RossI think upstream would tell you that's part of the design of pkg-config11:06:37
@qyliss:fairydust.spaceAlyssa Rossit's on purpose that these are not absolute paths11:06:50
@emilazy:matrix.orgemily we also can't do that with .sos 11:06:52
@emilazy:matrix.orgemilywhich we also early-bind more than other distros11:07:02
@emilazy:matrix.orgemily it occurs to me that I don't actually know how .override works with propagated inputs. do they magically become faux parameters? 11:07:17
@qyliss:fairydust.spaceAlyssa RossI'm not saying it makes sense to do this in Nixpkgs, but that I think this is how upstream will see it.11:07:20
@k900:0upti.meK900 Ideally I think it should be something like libffi=/nix/store/... 11:07:43
@emilazy:matrix.orgemilyah. well I'm not asking upstream to change any behaviour, I'm just hoping that we can agree on a way to do an opt-in strange thing that we want to do11:07:46
@k900:0upti.meK900 So it searches PKGCONFIGPATH first 11:07:48
@k900:0upti.meK900 So it searches PKG_CONFIG_PATH first 11:07:52
@emilazy:matrix.orgemilyI expect that the patch would be non-invasive, so it would be OK if we have to carry it long-term, but hopefully not11:08:05
@k900:0upti.meK900But has a fallback11:08:05
@emilazy:matrix.orgemily (beats the pkg-config patch we currently haveā€¦) 11:08:22
@qyliss:fairydust.spaceAlyssa Rosssearching first and falling back sounds more reasonable to me11:08:42
@emilazy:matrix.orgemilysure, that sounds good11:08:49
@emilazy:matrix.orgemily we could just have a fallback_pkg_config_path variable or something 11:09:04
@emilazy:matrix.orgemily in .pc files 11:09:05
@emilazy:matrix.orgemily that we make pkgconf look at when lookup fails 11:09:12
@emilazy:matrix.orgemily though I question if we really want to automagically override private dependencies of dependencies just because you included a package that exposes the same .pc in your derivation 11:09:29
@emilazy:matrix.orgemilyit breaks the encapsulation11:09:32
@emilazy:matrix.orgemily you're not supposed to know that wlroots uses libffi 11:09:42
@emilazy:matrix.orgemily but if using libffi-hax in your derivation changes the one wlroots finds, then you have to know that 11:09:59
@k900:0upti.meK900But then linking explodes11:10:02
@emilazy:matrix.orgemily well, true, we really want .pc files to use absolute paths for that too :') 11:10:26
@k900:0upti.meK900WAIT WHAT11:10:34
@k900:0upti.meK900OK hold11:10:37
@k900:0upti.meK900HOLD11:10:38
@emilazy:matrix.orgemilyand even then there's symbol collisions, of course, nobody does namespacing right11:10:39
@k900:0upti.meK900I just built Cairo on master11:10:44

Show newer messages


Back to Room ListRoom Version: 6