17 Oct 2024 |
Alyssa Ross | TIL we have a pkg-configUpstream package | 10:18:40 |
Alyssa Ross | which is not used anywhere | 10:18:47 |
emily | yeah there's some "vanilla" flag | 10:18:52 |
emily | which I guess disables our broken patches | 10:18:56 |
Alyssa Ross | which does nothing but remove this patch | 10:19:01 |
Alyssa Ross | so… do we think cage builds with pkg-configUpstream | 10:19:22 |
emily | I promise I'll switch us to pkgconf for the next release… 🫠 | 10:19:24 |
emily | I like how we have a Cygwin-only patch that does patching to its vendored copy of glib. | 10:20:14 |
emily | really awesome things going on in this derivation | 10:20:21 |
hexa | In reply to @emilazy:matrix.org https://github.com/NixOS/nixpkgs/pull/2798 wow, we didn't even have staging qua staging back then? https://github.com/NixOS/rfcs/blob/master/rfcs/0026-staging-workflow.md | 10:20:24 |
emily | that PR seemed like it was before staging entirely. so I guess in ~2014 we got staging and then in 2018 we got staging-next ? | 10:21:22 |
vcunat | I'd prefer not to change pkg-config propagation semantics this close to forking stable. | 10:21:30 |
Alyssa Ross | Then I think we should probably revert K900's thing
| 10:21:52 |
emily | we did just rewrite the entirety of Darwin support, don't Linux people deserve a bit of fun and excitement too? | 10:22:06 |
emily | maybe we could just give cage the vanilla package for now | 10:22:26 |
Alyssa Ross | I'm worried about other fallout | 10:22:55 |
emily | what was the K900 change that caused this specifically? I missed that part | 10:23:14 |
vcunat | This? https://github.com/NixOS/nixpkgs/pull/348483 | 10:23:33 |
Alyssa Ross | https://github.com/NixOS/nixpkgs/pull/348483 | 10:23:34 |
emily | ah, yes | 10:24:22 |
emily | I guess if we're going to change pkg-config semantics it makes sense to just do it when we switch to pkgconf , if everything is working fine except for this patch. | 10:25:19 |
K900 | I disagree tbh | 10:25:21 |
emily | it's adding back a hack to avoid removing another hack | 10:25:32 |
K900 | Reverting that would just paper over a few things | 10:25:36 |
K900 | It will make things even more incorrect and it's not even fixing everything | 10:25:50 |
emily | yeah, but it's worked okay since 2008 and we can un-paper-over them as soon as 25.05 is a thing. | 10:26:06 |
emily | hm, but I guess Steam was broken? | 10:26:36 |
emily | oh, not quite. | 10:26:56 |
Alyssa Ross | plot twist: cage doesn't build with pkg-configUpstream | 10:27:37 |
emily | is it a wrapped pkg-configUpstream ? | 10:28:00 |