!UNVBThoJtlIiVwiDjU:nixos.org

Staging

188 Members
Staging merges | Running staging cycles: https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+is%3Aopen+head%3Astaging-next+head%3Astaging-next-24.05 | Review Reports: https://malob.github.io/nix-review-tools-reports/70 Servers

Load older messages


SenderMessageTime
17 Oct 2024
@qyliss:fairydust.spaceAlyssa RossTIL we have a pkg-configUpstream package10:18:40
@qyliss:fairydust.spaceAlyssa Rosswhich is not used anywhere10:18:47
@emilazy:matrix.orgemilyyeah there's some "vanilla" flag10:18:52
@emilazy:matrix.orgemilywhich I guess disables our broken patches10:18:56
@qyliss:fairydust.spaceAlyssa Rosswhich does nothing but remove this patch10:19:01
@qyliss:fairydust.spaceAlyssa Rossso… do we think cage builds with pkg-configUpstream10:19:22
@emilazy:matrix.orgemily I promise I'll switch us to pkgconf for the next release… 🫠 10:19:24
@emilazy:matrix.orgemilyI like how we have a Cygwin-only patch that does patching to its vendored copy of glib.10:20:14
@emilazy:matrix.orgemilyreally awesome things going on in this derivation10:20:21
@hexa:lossy.networkhexa
In reply to @emilazy:matrix.org
https://github.com/NixOS/nixpkgs/pull/2798 wow, we didn't even have staging qua staging back then?
https://github.com/NixOS/rfcs/blob/master/rfcs/0026-staging-workflow.md
10:20:24
@emilazy:matrix.orgemily that PR seemed like it was before staging entirely. so I guess in ~2014 we got staging and then in 2018 we got staging-next? 10:21:22
@vcunat:matrix.orgvcunatI'd prefer not to change pkg-config propagation semantics this close to forking stable.10:21:30
@qyliss:fairydust.spaceAlyssa Ross

Then I think we should probably revert K900's thing

10:21:52
@emilazy:matrix.orgemilywe did just rewrite the entirety of Darwin support, don't Linux people deserve a bit of fun and excitement too?10:22:06
@emilazy:matrix.orgemily maybe we could just give cage the vanilla package for now 10:22:26
@qyliss:fairydust.spaceAlyssa RossI'm worried about other fallout10:22:55
@emilazy:matrix.orgemilywhat was the K900 change that caused this specifically? I missed that part10:23:14
@vcunat:matrix.orgvcunatThis? https://github.com/NixOS/nixpkgs/pull/34848310:23:33
@qyliss:fairydust.spaceAlyssa Rosshttps://github.com/NixOS/nixpkgs/pull/34848310:23:34
@emilazy:matrix.orgemilyah, yes10:24:22
@emilazy:matrix.orgemily I guess if we're going to change pkg-config semantics it makes sense to just do it when we switch to pkgconf, if everything is working fine except for this patch. 10:25:19
@k900:0upti.meK900I disagree tbh10:25:21
@emilazy:matrix.orgemilyit's adding back a hack to avoid removing another hack10:25:32
@k900:0upti.meK900Reverting that would just paper over a few things10:25:36
@k900:0upti.meK900 It will make things even more incorrect and it's not even fixing everything 10:25:50
@emilazy:matrix.orgemilyyeah, but it's worked okay since 2008 and we can un-paper-over them as soon as 25.05 is a thing.10:26:06
@emilazy:matrix.orgemilyhm, but I guess Steam was broken?10:26:36
@emilazy:matrix.orgemilyoh, not quite.10:26:56
@qyliss:fairydust.spaceAlyssa Rossplot twist: cage doesn't build with pkg-configUpstream10:27:37
@emilazy:matrix.orgemily is it a wrapped pkg-configUpstream? 10:28:00

Show newer messages


Back to Room ListRoom Version: 6