| 17 Oct 2024 |
 emily | looks hard to find anything in that gigantic commit | 06:49:25 |
| emily | though I guess a lot of it is just changing indentation(?) | 06:49:42 |
| emily | In reply to @qyliss:fairydust.space
it was part of a huge PR tbf ah, I see, it's just a "rewrite everything" PR | 06:50:00 |
| emily | I agree with revert | 06:50:28 |
| emily | seems more likely to be an OpenEXR regression than something wrong with libjxl | 06:50:39 |
|  Mic92 changed their display name from Mic92 to Mic3000. | 06:51:17 |
| Mic92 changed their display name from Mic3000 to Mic3000 🌋. | 06:51:46 |
 Alyssa Ross | https://github.com/NixOS/nixpkgs/pull/349220 | 06:54:28 |
| emily | LGTM. can't practically test the build on Darwin since progress is so slow but since it's a revert it should be fine | 06:58:59 |
| emily | speaking of which, openldap seems to be consistently failing on at least x86_64-darwin :( | 06:59:26 |
| emily | not sure if it's just flakier than usual | 06:59:30 |
 oliver.falvai | My local aarch64-darwin build is past openldap and it built successfully | 07:46:34 |
| oliver.falvai | Although procps failed for me:
> build flags: -j14 SHELL=/nix/store/rj7zvmif800bgg3sbznq6g5g438jx104-bash-5.2p37/bin/bash usrbin_execdir=\$\(out\)/bin watch PKG_…
┃ > make: *** No rule to make target 'watch'. Stop.
┃ For full logs, run 'nix-store -l /nix/store/cgqdf0aw3zy2cdrm55z5ygzy6c8dj0mw-procps-4.0.4.drv'.
| 07:58:28 |
| emily | 🤔 | 07:59:50 |
| oliver.falvai | Maybe this? https://github.com/NixOS/nixpkgs/pull/298505 | 08:10:47 |
| emily | ++ lib.optionals watchOnly [ "watch" "PKG_LDFLAGS=" ];
| 08:24:06 |
| emily | one suspects that this code path (used only for Darwin IIRC) was not tested | 08:24:15 |
| emily | I glanced a little at their build system and it should just be a matter of finding a different target or maybe overriding their programs variable | 08:40:47 |
| emily | but I don't know enough automake to guess the correct incantation off the top of my head and don't feel like debugging the derivation right now | 08:41:00 |
| oliver.falvai | Same, same. I might play with it a bit later | 08:44:27 |
 trofi | As it's a non-recursive Makefile.am src/watch is worth a try. | 09:15:41 |
| trofi | How about this: https://github.com/NixOS/nixpkgs/pull/349244 | 09:35:20 |
| emily | do you know what's going on with the PKG_LDFLAGS thing? | 09:44:49 |
| emily | LGTM otherwise | 09:44:51 |
| trofi | Don't know. Seemingly neither procps-3 nor procps-4 seem to use it (but I might have grepped it wrong). | 09:50:11 |
| emily | I assumed it was some automagic autotools thing | 09:54:45 |
| trofi | Was present in non-ng: https://github.com/NixOS/nixpkgs/commit/7a59054dce4ab1193b870d3dbe9f3868f1208a71. Dropped the var in the PR as well. | 09:54:47 |
| emily | SGTM :) although after reading the Makefile.am, I was wondering if we could maybe get away with bin_PROGRAMS=src/watch and reuse upstream's install phase rather than writing our own? | 09:55:59 |
| emily | though I guess since that's pre-automake it may not work for whatever reason | 09:56:15 |
| emily | I'll check the build on Darwin | 09:56:41 |
