16 Oct 2024 |
Alyssa Ross | I don't think I'll have time to do any more to my debug info PR | 16:56:22 |
K900 | I can just enable it for everything | 16:56:31 |
K900 | At qtModule level | 16:56:35 |
Alyssa Ross | but I think it should be merged anyway, because qtbase is distinct from everything else, since it doesn't use qtModule | 16:56:40 |
Alyssa Ross | so qtbase having debug info is pretty orthogonal from the rest of qt having debug info | 16:56:52 |
K900 | Yes but your PR is for staging and I'll want it in -next | 16:56:59 |
K900 | Anyway I'll figure it out | 16:57:06 |
K900 | If you're OK with me taking over on this | 16:59:03 |
Alyssa Ross | You can just merge my PR into staging | 16:59:22 |
Alyssa Ross | * | 16:59:31 |
Alyssa Ross | but yes absolutely please take over | 16:59:39 |
K900 | I don't know if I can without rebasing it | 17:00:29 |
K900 | But OK | 17:00:32 |
K900 | I'll figure it out | 17:00:35 |
K900 | But I'll start figuring it out once the fix lands upstream or we're starting to get close to the builds | 17:01:27 |
K900 | Because I don't want to yoink WIP patches from Gerrit if we can avoid it | 17:01:51 |
K900 | And also because there might be a Plasma 6.2.1.1 today with another pretty big fix | 17:02:12 |
K900 | And I'll need to take care of that | 17:02:21 |
Alyssa Ross | My PRs can always be retargeted without rebasing, unless they depend on something in the target branch :) | 17:02:56 |
K900 | That's context that I can't fit into my head and also aaaaaa Gerrit aaaaaaaaaaaaa | 17:05:09 |
| * K900 screams, runs away into the sunset | 17:05:15 |
Alyssa Ross | K900pixman is only listed in Requires.private for wlroots
| 17:22:41 |
Alyssa Ross | but <wlr/types/wlr_output.h> includes <pixman.h> | 17:22:54 |
Alyssa Ross | and also a bunch of other headers | 17:24:02 |
Alyssa Ross | so I guess I add pixman to Requires? | 17:25:39 |
Alyssa Ross | Redacted or Malformed Event | 17:25:42 |
Alyssa Ross | except I'm not sure it's mandatory? | 17:26:42 |
Alyssa Ross | okay no looks like it is | 17:27:54 |
Alyssa Ross | cool | 17:27:58 |
K900 | Woo | 17:28:44 |