| 15 Mar 2026 |
 dramforever | or maybe they just messed it up | 06:37:20 |
 emily | I think they might mean "pad it out" | 06:46:06 |
| emily | but it's definitely baffling with a flexible array | 06:46:13 |
| emily | maybe you can git blame it. how long can that take on the Chromium repo | 06:46:55 |
| dramforever | the answer is "seconds" btw | 06:56:10 |
| dramforever | there's a "Blame" button | 06:56:14 |
| dramforever | which leads to https://codereview.chromium.org/2490303002/patch/260001/270006 | 06:56:17 |
| dramforever | still no idea what "alignment" means, but it looks like
- chromium intends to at least use
[1] for FAM
- they don't enforce it
| 06:57:29 |
| dramforever | ugh i don't want to figure out how to report chromium bug | 06:58:03 |
| emily |
It's definitely a benefit
| 07:03:42 |
| emily |
base/metrics/persistent_histogram_allocator.cc:247: char name[sizeof(uint64_t)];
Please add a comment about this, so it's clear why it's like this.
| 07:04:13 |
| emily |
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 02:17:58 UTC) #80
CQ is trying da patch.
| 07:05:10 |
| emily | anyone remember four years ago (2016) | 07:05:20 |
| dramforever |
Chromium Code Reviews has been turned down in favor of Chromium Gerrit. This page was archived in December 2020.
| 07:06:30 |
| dramforever | "turned down" | 07:06:33 |
 eveeifyeve | I am not proud of causing 22k rebuilds in nixpkgs... just for one hook change. | 11:41:21 |
| eveeifyeve | * I am not proud of causing 22k rebuilds in nixpkgs... just for one hook change aka installFonts. | 11:42:07 |
| eveeifyeve | https://github.com/NixOS/nixpkgs/pull/500040 | 11:46:26 |
| eveeifyeve | * how well it sometimes what you have got to do https://github.com/NixOS/nixpkgs/pull/500040 | 11:46:43 |
