!UNVBThoJtlIiVwiDjU:nixos.org

Staging

356 Members
Staging merges | Running staging cycles: https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+is%3Aopen+head%3Astaging-next+head%3Astaging-next-25.11 | Review Reports: https://malob.github.io/nix-review-tools-reports/116 Servers

Load older messages


SenderMessageTime
13 Mar 2026
@rvdp:infosec.exchangeRamses 🇵🇸 There is a commit on -next that goes go_1_24 -> go because 1.24 is EOL, and another on master that does 1_24 -> 1_26 11:47:49
@emilazy:matrix.orgemilyprophylactic pins are not a great idea absent strong reason IMO11:58:37
@emilazy:matrix.orgemilyif we had to bump something because the old version was going EOL and the new one works fine then that's a sign we're failing to keep up and will have less churn if we only pin if something breaks11:59:25
@rvdp:infosec.exchangeRamses 🇵🇸Yeah, but I think that's a question for the maintainers of that package, right? I didn't want to remove a pin behind their back because I'm not familiar with the package11:59:29
@emilazy:matrix.orgemilypinging them is a good idea for sure. but well, if a staging contributor has had to fix it then they get a say too IMO12:00:38
@emilazy:matrix.orgemilyin return for the thankless task that I'd triaging these kinds of issues and stepping in for maintainers a lot12:01:12
@emilazy:matrix.orgemilyanyway no super strong feelings. I just greatly prefer having only the minimum reactive version pinning12:01:52
@rvdp:infosec.exchangeRamses 🇵🇸I don't disagree. I just wanted to fix the conflict and opted for what I felt was the conservative approach of sticking to what seemed to have been the common practice for this package (I checked quite a bit of the git history to check this). I worried that otherwise I got an annoyed maintainer later on asking why I unpinned their input.12:03:02
@emilazy:matrix.orgemilyespecially when it's about EOLs. you can have upstreams that stay reasonably in sync with their dependencies' cycles but need manual work for each bump. but less so for supporting only the oldest supported version and still updating in a timely fashion12:03:12
@rvdp:infosec.exchangeRamses 🇵🇸Seems like the kind of situation where you end up annoying someone in any case12:03:16
@emilazy:matrix.orgemilyyeah I don't think you did anything wrong :)12:03:43
@rvdp:infosec.exchangeRamses 🇵🇸I fully agree that we should avoid pinning, but a merge commit in -next without a PR to give the maintainers a chance to weigh in, didn't seem like the right place to fix that12:05:15
@emilazy:matrix.orgemilyprocedurally I err very much in favour of stuff landing on staging, because the workload is high and the contributors are deeply knowledgeable on average and being a time-sensitive maintainer of last resort is no fun if it also lacks the authority to make judgement calls12:05:24
@emilazy:matrix.orgemilybut we're violently agreeing I think 😆12:05:46
@emilazy:matrix.orgemilyIMO it was the -next commit that made that call rather than the merge. but those aren't great for visibility for maintainers especially if they're pushed directly, yeah12:06:37
@emilazy:matrix.orgemily(thank you for doing the merge!)12:06:45
@emilazy:matrix.orgemilywe really need to move to a PR-only workflow for staging, including for merges. I'll hopefully write up plans for that soon...12:07:23
@emilazy:matrix.orgemilyvisibility and auditing is pretty awful right now12:07:35
@rvdp:infosec.exchangeRamses 🇵🇸Yeah, but the merge needs to arbitrage between the two (fix on -next, regular bump on master)12:07:40
@rvdp:infosec.exchangeRamses 🇵🇸I noticed a prior issue from you about that, while searching for docs on how to do this merge12:08:12
@rvdp:infosec.exchangeRamses 🇵🇸That would make things a lot more transparent (but potentially also a bit more laborious)12:08:39
@rvdp:infosec.exchangeRamses 🇵🇸I wasn't totally sure whether we were, so good to know! 😁12:09:26
@emilazy:matrix.orgemilyyeah, making the workflow not painful is the main consideration. I think having a pre-made ref you can push to would help offset that12:11:29
@emilazy:matrix.orgemilyas well as specifically avoiding mass rebuilds and eval issues percolating to -next which sucks12:11:55
@emilazy:matrix.orgemilyI've thought more lately about how we can avoid conflicts arising in the first place though12:12:07
@emilazy:matrix.orgemilythe ideal would be that we don't get two PRs that don't know about each other both landing in different "timelines" at all12:12:38
@emilazy:matrix.orgemilymultiple merge queues kind of dampen the benefit of having them12:13:52
@rvdp:infosec.exchangeRamses 🇵🇸Yeah, AFAICT, the commit to switch kitty to a non-EOL go could've gone to master, which would've avoided this conflict and discussion. But maybe there were other reasons why it didn't, I don't have the context14:20:46
@rvdp:infosec.exchangeRamses 🇵🇸But in general indeed it's hard to know when you make a PR to master, that there are any conflicting changes on staging(-next). And even if we detected this in CI, I don't think it's always possible to modify the changes such that they cleanly apply on both branches14:22:24
@emilazy:matrix.orgemilywell, I had some ideas for making it so that they always can :) but which ones are practical, not sure15:52:03

Show newer messages


Back to Room ListRoom Version: 6