!UNVBThoJtlIiVwiDjU:nixos.org

Staging

359 Members
Staging merges | Running staging cycles: https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+is%3Aopen+head%3Astaging-next+head%3Astaging-next-25.11 | Review Reports: https://malob.github.io/nix-review-tools-reports/116 Servers

Load older messages


SenderMessageTime
15 Mar 2026
@dramforever:matrix.orgdramforevergood point06:11:36
@vcunat:matrix.orgVladimír Čunát For strictflexarrays1 which is the default now. 06:11:48
@vcunat:matrix.orgVladimír Čunát And [1] is surely fine without any C++ extensions. 06:12:12
@dramforever:matrix.orgdramforeverthat is a good point but i don't want to audit the entire chromium source code to see if that 8 really was the only place it explodes06:12:15
@dramforever:matrix.orgdramforever * that is a good point but i don't want to audit the entire chromium source code to see if that single char[sizeof(uint64_t)] really was the only place it explodes 06:12:30
@dramforever:matrix.orgdramforeverbecause the symptom is "oops spurious out of bounds, guess i'm gonna die" when it's used06:12:53
@vcunat:matrix.orgVladimír Čunát Yes, It would be nice to have evidence that strictflexarrays1 already is used in some larger distro-like setup. 06:13:20
@emilazy:matrix.orgemily I mean we can just hardeningDisable Chromium 06:16:38
@emilazy:matrix.orgemily so -fstrict-flex-arrays=1 allows [] but also [0] and [1] 06:18:45
@emilazy:matrix.orgemilyit's just the alignment hack here that's messing it up06:18:50
@emilazy:matrix.orgemilyeh I guess I'm just repeating06:19:07
@dramforever:matrix.orgdramforeverfor now, but maybe there will be more breakages06:19:09
@dramforever:matrix.orgdramforeveryeah i think we agree now06:19:29
@emilazy:matrix.orgemilyit would be nice for chromium to not be doing wrong things though06:19:52
@dramforever:matrix.orgdramforeverwithout relying on gnu extensions it gets ugly06:21:20
@dramforever:matrix.orgdramforeverdon't know if they want to06:21:31
@dramforever:matrix.orgdramforever * don't know if they want to just use char name[]; in c++ 06:21:51
@dramforever:matrix.orgdramforeverif i worked faster i could have made that pr #50000006:24:50
@vcunat:matrix.orgVladimír ČunátI honestly don't get why length of char array should affect alignment. (though I only have significant experience with pure C)06:28:19
@dramforever:matrix.orgdramforeveri think it's less alignment and more padding up the size of the struct?06:28:41
@vcunat:matrix.orgVladimír ČunátYes, that's what I mean.06:28:55
@dramforever:matrix.orgdramforeverwhich, to be clear, is a weird thing to do for a struct with flexible array struct06:29:02
@vcunat:matrix.orgVladimír ČunátIt's a char array, and chars have alignment of 1 only.06:29:11
@dramforever:matrix.orgdramforever but if you just change it to name[] it trips a static assert somewhere else 06:29:19
@vcunat:matrix.orgVladimír Čunát You'd do uint64_t name[1]; to get an aligned piece. 06:30:32
@vcunat:matrix.orgVladimír Čunát(but that has aliasing issues)06:30:52
@vcunat:matrix.orgVladimír Čunát* (but that has aliasing issues in some usage patterns)06:31:10
@dramforever:matrix.orgdramforever uint64_t nothing[0]; char name[]? 06:31:18
@vcunat:matrix.orgVladimír Čunát* (but that has type-aliasing issues in some usage patterns)06:31:20
@dramforever:matrix.orgdramforeveror is that not allowed06:31:26

Show newer messages


Back to Room ListRoom Version: 6