!UNVBThoJtlIiVwiDjU:nixos.org

Staging

320 Members
Staging merges | Running staging cycles: https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+is%3Aopen+head%3Astaging-next+head%3Astaging-next-25.05 | Review Reports: https://malob.github.io/nix-review-tools-reports/110 Servers

Load older messages


SenderMessageTime
11 Nov 2025
@elvishjerricco:matrix.orgElvishJerriccoprobably not but I'm afraid to change it :P11:25:08
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)like, that wrapper does nothing? i think?11:25:29
@elvishjerricco:matrix.orgElvishJerriccoyea wtf11:25:44
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all) it removes pkgs, thats about it 11:25:52
@elvishjerricco:matrix.orgElvishJerriccoI mean11:26:09
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)it inherits name and paths, it explicitly does extra outputs11:26:11
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)so why do we need that at all11:26:24
@elvishjerricco:matrix.orgElvishJerricco technically, the args given to this buildEnv' are more powerful, because they become derivation attrs, not args to buildEnv 11:26:26
@elvishjerricco:matrix.orgElvishJerriccoso that's technically a difference11:26:30
@elvishjerricco:matrix.orgElvishJerriccobut I don't know if that's actually used?11:26:40
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)HUH11:26:49
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)okay that is actually fair, hold on let me check11:27:02
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all) oh yeah there is stuff like postBuild, meta, outputs and passthru and a whole mess of other things:
https://github.com/NixOS/nixpkgs/blob/addd85b5d06ea90d5a7923956a65baf96bcd1e9f/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix#L414-L480
11:28:08
@elvishjerricco:matrix.orgElvishJerriccook, so unless anyone wants to go sifting through all those instances and finding a better way to do them, we should just keep the override11:28:45
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)

# no indent for git diff purposes

treewide nixfmt says hello

11:28:54
@elvishjerricco:matrix.orgElvishJerriccoso the thing vcunat and I did is probably the best thing to do for now11:28:58
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)i mean there is only 3 instances11:30:08
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)its in a let...in block and not reexported11:30:23
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)but yeah, do the workaround11:30:54
@elvishjerricco:matrix.orgElvishJerricco yea I mean it looks like we'd just end up doing the overrideAttrs in those 3 sites instead, so there's no real benefit to trying to get rid of it 11:31:29
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)or alternatively hand-roll a pseudo-buildenv using stdenv.mkDerivation that has the power to do these things11:32:22
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)not sure either is better11:32:42
@elvishjerricco:matrix.orgElvishJerriccothat seems like more code / effort for no benefit11:33:42
@elvishjerricco:matrix.orgElvishJerricco vcunat: you want to author the commit / PR or do you want me to? 11:35:02
@vcunat:matrix.orgVladimír ČunátI don't care really.11:35:24
@vcunat:matrix.orgVladimír ČunátBut I'm relatively busy today.11:35:30
@vcunat:matrix.orgVladimír Čunát(with work stuff)11:35:36
@vcunat:matrix.orgVladimír ČunátSo either way I won't have capacity for longer discussion about the changes.11:36:53
@elvishjerricco:matrix.orgElvishJerriccohttps://github.com/NixOS/nixpkgs/pull/46063911:39:43
@winston:winston.shwinstonI was looking into the arrow-cpp test failure on darwin, strangely the binary of the tests that fail end up with two versions of protobuf in the dynamic linker paths v31, which is what we want in the derivation, v33 coming from somewhere else whats stranger is that master also shows v32, but it doesn't have the same runtime error I compiled it with -fsanitize=address and that pointed me into this direction: https://github.com/protocolbuffers/protobuf/issues/5290 https://gist.github.com/nekowinston/f6cbea976ba4605f318b9329d96a054411:52:38

Show newer messages


Back to Room ListRoom Version: 6