| 19 Oct 2025 |
dramforever | but anyway if my theory is correct then this is a real 258 regression and could be reproducible on fedora rawhide or something | 19:35:35 |
ElvishJerricco | /run/udev/static_node-tags/ is supposed to be populated with symlinks indicating the tags that have been applied to static dev nodes | 19:36:32 |
ElvishJerricco | so, like, /dev/snd/timer has the tag, in theory | 19:37:03 |
ElvishJerricco | (the above past was back on 258, to be clear) | 19:37:14 |
ElvishJerricco | * (the above paste was back on 258, to be clear) | 19:37:19 |
ElvishJerricco | dramforever: tell me if this makes sense... In 257, logind was seeing that static_node-tags link thing and doing the ACLs for uaccess, even on these static dev-nodes for not-yet-loaded modules. In 258, such nodes aren't processed by udev; so the change that made it so udev is the one to apply the ACLs doesn't work for them. | 19:40:22 |
dramforever | i think it's possible, but i have no idea how it works under the hood | 19:41:13 |
ElvishJerricco | yea, I'm gonna go look at how logind did the acl stuff in 257 | 19:41:51 |
ElvishJerricco | this sounds like a plausible explanation | 19:42:02 |
ElvishJerricco | yea, that's exactly what logind does in 257; it iterates over the /run/udev/static_node-tags/uaccess directory | 19:44:53 |
ElvishJerricco | and yea, of course the code that did that is deleted in 258 | 19:45:50 |
ElvishJerricco | oh, not deleted; moved | 19:50:07 |
ElvishJerricco | * oh, not deleted; moved | 19:50:45 |
ElvishJerricco | nope, deleted | 19:50:47 |
ElvishJerricco | I think the bug report here is basically: "uaccess no longer works with OPTIONS+="static_node=..."" | 19:52:14 |
ElvishJerricco | and the body can say "y'all deleted the code that used to do that" :P | 19:52:51 |
dramforever | do you have any idea if we can work around this better than "just ignore the test for now"? | 19:54:24 |
ElvishJerricco | looks like this bug report is the same problem: https://github.com/systemd/systemd/issues/39043
and is fixed by: https://github.com/systemd/systemd/pull/39071
Haven't looked at that code yet to make sure it would actually help us | 19:54:54 |
ElvishJerricco | anyway we can workaround it by checking an actual dev node, not a static dev node, in this test | 19:55:12 |
dramforever | but the bug is still there... | 19:56:02 |
ElvishJerricco | lol the PR just adds ACL code back to logind | 19:56:07 |
dramforever | do we just ignore that fact | 19:56:12 |
ElvishJerricco | what do you mean? | 19:56:35 |
ElvishJerricco | I think that fixes the bug? | 19:56:38 |
ElvishJerricco | it's just not in 258 | 19:56:44 |
ElvishJerricco | it's in 258.1 | 19:56:49 |
dramforever | yeah but that rebuilds systemd right | 19:56:49 |
ElvishJerricco | right, we can't do the patch this cycle | 19:56:59 |
ElvishJerricco | so we'll do a workaround | 19:57:04 |
dramforever | so if we merge staging-next we ship this bug to users | 19:57:11 |