| 12 Oct 2025 |
 matthewcroughan | IDK how people feel about the systemd vendoring of patches though, so might like someone else to review that first | 21:45:11 |
 emily | fwiw you can add .patch at the end of a PR URL to get the patch series in a single file | 22:13:28 |
| emily | but I don't think it matters either way so I'd go with Yureka (she/her)'s preference | 22:13:48 |
| emily | (as in, it could be vendored as one file) | 22:14:24 |
 Yureka (she/her) | alyssa has specifically asked me not to do that in the past, when the branch the commits are on isn't permanent | 22:14:28 |
| emily | right I didn't mean fetchpatch | 22:14:43 |
| Yureka (she/her) | Oh, I found it much more readable like this compared to one long file | 22:14:44 |
| Yureka (she/her) | I can also locally do git diff A...B | 22:14:59 |
| Yureka (she/her) | and pipe that to a file | 22:15:03 |
| emily | the .patch preserves the commit attribution and messages which is nice, but I'm fine with a bunch of files too | 22:15:17 |
| emily | just figured a single file may be easier to update if it gets force-pushed again etc. | 22:15:23 |
| Yureka (she/her) | or concat the .patch files together afaik? | 22:15:26 |
| emily | yeah I mean https://github.com/systemd/systemd/pull/37788.patch just does the concatenation for you :) | 22:15:44 |
| emily | I think it's fine as-is though, just mentioned it since ^ | 22:15:55 |
| Yureka (she/her) | I explicitly mentioned the vendoring of the patches in the PR, because vendoring them at all (no matter if in one file or several) might be controversial. When the openembedded systemd musl patchset was originally adopted in nixpkgs, being able to fetch the patchset from an existing source was considered a significant advantage. | 22:20:18 |
| Yureka (she/her) | * | 22:20:24 |
| emily | it's like 225 KiB, it's totally fine imo | 22:21:07 |
| emily | I'll just hit merge | 22:21:09 |
| emily | it will be very nice if the upstream stuff lands | 22:21:59 |
| emily | fwiw, rebased https://github.com/NixOS/nixpkgs/pull/451386 and confirmed builds on Linux | 22:22:54 |
| matthewcroughan | It'd be really nice to make a default nixos config build with musl for 25.11 | 23:41:51 |
| matthewcroughan | like, the default pkgs.nixos {} | 23:42:47 |
| 13 Oct 2025 |
| matthewcroughan | Maybe you could merge https://github.com/NixOS/nixpkgs/pull/446139 if you agree with it emily ? | 03:19:33 |
| matthewcroughan | Yureka (she/her):
[ 0.178535] systemd[1]: Failed to initialize kmod context: Not supported
[ 0.237062] (journald)[74]: systemd-journald.service: Failed to adjust OOM setting: Invalid argument
[ 0.237608] (journald)[74]: systemd-journald.service: systemd-journald.service: Failed at step OOM_ADJUST spawning /nix/store/prp9d98025pg2y4cs7kz49nz8zjkw25p-systemd-aarch64-unknown-linux-musl-258/lib/systemd/systemd-journald: Invalid argument
[ 0.239230] systemd[1]: Failed to start Journal Service.
[ 0.241111] systemd[1]: Failed to start Load Kernel Modules.
| 14:47:11 |
| matthewcroughan | Looks like musl systemd 258 comes with this cool new journal error | 14:47:19 |
| matthewcroughan | 257 only had the kmod context error | 14:56:02 |
| emily | vcunat: do you intend to revert https://github.com/NixOS/nixpkgs/pull/451386/commits/f0166da268940ec4a78504a83a15b61871eb1552 on staging? | 16:18:53 |
| emily | sorry for not being clearer about the rebuild counts being summed vs. per-platform :) | 16:19:25 |
| emily | oh, you pushed the revert directly to staging | 16:19:37 |
| emily | I was looking for a PR | 16:19:39 |
