| 12 Oct 2025 |
 emily | can be useful, OTOH is in tension with moving variant package sets to variants.nix which we'd generally like to do. | 17:13:44 |
| emily | it depends a bit on just how "expected" it is I think | 17:14:09 |
| emily | like "would people be okay with an update being held back just because it regresses pkgsStatic for that package" | 17:14:27 |
| emily | if it's part of a channel blocker then certainly | 17:14:33 |
 matthewcroughan | I don't want things to be held back, but it would be nice if as much as possible was cached, and that status could be checked | 17:14:51 |
 Ihar Hrachyshka | aren't passthru.tests already kinda advisory? (I don't think we gate on them and I don't see a lot of nixpkgs-reviews ran with -p passthru.tests ) | 17:15:25 |
| matthewcroughan | K900: Can I merge https://github.com/NixOS/nixpkgs/pull/451338 when ready? It's what I intended now that it's musl conditional | 17:18:40 |
| emily | caching is unlikely to happen | 17:18:57 |
| emily | I think if passthru.tests.X fails you're meant to be worried, at least. | 17:19:12 |
| matthewcroughan | I mean I've been doing an okay job warming up my own caches by doing as many builds as possible, at all times | 17:19:23 |
| emily | as in, you would usually add something to passthru.tests if it failing would be a reason for you to at least consider blocking the PR. | 17:19:29 |
| matthewcroughan | nix build .#checks.aarch64-linux.{base,musl,musl-llvm,gnu-musl} --keep-going for example | 17:19:37 |
| matthewcroughan | in my flake | 17:19:39 |
| matthewcroughan | so I'll let those build on a bunch of builders 24/7 as I make changes to files.. and it's better than if I hadn't attempted the builds at all | 17:19:54 |
| matthewcroughan | since at least then the base toolchains and stuff are cached | 17:20:43 |
| matthewcroughan | I spent a few hours to build https://github.com/NixOS/nixpkgs/pull/451274 | 19:58:11 |
| matthewcroughan | only thing blocking my little tracking flake, so I'm going to merge it? | 19:58:19 |
| matthewcroughan | and it's conditional on musl, so no mass rebuilds | 19:58:27 |
| matthewcroughan | I don't know if I understand nixpkgs-review though, why does it say it only built the nixpkgs-manual | 19:59:02 |
 Lun | It only diffs things marked recurseForDerivations, pkgsMusl isn't and nothing that is depends on pkgsMusl.systemd. | 20:01:16 |
| matthewcroughan | Yeah I just wanted to use it for concrete testing that merging doesn't break anything by accident, which is obvious based on the diff, but I just do it anyway to check | 20:01:58 |
| Lun | You can -p pkgsMusl.systemd (repeatable arg) to nixpkgs-review to get it to test attrs that the eval compare doesn't find | 20:02:59 |
| matthewcroughan | Ah nice, I was looking for how to tell nixpkgs-review to do it anyway | 20:03:28 |
