!UNVBThoJtlIiVwiDjU:nixos.org

Staging

320 Members
Staging merges | Find currently open staging-next PRs: https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+sort%3Aupdated-desc+head%3Astaging-next+head%3Astaging-next-21.05+is%3Aopen109 Servers

Load older messages


SenderMessageTime
12 Oct 2025
@emilazy:matrix.orgemilyit means the conflicts can be resolved per-PR15:56:03
@emilazy:matrix.orgemilyrather than all at once15:56:08
@emilazy:matrix.orgemilyI don't understand15:56:22
@emilazy:matrix.orgemilythat's exactly the case of periodic merges failing15:56:26
@emilazy:matrix.orgemilyit would be far more auditable and granular than those15:56:35
@k900:0upti.meK900 I'd much rather resolve the conflicts all at once than have random people make three different PRs and compare them against each other 15:56:58
@emilazy:matrix.orgemily this would eliminate the conflicts 15:57:17
@emilazy:matrix.orgemilythere would never be any15:57:21
@emilazy:matrix.orgemily like, exactly when someone would have to manually resolve/check the conflict on staging, the merge would say "this conflicts with staging – target staging instead", and if you need the PR to land in master sooner than that, you would then open a cherry-pick from staging back to master, resolving the conflict 15:57:57
@emilazy:matrix.orgemilywhich a committer could still do – but a contributor could also do, just like with backports to release branches15:58:08
@emilazy:matrix.orgemilyit ensures that every change is always targeting the "latest state" whenever there would otherwise be conflicts15:58:23
@emilazy:matrix.orgemily and we never have "master does X, staging does Y, they are incompatible, we find out 6 hours later" 15:58:31
@wolfgangwalther:matrix.orgWolfgang WaltherThis doesn't solve the case of "A is merged into master, in the 6 hour window where A has not made its way to staging, B is merged into staging; A and B conflict".15:59:44
@wolfgangwalther:matrix.orgWolfgang WaltherSo it would not eliminate all of these cases, but probably reduce them a lot.15:59:57
@emilazy:matrix.orgemilywe can solve that too16:00:08
@emilazy:matrix.orgemily by changing the reverse in the merge queue for staging 16:00:15
@emilazy:matrix.orgemilylike… we can even just insert the merges just-in-time if necessary.16:00:28
@emilazy:matrix.orgemily(or just boot it out and tell someone to run the periodic job)16:00:43
@wolfgangwalther:matrix.orgWolfgang WaltherI see, yes that could work.16:00:43
@emilazy:matrix.orgemily(since they'd need to resolve the conflict manually anyway)16:00:47
@emilazy:matrix.orgemilyI think this would be simpler and more auditable than the "periodic merge via PR" flow16:01:07
@emilazy:matrix.orgemilywe could reuse the cherry-pick backport action16:01:12
@emilazy:matrix.orgemilyto point out the changes done16:01:17
@emilazy:matrix.orgemilywhich we'd need a separate version of otherwise, for the periodic merges via PR option16:01:25
@wolfgangwalther:matrix.orgWolfgang Waltheryeah, much smaller conflict diffs to look at, too.16:01:31
@emilazy:matrix.orgemilyand the granularity is nice, because it means that contributors responsible for causing the conflicts can also be asked to resolve them.16:01:45
@wolfgangwalther:matrix.orgWolfgang Waltherperiodic merge conflict diffs in a review comment cause me pain, because... it's likely they don't even fit.16:01:52
@emilazy:matrix.orgemilyand there's not a big urgency to resolving them, because it "just" means stuff landing sooner16:01:57
@emilazy:matrix.orgemily rather than blocking staging/staging-next 16:02:02
@wolfgangwalther:matrix.orgWolfgang Waltheryeah16:02:13

Show newer messages


Back to Room ListRoom Version: 6