!UNVBThoJtlIiVwiDjU:nixos.org

Staging

315 Members
Staging merges | Running staging cycles: https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+is%3Aopen+head%3Astaging-next+head%3Astaging-next-25.05 | Review Reports: https://malob.github.io/nix-review-tools-reports/108 Servers

Load older messages


SenderMessageTime
4 Oct 2025
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)there it goes, CI green :)15:07:54
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)now how the hell is anyone supposed to review this thing15:08:09
@lt1379:matrix.orgLunyeah it gave up "Too many reviewers skipping review requests"15:08:24
@dramforever:matrix.orgdramforeverit's not like anyone reviews the auto merges right15:09:13
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)yes, but the automerge bot is also more trusted than some "random" PR15:09:46
@lt1379:matrix.orgLunby trusting your diff of the conflict fix or by doing the merge locally and diffing the end result?15:10:01
@hexa:lossy.networkhexaat which point I could have done the merge myself 😄 15:10:33
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all) like, not that i am suggesting you'd be trying anything funny, but this would be a hard-to-spot place to inject some malicious blob. 15:11:09
@lt1379:matrix.orgLunin order to do the merge you must first do the merge15:11:12
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)yeah XD15:11:19
@hexa:lossy.networkhexathe compromise is obviously to make dramforever a committer15:11:54
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)Ah got it!15:12:33
@dramforever:matrix.orgdramforevermaybe i should have made it without the merge commit15:12:33
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all) git show HEAD will display the diff 15:12:41
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)and the diff is as advertised15:12:54
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)and the commits before were unchanged15:13:00
@dramforever:matrix.orgdramforeveroh, yeah15:13:09
@dramforever:matrix.orgdramforever if you have it locally you can check the --cc diff 15:13:19
@lt1379:matrix.orgLunI verified locally that the merge result matches except fixing the conflict15:13:29
@dramforever:matrix.orgdramforever (which is the default for git show on merge commits) 15:13:33
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)that too XD15:14:11
@dramforever:matrix.orgdramforeverwhy does github not have this feature15:14:20
@lt1379:matrix.orgLunwhy does github's UI not let you view that15:14:23
@dramforever:matrix.orgdramforeveri'm not going to do this next time15:15:09
@dramforever:matrix.orgdramforeverthis is awful15:15:17
@dramforever:matrix.orgdramforevernext time whoever feels like doing it should probably just open a pr from the branch directly and use this https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-on-github15:16:02
@dramforever:matrix.orgdramforeveractually we can still make it happen now15:16:38
@dramforever:matrix.orgdramforeverbut whatever15:17:04
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)anyways, its done15:17:07
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)tbh i had the merge reproduced locally, so before coordinating more people with this farce, just hitting the button was easier15:18:41

Show newer messages


Back to Room ListRoom Version: 6