!UNVBThoJtlIiVwiDjU:nixos.org

Staging

318 Members
Staging merges | Find currently open staging-next PRs: https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+sort%3Aupdated-desc+head%3Astaging-next+head%3Astaging-next-21.05+is%3Aopen109 Servers

Load older messages


SenderMessageTime
3 Oct 2025
@vcunat:matrix.orgVladimír Čunát🤷 let's wait which commit the blame falls on. Hopefully it will help.10:44:06
@vcunat:matrix.orgVladimír Čunát

So this one?

411faf46e2c8 gcc: build with --enable-default-pie configure option (#439314)
11:22:38
@vcunat:matrix.orgVladimír Čunát Reconfirmed breaking nix build -f pkgs/top-level/release.nix stdenvBootstrapTools.x86_64-unknown-linux-gnu.test on this commit and OK on its first parent (the staging branch lineage). 11:33:49
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)uh oh11:38:32
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)that is a fat mass-rebuild, so how will we fix it?11:39:09
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)
diff --git a/pkgs/stdenv/linux/make-bootstrap-tools.nix b/pkgs/stdenv/linux/make-bootstrap-tools.nix
index 6a1507df734d..c4b204e35837 100644
--- a/pkgs/stdenv/linux/make-bootstrap-tools.nix
+++ b/pkgs/stdenv/linux/make-bootstrap-tools.nix
@@ -50,6 +50,7 @@ rec {
   bootGCC = pkgs.gcc.cc.override {
     enableLTO = false;
     isl = null;
+    enableDefaultPie = false;
   };

   bootBinutils = pkgs.binutils.bintools.override {

Trying the naive thing rn

11:46:11
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)if this works, then we are done11:46:27
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)if this doesn't work, then emily will have to fix it XD11:47:05
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)HOLY SHIT THAT WORKS11:53:51
@k900:0upti.meK900Welp11:54:11
@k900:0upti.meK900Mes when11:54:20
@wolfgangwalther:matrix.orgWolfgang Waltherlucky emily, then.11:54:25
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)tbh i have no idea wtf i am doing, but if this works then i won't complain11:55:08
@vcunat:matrix.orgVladimír ČunátOff the top of my head I'm not sure how many times we roll gcc, i.e. whether the final build (stdenv.cc.cc) will really be PIE enough. But surely better this for now than blocking for long.11:56:59
@vcunat:matrix.orgVladimír Čunát * Off the top of my head I'm not sure how many times we roll gcc, i.e. whether the final build (stdenv.cc.cc) will really be PIE enough. But surely better this for now than blocking for long. 11:57:09
@k900:0upti.meK900This should not affect the non-bootstrap-tools GCC at least?11:57:39
@vcunat:matrix.orgVladimír Čunát It shouldn't affect anything practical until we regenerate the bootrap GCC, yes. 11:58:18
@vcunat:matrix.orgVladimír Čunát * It shouldn't affect anything practical until we regenerate the bootstrap GCC, yes. 11:58:31
@k900:0upti.meK900What I'm saying is I don't think we care about the PIE-ness of bootstrap-tools GCC?11:58:52
@vcunat:matrix.orgVladimír Čunát

It results in a compiler that opportunistically enables pie whenever it does not conflict with other flags.

11:59:49
@vcunat:matrix.orgVladimír Čunát i.e. it affects things compiled with this GCC. 11:59:59
@vcunat:matrix.orgVladimír ČunátSo that's why I was mentioning that I'm not sure how many times we roll things during bootstrapping. Some tools in the final package set are not built by the final GCC, of course.12:00:46
@vcunat:matrix.orgVladimír Čunát* So that's why I was mentioning that I'm not sure how many times we roll things during bootstrapping. Some stuff in the final package set are not built by the final GCC, of course.12:00:53
@k900:0upti.meK900Oof12:01:01
@k900:0upti.meK900OK12:01:02
@k900:0upti.meK900That makes things worse12:01:05
@k900:0upti.meK900But probably fine given our current bootstrap GCC is also like this?12:01:16
@vcunat:matrix.orgVladimír ČunátWe don't immediately use the new tools anyway.12:04:16
@vcunat:matrix.orgVladimír Čunát* We don't immediately use the new bootstrap tools anyway.12:04:40
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all) its also strictly better than a revert: Not as big of a rebuild, and at least some things get pie 12:05:10

Show newer messages


Back to Room ListRoom Version: 6