| 26 Sep 2025 |
 emily | and some forges don't have an option for it at all | 19:46:33 |
| emily | so unfortunately fetchpatch is usually the better option | 19:46:39 |
| emily | AIUI, they fixed this upstream, so we may be due for a fetchpatch3 that is strictly better than both | 19:46:51 |
| emily | but frankly… I am going to want a test suite | 19:46:59 |
| emily | since we have been bitten once already there | 19:47:10 |
| emily | btw did you know that patch can't handle the diffs that diff/git diff produce for filenames with spaces in them? :( | 19:50:08 |
| emily | and that Meson deliberately uses spaces in its source tree? | 19:50:23 |
 samasaur | okay I think I was doing this. is fetchpatch still better than fetchpatch2 with full_index=1? | 19:50:43 |
| emily | well, sometimes the patch is not on GitHub | 19:50:54 |
| emily | but they should be mostly equivalent I think, I forget if there are any other fetchpatch2 regressions | 19:51:03 |
| emily | the main advantage is: we should deprecate fetchpatch2 as soon as we have fetchpatch3 | 19:51:16 |
| emily | whereas fetchpatch will take a long time to migrate | 19:51:24 |
| emily | so every new user of fetchpatch2 makes it more likely we continue using 3 patch fetchers in the tree rather than 2 | 19:51:39 |
 ghpzin | Checked again and unfortunately I think it would only make patches situation worse, will see how PR looks like. | 19:51:55 |
| ghpzin | Checked again and unfortunately I think it would only make patches situation worse (because of mixing vendored and fetchpatch), will see how PR looks like. | 19:52:17 |
| ghpzin | Checked again and unfortunately I think it would only make patches situation worse (because of mixing vendored and fetchpatch patches on different versions).
Will see how PR looks like. | 19:52:35 |
