!UNVBThoJtlIiVwiDjU:nixos.org

Staging

315 Members
Staging merges | Running staging cycles: https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+is%3Aopen+head%3Astaging-next+head%3Astaging-next-25.05 | Review Reports: https://malob.github.io/nix-review-tools-reports/108 Servers

Load older messages


SenderMessageTime
23 Sep 2025
@vcunat:matrix.orgVladimír ČunátIf the auto-merge timing was different, it would resolve differently.12:53:21
@vcunat:matrix.orgVladimír ČunátOr "luckily" it wouldn't merge cleanly because of the fetcher rewrite.12:54:31
@wolfgangwalther:matrix.orgWolfgang Waltherexactly12:54:43
@vcunat:matrix.orgVladimír ČunátSo, when are we switching to pijul? 😆12:58:38
@fabianhjr:matrix.orgFabián HerediaHi, for cmake 4 I want to pull a patch from sourceforge but I can't seem to find an easy way to do that and seems like other maintainers have opted to inline / commit the patch into a file in nikpkgs. wsid? https://sourceforge.net/p/panotools/libpano13/ci/698e20b4d296c1dbde9d010c3fb8d54050e56ddb/15:03:10
@fabianhjr:matrix.orgFabián Heredia* Hi, for cmake 4 I want to pull a patch from sourceforge but I can't seem to find an easy way to do that and seems like other maintainers have opted to inline / commit the patch into a file in nikpkgs. What should I do? https://sourceforge.net/p/panotools/libpano13/ci/698e20b4d296c1dbde9d010c3fb8d54050e56ddb/15:03:21
@k900:0upti.meK900IMO just vendor it15:06:49
@k900:0upti.meK900It's three lines who gives a shit15:06:52
@vcunat:matrix.orgVladimír Čunát Or even substituteInPlace 😄 15:39:51
@emilazy:matrix.orgemily (I would be fine with substituteInPlace) 15:47:58
@lt1379:matrix.orgLundocker-tini has a merged CMake 4 patch, doesn't apply on top of the newest tagged release do I substitute or bump to an unreleased rev that has the fix?15:59:47
@emilazy:matrix.orgemilyhow old is the release?16:00:03
@lt1379:matrix.orgLundiff from last tag to HEAD https://github.com/krallin/tini/compare/v0.19.0...369448a167e8b3da4ca5bca0b3307500c337182816:00:16
@emilazy:matrix.orgemily5 years and benign fixes, including one that might avoid a warning disable flag or such? I'd bump yeah16:03:55
@lt1379:matrix.orgLunlixPackageSets.git is failing some toml tests with overflow errors do we just need to bump it past https://git.lix.systems/lix-project/lix/commit/4de09b6b5493db4bd7f6348255a1fdcb38b9ed2f ?16:06:31
@hexa:lossy.networkhexa cc aloisw 16:07:27
@aloisw:julia0815.dealoisw Current version has that toml11 4 patch reverted due to incompatibility with the toml11 3 in unstable (and 25.05). https://github.com/NixOS/nixpkgs/pull/444623 has a newer version of the patch that supports both toml11 versions. 16:08:42
@emilazy:matrix.orgemily we already have the toml11 bump in -next 16:09:52
@emilazy:matrix.orgemilyis there a reason not to drop the patch and just merge it into there?16:10:08
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all) https://github.com/NixOS/nixpkgs/pull/445081
i am wondering, if cmake is broken, is just not building with cmake a fix we would want? I am a bit worried, because things downstream may break if they expect the cmake files to be present
16:10:17
@lt1379:matrix.orgLunI can hit that with a review run and see if the deps get upset if you want16:11:12
@lt1379:matrix.orgLunseems likely to cause problems but it depends how dependents find it - they might already be shipping a FindX.cmake that works for this case or something16:11:45
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)thats what i would have done in the next step too, but i first wanted to check in whether the approach is even worth considering16:11:49
@aloisw:julia0815.dealoisw 25.05 basically, if you prefer I can also prepare a drop of the patch against staging-next. 16:11:52
@lt1379:matrix.orgLunsubstituting the cmake version seems preferable to me assuming it's workable and there isn't a whole bunch of cruft that broke and needs a proper patch in it16:12:36
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)there is also an upstream patch16:12:49
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)imo fetching that is the way16:12:59
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)Actually should be fine16:15:05
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)the cmake files aren't being installed anyways lol16:15:12
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)(checked against current unstable)16:15:26

Show newer messages


Back to Room ListRoom Version: 6