!UNVBThoJtlIiVwiDjU:nixos.org

Staging

317 Members
Staging merges | Find currently open staging-next PRs: https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+sort%3Aupdated-desc+head%3Astaging-next+head%3Astaging-next-21.05+is%3Aopen109 Servers

Load older messages


SenderMessageTime
23 Sep 2025
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)you could tag your PRs as "part of #445447", or just write comments08:57:21
@a-kenji:matrix.orgkenji changed their display name from a-kenji to kenji.10:38:04
@k900:0upti.meK900image.png
Download image.png
10:57:55
@k900:0upti.meK900Holy shit a major Qt release milestone is hit after only one reschedule10:58:06
@k900:0upti.meK900The temperature in hell has dropped by a few degrees10:58:15
@k900:0upti.meK900 @Wolfgang Walther https://github.com/NixOS/nixpkgs/pull/436110 is a mass rebuild now 12:11:24
@k900:0upti.meK900On nedxt12:11:53
@wolfgangwalther:matrix.orgWolfgang WaltherOK. Should I revert on master?12:12:21
@k900:0upti.meK900I think it's easiest to revert on master, run the merge train again, then unrevert on staging-not-next12:12:40
@k900:0upti.meK900The trains are running now12:27:12
@k900:0upti.meK900The trains are done12:27:37
@k900:0upti.meK900I think I'll just push a revert of revert12:27:47
@k900:0upti.meK900So we don't have to do another PR12:27:54
@wolfgangwalther:matrix.orgWolfgang WaltherOk, thanks.12:28:24
@k900:0upti.meK900Oh wait no12:28:43
@k900:0upti.meK900We have to do a PR12:28:47
@k900:0upti.meK900Because the fetcher changed12:28:50
@wolfgangwalther:matrix.orgWolfgang WaltherWill you or shall I?12:28:59
@k900:0upti.meK900If you have the time12:29:25
@k900:0upti.meK900I am still pretty sick and busy with $work12:29:36
@wolfgangwalther:matrix.orgWolfgang WaltherOk, I will look at it.12:29:51
@wolfgangwalther:matrix.orgWolfgang Walther Turns out this update is already on staging as https://github.com/NixOS/nixpkgs/commit/60eb2b5686aa3a4d7f9a8f11d7757d259be9f34e. So no need to re-apply. I can't really wrap my head around how the revert was able to propagate back to staging without breaking this (by reverting back the version number), but it seems everything is alright. 12:39:41
@wolfgangwalther:matrix.orgWolfgang Walther(it's even on staging-next, so I assume there was a conflict to resolve when merging master to staging-next earlier?)12:40:19
@wolfgangwalther:matrix.orgWolfgang WaltherWhich also means.. that I'm not sure whether the revert actually stopped the mass rebuild - or whether that was caused by resolving the merge conflicts?12:41:44
@vcunat:matrix.orgVladimír Čunát🤔 I think default merging will merge two same changes without conflict?12:41:52
@vcunat:matrix.orgVladimír Čunát(i.e. if both sides make the same change, it just passes)12:42:14
@vcunat:matrix.orgVladimír Čunát* (i.e. if both sides of the 3-way diff make the same change, it just passes)12:42:25
@vcunat:matrix.orgVladimír ČunátThough I believe there's not a 100% consensus whether that's a good thing to do.12:42:59
@wolfgangwalther:matrix.orgWolfgang Walther

Yeah, but:

  • staging changes to 1.14.0 -> 1.15.1, this is now in staging-next
  • master changes the same.
  • master is merged into staging-next, but now has a conflict in the fetcher.
  • this conflict is resolved when manually merging. (probably in a wrong way, if that caused a mass rebuild - the right conflict resolution should have just kept what was on staging-next!)
  • we revert on master.
  • the revert is merged cleanly into staging-next... the diff shows "1.15.1 -> 1.14.0".
  • But the file still has "1.15.1" in it.

How did the revert apply and show a diff - but not make a change?

12:44:38
@wolfgangwalther:matrix.orgWolfgang WaltherIt seems that the merges from master->staging-next->staging after the revert didn't actually apply the revert. At least the diff for these merges doesn't show any changes to that file.12:46:43

Show newer messages


Back to Room ListRoom Version: 6