| 22 Sep 2025 |
Grimmauld (any/all) | i spent the evening teaching a friend about fetchpatch and guided them through fixing three packages, its basically all just grunt work | 22:02:57 |
emily | we found the tests are broken in thrift | 22:03:13 |
emily | or that the fix bump breaks them | 22:03:16 |
emily | so that was fun | 22:03:16 |
nim65s | that was in https://github.com/NixOS/nixpkgs/pull/444660, but I removed thrift from there for now, as it was the only not-ready thing | 22:04:03 |
nim65s | oh, merge conflict | 22:04:34 |
Grimmauld (any/all) | oh oops, didn't see your PR because i was looking for individual packages | 22:06:01 |
Grimmauld (any/all) | (openscenegraph also has https://github.com/NixOS/nixpkgs/pull/445329, fetching the gentoo patches instead of a substitute - thats in that batch too, sorry. I was building towards freecad this evening, thats where i came accross some of those) | 22:06:51 |
nim65s | no worries, I expect we are doing the same thing everywhere all at once x) | 22:07:36 |
nim65s | let me yeet those 2 commits from there | 22:07:57 |
Grimmauld (any/all) | same for pystring (https://github.com/NixOS/nixpkgs/pull/445327), sorry | 22:08:09 |
Grimmauld (any/all) | am an idiot | 22:08:13 |
Grimmauld (any/all) | i mean you can do whatever, you technically were first | 22:09:26 |
nim65s | ok, yes, merge conflict is only in the merged one x) | 22:10:48 |
Grimmauld (any/all) | side note: i absolutely hate github PR search, i would have loved to get your PR displayed, but nooo GH needs to be dumb... | 22:11:20 |
Winter |
i absolutely hate github
ftfy
| 22:11:47 |
nim65s | ok for glew, I'll watch osg & pystring, and remove those if the other PR get merged first | 22:14:16 |
nim65s | maybe we could make some kind of todolist, like a pad or meta issue ? | 22:15:15 |
Grimmauld (any/all) | i'd prefer patch over substitute (osg), your pystring is basically the same (but cleans up the with) so that is where i would lean towards preferring yours | 22:15:31 |
Grimmauld (any/all) | but i will go sleep and if anyone merges yours first then so be it, you did it first and i should have looked better before telling people those needed fixing | 22:16:50 |
Grimmauld (any/all) | +1 for tracking issue, last take was emily saying it might not be necessary until we can grasp the scope of these fails | 22:17:25 |
nim65s | my workflow is usually to open upstream PR and substitute the thing from that PR, and wait for upstream to bikeshed on the number | 22:17:32 |
nim65s | * my workflow is usually to open upstream PR and substitute the thing from that PR, and wait for upstream to bikeshed on the version numbers | 22:17:45 |
nim65s | when they agree on something I fetchpath instead | 22:18:01 |
Grimmauld (any/all) | there is a lot of dead upstreams on the way to things like freecad, in which case it makes sense fetching from gentoo (they did cmake 4 before we did and have patches already) | 22:18:25 |
nim65s | but here you suggest doing writing a .patch in nixpkgs instead of fetchpatch ? | 22:18:33 |
Grimmauld (any/all) | hm? no the patch file in nixpkgs is unused, we can just fetch all those patches from gentoo | 22:19:03 |
nim65s | hum, they did that without opening a PR upstream ? I know it is dead, but that is still the best central place we have | 22:19:25 |
Grimmauld (any/all) | in the end it is whatever, the output is basically the same (barring drv hashes) | 22:19:34 |
Grimmauld (any/all) | oh wait i am dumb | 22:20:26 |