!UNVBThoJtlIiVwiDjU:nixos.org

Staging

317 Members
Staging merges | Find currently open staging-next PRs: https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+sort%3Aupdated-desc+head%3Astaging-next+head%3Astaging-next-21.05+is%3Aopen109 Servers

Load older messages


SenderMessageTime
11 Nov 2025
@k900:0upti.meK900...what the fuck11:15:18
@elvishjerricco:matrix.orgElvishJerriccoyea, this is great fun :P11:15:37
@elvishjerricco:matrix.orgElvishJerricco so much fun, you can't do the finalAttrs style fix with runCommand 11:17:18
@vcunat:matrix.orgVladimír ČunátI looked at that override a while ago, but no ideas why this would happen.11:17:28
@elvishjerricco:matrix.orgElvishJerricco well, presumably it's because the buildEnv' wrapper function in that build-tex-env.nix file is not really passing pathsToLink to buildEnv, but instead replacing it with overrideAttrs, which does not propagate to pathsToLinkJSON 11:18:25
@elvishjerricco:matrix.orgElvishJerricco because buildEnv uses rec instead of a finalAttrs type thing 11:18:42
@elvishjerricco:matrix.orgElvishJerricco which you can't do with runCommand 11:18:48
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)queue is basically empty, so i guess its just fixing the channel blockers now?11:18:49
@elvishjerricco:matrix.orgElvishJerricco so I guess I can either figure out how to plumb a finalAttrs into buildEnv to get rid of the rec, or I can just extract the pathsToLink arg and pass it to buildEnv properly 11:20:16
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all) do we even need overrideAttrs, can't we just // most of the things? 11:20:43
@elvishjerricco:matrix.orgElvishJerriccoyea it's not clear to me why this function was written this way11:21:36
@vcunat:matrix.orgVladimír ČunátI have a workaround for it.11:21:46
@vcunat:matrix.orgVladimír Čunát(fixing some texlive builds at least)11:21:59
@elvishjerricco:matrix.orgElvishJerricco good lord, the thing it does to extract extraOutputsToInstall appears to have been not working this whole time, so that's fun (there needed to be parens) 11:22:50
@vcunat:matrix.orgVladimír ČunátYeah, I'm adding the parens, too.11:23:08
@elvishjerricco:matrix.orgElvishJerriccooh we've done the same fix? :P11:23:17
@elvishjerricco:matrix.orgElvishJerricco
    buildEnv' =
      args:
      (buildEnv (
        {
          inherit (args) name paths;
        }
        // lib.optionalAttrs (args ? extraOutputsToInstall) { inherit (args) extraOutputsToInstall; }
        // lib.optionalAttrs (args ? pathsToLink) { inherit (args) pathsToLink; }
      )).overrideAttrs
        (
          removeAttrs args [
            "extraOutputsToInstall"
            "pathsToLink"
            "name"
            "paths"
            "pkgs"
          ]
        );
11:23:39
@vcunat:matrix.orgVladimír ČunátYes, exactly.11:24:04
@vcunat:matrix.orgVladimír ČunátUp to formatting and ordering in the list.11:24:14
@elvishjerricco:matrix.orgElvishJerriccolol11:24:19
@vcunat:matrix.orgVladimír Čunát* Up to formatting and ordering in the list. (I don't care about those)11:24:22
@elvishjerricco:matrix.orgElvishJerriccoyea, it does appear to resolve the issue11:24:40
@elvishjerricco:matrix.orgElvishJerriccoat the expense of perpetuating this madness11:24:46
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)

Why not just:

    buildEnv' =
      args:
      buildEnv (
        {
          inherit (args) name paths;
        }
        // (removeAttrs args [
          "name"
          "paths"
          "pkgs"
        ])
      );

Do we need the override?

11:24:50
@vcunat:matrix.orgVladimír Čunát I suspect it might better be refactored to pass all args directly except some extra ones defined by buildEnv' 11:24:57
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)actually wtf why is this wrapper there anyways11:25:09
@elvishjerricco:matrix.orgElvishJerriccoprobably not but I'm afraid to change it :P11:25:08
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all)like, that wrapper does nothing? i think?11:25:29
@elvishjerricco:matrix.orgElvishJerriccoyea wtf11:25:44
@grimmauld:grapevine.grimmauld.deGrimmauld (any/all) it removes pkgs, thats about it 11:25:52

Show newer messages


Back to Room ListRoom Version: 6