| 7 Jul 2021 |
Vladimír Čunát | Merged, and created new staging-next. | 06:49:57 |
Vladimír Čunát | Nit: I wondered whether the staging -> staging-next merge should be --no-ff. The previous one apparently wasn't, so I did it the same. | 06:50:56 |
hexa | https://github.com/NixOS/nixpkgs/pull/129506 for reference | 07:33:58 |
Sandro | In reply to @vcunat:matrix.org Nit: I wondered whether the staging -> staging-next merge should be --no-ff. The previous one apparently wasn't, so I did it the same. Did you manually merge it or via the website? The website normally shouldn't do a ff IIRC. | 08:31:09 |
Vladimír Čunát | I typically merge manually, so I can sign it. | 08:31:26 |
Sandro | I wouldn't want to do that especially when other people do things at the same time | 08:32:16 |
Vladimír Čunát | Pushes don't happen that often. (though I've ran into a series of r-ryan pushes at least once) | 08:34:00 |
Vladimír Čunát | and I'm used to easy rebasing of merges. | 08:34:11 |
Sandro | In reply to @vcunat:matrix.org Pushes don't happen that often. (though I've ran into a series of r-ryan pushes at least once) that really depends on the time of day. When I am just merging 10 PRs I had reviews running. | 08:36:13 |
Sandro | If you merge in the web sometimes github thinks forever if you can merge something or you need to reload the page multiple times until you can merge it. That usualy happens when things got merged recently. Happens to me somewhat often. | 08:36:57 |
| 8 Jul 2021 |
Sandro | https://github.com/NixOS/nixpkgs/pull/129506#issuecomment-875717997 | 15:00:06 |
Sandro | ^both issues are on mac. The optimization one seems to not work for mac and some missing symbols for arm64 | 15:00:51 |
hexa | great | 16:28:26 |
hexa | * great | 16:28:55 |
hexa | andi-: jonringer we likely need to find a replacement for or remove -fno-semantic-interpolation on darwin | 16:29:58 |
hexa |
clang-7: error: unknown argument: '-fno-semantic-interposition'
| 16:30:00 |
hexa | also yay, clang-7, can you go any lower? | 16:30:08 |
andi- | Yeah, wasn't that already discussed on the original PR? | 16:31:03 |
hexa | ah, so sterni (he/him) might know | 16:31:22 |
andi- | Just disable that stuff on Darwin. | 16:31:26 |
andi- | If someone cares about performance on that platform they can take on the battle. | 16:31:50 |
hexa | * andi-: jonringer we likely need to find a replacement for or remove -fno-semantic-interposition on darwin | 16:31:53 |
hexa | sgtm | 16:31:57 |
hexa | https://github.com/NixOS/nixpkgs/pull/129669 | 16:35:06 |
sterni | is LTO enabled on darwin currently? maybe the issues with linking stem from that, possibly | 19:47:58 |
hexa | disabling lto and poking ofborg | 20:35:39 |
hexa | * disabling lto on darwin and poking ofborg | 20:35:47 |
hexa | the latest issues don't seem to be lto related | 20:47:09 |
hexa | wondering if this is a python39 thing | 20:47:38 |
hexa | sterni (he/him): do you have a source for that clang 10 fno-semantic-interposition thing? | 21:01:55 |