!UNVBThoJtlIiVwiDjU:nixos.org

Staging

308 Members
Staging merges | Running staging cycles: https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+is%3Aopen+head%3Astaging-next+head%3Astaging-next-25.05 | Review Reports: https://malob.github.io/nix-review-tools-reports/105 Servers

Load older messages


SenderMessageTime
11 Oct 2025
@k900:0upti.meK900There is no way in hell that actually works, right10:47:15
@r_i_s:matrix.orgris_the intention was to have it present for all compilers10:47:18
@k900:0upti.meK900Can we just make that a throw instead10:47:24
@k900:0upti.meK900I really doubt there's actually a world where "enable every single hardening flag we know about" is a sane default10:47:51
@k900:0upti.meK900As much as I maybe would like it to be10:47:55
@r_i_s:matrix.orgris_mmmmmmmmmmmmmaybe?10:47:55
@yuka:yuka.devYureka (she/her) I see the actual list of defaultHardeningFlags is a function arg default in pkgs/build-support/bintools-wrapper/default.nix 10:48:54
@r_i_s:matrix.orgris_i'm open to making it throw, just don't know what else it might break10:48:58
@yuka:yuka.devYureka (she/her)whatever breaks was subtly broken all along10:49:16
@r_i_s:matrix.orgris_mmmmmmmmmmmmmmmaybe10:49:31
@k900:0upti.meK900I'd expect the actual nixpkgs side breakage to be fairly contained10:49:54
@k900:0upti.meK900Maybe just PR it and see what the eval compare says?10:50:02
@yuka:yuka.devYureka (she/her)we just have to figure out why the hell pkgsCross.wasi did not have defaultHardeningFlags10:50:14
@r_i_s:matrix.orgris_this kinda brings me back to "i'm amazed wrapped compilers work for wasm at all"10:51:40
@r_i_s:matrix.orgris_falling back to "all hardening flags", i think, was due to me trying to be minimally intrusive when making an already-major PR and not wanting to default to "no hardening" and be the reason someone didn't realize all their hardening flags have been off for years10:58:34
@r_i_s:matrix.orgris_now that it's separate from the big PR that introduced it, the change to making it hard-fail, on its own, may not be too disruptive10:59:30
@yuka:yuka.devYureka (she/her)fwiw, some more build failures: https://spectrum-os.org/lists/archives/spectrum-devel/82249ddc-ae1a-4e3a-a6ae-bb4717243fca@yuka.dev/10:59:42
@r_i_s:matrix.orgris_ i think the expectation would be that the compiler would have hardeningUnsupportedFlags properly defined so this would not be an issue 11:03:56
@k900:0upti.meK900 Then maybe we should throw if we have neither? 11:04:30
@r_i_s:matrix.orgris_ * i think the expectation was that the compiler would have hardeningUnsupportedFlags properly defined so this would not be an issue 11:04:48
@r_i_s:matrix.orgris_these all sound like sensible suggestions11:05:12
@yuka:yuka.devYureka (she/her)I still don't think all supported hardening flags should be enabled by accident11:05:26
@yuka:yuka.devYureka (she/her)given hardening flags also have performance penalties11:05:37
@yuka:yuka.devYureka (she/her)that's what pkgsExtraHardening is for11:05:48
@k900:0upti.meK900I think what we want is probably if [compiler explicitly declares supported] then [that] else [some set of sane defaults] - [compiler explicitly declares unsupported]11:07:08
12 Oct 2025
@anton:gersthof.comAnton (he/him) changed their display name from Anton to Anton (he/him).13:17:58
@emilazy:matrix.orgemily can we eat ~10k Ruby rebuilds on -next to fix extension modules with LLVM 21? 14:21:25
@emilazy:matrix.orgemilycould be conditioned on Darwin only for now14:21:30
@vcunat:matrix.orgvcunatSounds OK to me.14:46:55
@emilazy:matrix.orgemilyre the whole doing periodic merges via PR thing15:55:00

Show newer messages


Back to Room ListRoom Version: 6