| 28 Oct 2025 |
hexa | https://github.com/NixOS/nixpkgs/pull/192870 | 17:48:59 |
emily | oh, gah | 17:49:18 |
hexa | due to the node2nix abandonware | 17:49:20 |
emily | I specifically dropped that one because I saw that node2nix was "handling it" since 2020 | 17:49:29 |
emily | and forgot this particular nuance of how it "handles it" | 17:49:34 |
emily | in practice nodePackages is almost gone and IIRC node2nix doesn't even work with new Node versions anyway? so meh… | 17:49:55 |
hexa | so, thanks for pruning aliases | 17:51:14 |
dish [Fox/It/She] | wouldn't say almost gone at this point, still well over 100 packages in the set and the file is still 2+ MB >.> | 17:52:42 |
dish [Fox/It/She] | sadly | 17:52:49 |
emily | we could also attach warnings to the top-level system/hostPlatform/buildPlatform/targetPlatform which I think Artturin wanted to kill off | 17:54:26 |
emily | (they were added to the aliases file many years ago) | 17:54:32 |
emily | but I opted for being conservative about that since it's post-freeze | 17:54:39 |
Artturin | Oh yeah we still have those aliases, yeah we should make them warns | 17:55:58 |
emily | they're still used in pkgs/test even 🙃 | 17:56:13 |
emily | can we make stdenv.isFoo warn as well? 😆 | 17:56:16 |
emily | maybe something for early 26.05 | 17:56:21 |
emily | looking at the diff, runCommandNoCC, runCommandNoCCLocal, and maybe utillinux seem like the main things worth turning into warnings instead of throws | 18:00:22 |
Artturin | You sure? | 18:00:30 |
emily | might also be good to adjust the python throw error message | 18:00:47 |
emily | since it currently recommends people use python2 😆 | 18:00:51 |
emily | I'll PR those | 18:00:53 |
emily | https://github.com/NixOS/nixpkgs/actions/runs/18828351853/job/53715047703?pr=456065 | 18:01:01 |
emily | this is what happened when I forgot the commit reverting turning those into throws | 18:01:08 |
emily | vcunat: btw, warning aliases used in NixOS tests won't block/fail anything on Hydra, right? because the warning check there is only in the release checks? | 18:01:40 |
emily | is it possible to make Hydra do the equivalent of NIX_ABORT_ON_WARN instead of checking it in release checks, so that those are caught in the same way warnings in packages are? | 18:02:10 |
Artturin | Ok I can take care of those | 18:03:18 |
emily | no rush | 18:04:09 |
emily | but I do have a PR to attach warnings to them | 18:04:24 |
emily | for system it's kind of annoying, I had to do a __toString thing to stop it from spamming nix search :) | 18:04:45 |
Artturin | :p tests shows only one *Platform attribute missing
platformEquality = «error: attribute 'buildPlatform' missing»; | 18:04:51 |