!UNVBThoJtlIiVwiDjU:nixos.org

Staging

340 Members
Staging merges | Running staging cycles: https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+is%3Aopen+head%3Astaging-next+head%3Astaging-next-25.05 | Review Reports: https://malob.github.io/nix-review-tools-reports/113 Servers

Load older messages


SenderMessageTime
28 Oct 2025
@hexa:lossy.networkhexahttps://github.com/NixOS/nixpkgs/pull/19287017:48:59
@emilazy:matrix.orgemilyoh, gah17:49:18
@hexa:lossy.networkhexadue to the node2nix abandonware17:49:20
@emilazy:matrix.orgemily I specifically dropped that one because I saw that node2nix was "handling it" since 2020 17:49:29
@emilazy:matrix.orgemilyand forgot this particular nuance of how it "handles it"17:49:34
@emilazy:matrix.orgemily in practice nodePackages is almost gone and IIRC node2nix doesn't even work with new Node versions anyway? so meh… 17:49:55
@hexa:lossy.networkhexaso, thanks for pruning aliases17:51:14
@pyrox:pyrox.devdish [Fox/It/She] wouldn't say almost gone at this point, still well over 100 packages in the set and the file is still 2+ MB >.> 17:52:42
@pyrox:pyrox.devdish [Fox/It/She]sadly17:52:49
@emilazy:matrix.orgemily we could also attach warnings to the top-level system/hostPlatform/buildPlatform/targetPlatform which I think Artturin wanted to kill off 17:54:26
@emilazy:matrix.orgemily(they were added to the aliases file many years ago)17:54:32
@emilazy:matrix.orgemilybut I opted for being conservative about that since it's post-freeze17:54:39
@artturin:matrix.orgArtturinOh yeah we still have those aliases, yeah we should make them warns17:55:58
@emilazy:matrix.orgemily they're still used in pkgs/test even 🙃 17:56:13
@emilazy:matrix.orgemily can we make stdenv.isFoo warn as well? 😆 17:56:16
@emilazy:matrix.orgemilymaybe something for early 26.0517:56:21
@emilazy:matrix.orgemily looking at the diff, runCommandNoCC, runCommandNoCCLocal, and maybe utillinux seem like the main things worth turning into warnings instead of throws 18:00:22
@artturin:matrix.orgArtturinYou sure?18:00:30
@emilazy:matrix.orgemily might also be good to adjust the python throw error message 18:00:47
@emilazy:matrix.orgemily since it currently recommends people use python2 😆 18:00:51
@emilazy:matrix.orgemilyI'll PR those18:00:53
@emilazy:matrix.orgemilyhttps://github.com/NixOS/nixpkgs/actions/runs/18828351853/job/53715047703?pr=45606518:01:01
@emilazy:matrix.orgemilythis is what happened when I forgot the commit reverting turning those into throws18:01:08
@emilazy:matrix.orgemily vcunat: btw, warning aliases used in NixOS tests won't block/fail anything on Hydra, right? because the warning check there is only in the release checks? 18:01:40
@emilazy:matrix.orgemily is it possible to make Hydra do the equivalent of NIX_ABORT_ON_WARN instead of checking it in release checks, so that those are caught in the same way warnings in packages are? 18:02:10
@artturin:matrix.orgArtturinOk I can take care of those18:03:18
@emilazy:matrix.orgemilyno rush18:04:09
@emilazy:matrix.orgemilybut I do have a PR to attach warnings to them18:04:24
@emilazy:matrix.orgemily for system it's kind of annoying, I had to do a __toString thing to stop it from spamming nix search :) 18:04:45
@artturin:matrix.orgArtturin :p tests shows only one *Platform attribute missing
platformEquality = «error: attribute 'buildPlatform' missing»;
18:04:51

Show newer messages


Back to Room ListRoom Version: 6