!UNVBThoJtlIiVwiDjU:nixos.org

Staging

347 Members
Staging merges | Running staging cycles: https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+is%3Aopen+head%3Astaging-next+head%3Astaging-next-25.11 | Review Reports: https://malob.github.io/nix-review-tools-reports/115 Servers

Load older messages


SenderMessageTime
15 Feb 2026
@k900:0upti.meK900https://github.com/NixOS/nixpkgs/pull/490634 ?11:21:13
@k900:0upti.meK900And I guess we drop the revert when Yarn updates?11:22:35
@k900:0upti.meK900...wait11:22:38
@k900:0upti.meK900W A I T11:22:40
@k900:0upti.meK900Oh no11:22:44
@k900:0upti.meK900 OH NO 11:22:52
@ma27:nicht-so.sexyma27good to know, I was already wondering why my attempt to reproduce the mismatch (or even one of the hashes) was unsuccessful last night :DDD11:24:44
@yuka:yuka.devYureka (she/her)yarn can never update11:25:46
@k900:0upti.meK900Yep11:25:54
@yuka:yuka.devYureka (she/her)except when bumping the lockfile version11:25:56
@k900:0upti.meK900That's the connection I made11:26:03
@pyrox:pyrox.devdish [Fox/It/She]gods i hate the need for this patch15:39:26
@emilazy:matrix.orgemily violates https://github.com/NixOS/nixpkgs/blob/629c1974f38a329330ada72abacb85b239b495df/pkgs/README.md#overrideattrs-and-overridepythonattrs? 15:46:51
@k900:0upti.meK900I mean15:47:24
@k900:0upti.meK900I don't want to uplift this patch into zlib-ng15:47:32
@qyliss:fairydust.spaceAlyssa RossWhy not?15:48:53
@emilazy:matrix.orgemilyif this fixes a nondeterminism issue then it seems dodgy to just revert it. presumably the yarn hashes are deterministic in practice but in a different way and we should match that?15:49:42
@emilazy:matrix.orgemilymaybe upstream would even be amenable to that as it would increase compatibility of the fix?15:50:00
@qyliss:fairydust.spaceAlyssa RossOh it's a revert15:50:56
@k900:0upti.meK900 I think it fixes a determinism issue if you hold the API wrong 15:51:25
@emilazy:matrix.orgemilythat said it seems unlikely that zlib-ng will guarantee bit-reproducible compression outfit forever right15:51:30
@k900:0upti.meK900Which yarn doesn't seem to be doing15:51:35
@k900:0upti.meK900Oh no it won't15:51:37
@k900:0upti.meK900Yarn vendors it15:51:39
@emilazy:matrix.orgemilyso pinning a version seems unavoidable in the long run15:51:40
@k900:0upti.meK900We may have to do that long term anyway15:51:46
@qyliss:fairydust.spaceAlyssa RossIn which case we should not overrideAttrs and should just make a separate expression for yarn's zlib-ng.15:52:00
@emilazy:matrix.orgemilyso adding a patch revert that violates the guidelines from the checklist doesn't seem acceptable15:52:07
@k900:0upti.meK900Or we slap upstream with a fish until they concede that this was a terrible idea15:52:08
@pyrox:pyrox.devdish [Fox/It/She]well its more an issue of having to regenerate all hashes of every dependency for every yarn package, no? unless im misunderstanding this15:52:15

Show newer messages


Back to Room ListRoom Version: 6