| 30 Jun 2026 |
 K900 | And there's the 1.96.1 miscompilation | 17:44:47 |
 Lach | I don't think so, as with ndarray and other packages this issue would be deep into the dependency graph | 17:44:48 |
 emily | I guess if it's everything using zlib-rs, yeah… | 17:44:50 |
| K900 | Which is much more subtle | 17:44:49 |
| emily | the other thing is, 1.96.1 also has https://github.com/libssh2/libssh2/commit/97acf3dfda80c91c3a8c9f2372546301d4a1a7a8 | 17:44:57 |
| emily | I believe we devendor libssh2, but this commit isn't in any release of libssh2 | 17:45:06 |
| K900 | We're not using vendored libssh | 17:45:07 |
| emily | yes but | 17:45:11 |
| emily | that just means we're vulnerable across the board | 17:45:16 |
| emily | so we should probably consider applying this to our libssh2, at which point we eat a Rust rebuild anyway | 17:45:24 |
| K900 | Have we not patched libssh this cycle | 17:45:27 |
| emily | I didn't check admittedly | 17:45:37 |
 whispers [& it/fae] | only one of them | 17:45:39 |
| whispers [& it/fae] | we need a few more iirc. was planning to look once i get off work unless someone does it first | 17:46:04 |
| emily | let's just patch libssh2 and bump Rust. we're already way ahead of schedule | 17:46:15 |
| emily | not worth the grief | 17:46:25 |
| Lach | Also, the other way is updating rustc to use llvm22 packages, I'm not sure if there is any implications in that | 17:46:35 |
| whispers [& it/fae] | looks like someone also proposed libssh2 bumping to an unstable commit a few hours ago: https://github.com/NixOS/nixpkgs/pull/537075 | 17:47:10 |
| emily | let's not, we're due to bump to 22 across the board anyway | 17:47:20 |
| emily | but it can wait another cycle | 17:47:24 |
| Lach | I mean, unless we update, packages using ndarray and zlib-rs are broken... | 17:48:00 |
| emily | that's scary, we should just cherry-pick | 17:47:59 |
| emily | if 1.96.1 fixes it it's better to update to 1.96.1 than to bump rustc LLVM to 22 | 17:48:23 |
| emily | both are equal rebuilds | 17:48:29 |
| Lach | Rustc 1.96.1 doesn't fix the avx512 problem | 17:48:54 |
| whispers [& it/fae] | * | 17:49:17 |
| emily | I see | 17:49:30 |
| emily | I'm a bit confused though | 17:49:39 |
| emily | if everything using zlib-rs should fail at build time, then we should be seeing a lot more fallout? | 17:49:50 |
| emily | for instance, jujutsu builds | 17:50:19 |
