| 4 Jul 2026 |
Gaétan Lepage | hexa: keras "fix": https://github.com/NixOS/nixpkgs/pull/538342 | 14:20:44 |
emily | I see the gcc/ Makefiles that it lists separately, but not anything else | 14:20:44 |
K900 | Or is it Android.gn now | 14:20:52 |
emily | there is no Android.mk in this repo | 14:20:50 |
emily | there is no Android.anything | 14:21:05 |
emily | https://github.com/open-vela/external_libldac/commit/d9d3b7f57398eccffbf035ffbd0e12dbf8fc77b2 | 14:21:11 |
K900 | Oh they apparently deleted it | 14:21:53 |
K900 | Because they're now using some weird build system | 14:22:16 |
emily | K900: is the bug from https://github.com/NixOS/nixpkgs/pull/502690 fixed in this fork? | 14:22:22 |
K900 | Yes | 14:22:32 |
K900 | And a bunch of other memory safety issues | 14:22:36 |
emily | ok | 14:22:40 |
K900 | It's at least somewhat maintained | 14:22:50 |
emily | still a bit scary to be building this into PipeWire if it's super niche imo but | 14:22:52 |
K900 | Which is better than anything else we've found of that vintage | 14:22:56 |
emily | do you mean https://github.com/open-vela/external_libldac/blob/dev/gcc/libldacBT.mk or is the build system elsewhere? | 14:23:02 |
K900 | No, it's elsewhere | 14:23:43 |
emily | can you… find it? :) | 14:23:57 |
K900 | https://github.com/open-vela/external/blob/d4eb24208aee0a0413e8f2ec9583666cb64f179e/libldac/Makefile#L20 | 14:24:19 |
emily | I can get this working on Darwin but given that the code comments are wrong and we're currently open-coding a build system it'd be nice if we can reuse the existing work to some extent | 14:24:23 |
whoami [violet_cookie_bytes] | can‘t look at it atm, but I would guess it should be possible to drop ldacbt from GStreamer build inputs on Darwin if required… | 14:24:29 |
whoami [violet_cookie_bytes] | (new GStreamer maintainer here, I‘m trying to monitor this channel for GStreamer breakage mentions- if you come across any GStreamer related staging issues, please feel free to mention me) | 14:24:32 |
K900 | Oh no | 14:25:03 |
emily | it's probably droppable yeah, but also probably better to just fix | 14:25:03 |
K900 | Absolutely not | 14:25:05 |
emily | it's a codec after all | 14:25:08 |
K900 | It's Android flavored makefile garbage | 14:25:12 |
K900 | But instead of dropping it like Android did they doubled down | 14:25:25 |
emily | ok, then how about we reuse https://github.com/open-vela/external_libldac/blob/dev/gcc/libldacBT.mk? | 14:25:27 |
emily | which looks pretty normal | 14:25:35 |