!UNVBThoJtlIiVwiDjU:nixos.org

Staging

400 Members
Staging merges | Find currently open staging-next PRs: https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+sort%3Aupdated-desc+head%3Astaging-next+head%3Astaging-next-21.05+is%3Aopen128 Servers

Load older messages


SenderMessageTime
27 Oct 2021
@vcunat:matrix.orgVladimír Čunát
In reply to @janne.hess:helsinki-systems.de

This is probably what's needed to disable lseek:

diff --git a/src/copy.c b/src/copy.c
index cb9018f93..2a4ccc061 100644
--- a/src/copy.c
+++ b/src/copy.c
@@ -502,7 +502,7 @@ write_zeros (int fd, off_t n_bytes)
   return true;
 }

-#ifdef SEEK_HOLE
+#if 0
 /* Perform an efficient extent copy, if possible.  This avoids
    the overhead of detecting holes in hole-introducing/preserving
    copy, and thus makes copying sparse files much more efficient.
@@ -1095,7 +1095,7 @@ infer_scantype (int fd, struct stat const *sb,
          && ST_NBLOCKS (*sb) < sb->st_size / ST_NBLOCKSIZE))
     return PLAIN_SCANTYPE;

-#ifdef SEEK_HOLE
+#if 0
   scan_inference->ext_start = lseek (fd, 0, SEEK_DATA);
   if (0 <= scan_inference->ext_start)
     return LSEEK_SCANTYPE;
@@ -1377,7 +1377,7 @@ copy_reg (char const *src_name, char const *dst_name,
       off_t n_read;
       bool wrote_hole_at_eof = false;
       if (! (
-#ifdef SEEK_HOLE
+#if 0
              scantype == LSEEK_SCANTYPE
              ? lseek_copy (source_desc, dest_desc, buf, buf_size, hole_size,
                            scan_inference.ext_start, src_open_sb.st_size,
diff --git a/tests/seek-data-capable b/tests/seek-data-capable
index cc6372214..6e7a9ec1e 100644
--- a/tests/seek-data-capable
+++ b/tests/seek-data-capable
@@ -1,5 +1,7 @@
 import sys, os, errno, platform

+sys.exit(1)
+
 # Pass an _empty_ file
 if len(sys.argv) != 2:
     sys.exit(1)
I also confirm that this patch fixes peertube build, atop staging-next. (same machine: all ext4 on LVM, x86_64-linux)
07:46:30
@janne.hess:helsinki-systems.dedas_j
In reply to @vcunat:matrix.org
I also confirm that this patch fixes peertube build, atop staging-next. (same machine: all ext4 on LVM, x86_64-linux)
Awesome! Thank you. The build fails because presumably a file is broken, right? It's not because cp fails in the build process?
07:47:43
@janne.hess:helsinki-systems.dedas_jAlso, is your /tmp on tmpfs? 07:47:52
@vcunat:matrix.orgVladimír Čunát
In reply to @janne.hess:helsinki-systems.de
Also, is your /tmp on tmpfs?
No, it's all ext4 on LVM.
07:49:53
@vcunat:matrix.orgVladimír Čunát
In reply to @janne.hess:helsinki-systems.de
Awesome! Thank you. The build fails because presumably a file is broken, right? It's not because cp fails in the build process?

I haven't poked into details of the error. It looks like it attempts some tests after build and those all end with

Error: The service is no longer running
07:50:38
@janne.hess:helsinki-systems.dedas_j
In reply to @vcunat:matrix.org
No, it's all ext4 on LVM.
Umm, do you have time to check whether that also happens with boot.tmpOnTmpfs?
08:08:35
@janne.hess:helsinki-systems.dedas_jBecause that's one big difference between us. For you, it's the same filesystem, for me it's not08:08:56
@janne.hess:helsinki-systems.dedas_jIf you don't have the time, this is the current draft:08:18:29
@janne.hess:helsinki-systems.dedas_jRedacted or Malformed Event08:18:32
@vcunat:matrix.orgVladimír Čunát
In reply to @janne.hess:helsinki-systems.de
Because that's one big difference between us. For you, it's the same filesystem, for me it's not
Build on progress. (plain staging-next, all same except for tmpfs on /tmp)
08:20:14
@vcunat:matrix.orgVladimír Čunát
In reply to @vcunat:matrix.org
Build on progress. (plain staging-next, all same except for tmpfs on /tmp)

It still fails, but the error is different; I think it happens a bit earlier than with ext4 (before any tests start)

Generating browser application bundles (phase: building)...node:events:368
      throw er; // Unhandled 'error' event
      ^

Error: write EPIPE
08:28:03
@janne.hess:helsinki-systems.dedas_jalright, so it's not related to the two fsses08:28:26
@janne.hess:helsinki-systems.dedas_j * alright, so it's not related to the two FSes ;)08:28:29
@janne.hess:helsinki-systems.dedas_jThank you08:28:34
@vcunat:matrix.orgVladimír ČunátI tried again with the same error, so the messages appear stable and FS changes when the error hapens.08:30:20
@vcunat:matrix.orgVladimír Čunát * I tried again with the same error, so the messages appear stable and FS changes when the error happens. (well, on a quick guess)08:30:39
@vcunat:matrix.orgVladimír Čunát * I tried again with the same error, so the messages appear stable and FS changes when an error happens. (well, on a quick guess)08:30:55
@janne.hess:helsinki-systems.dedas_jI have created a potential workaround: https://github.com/NixOS/nixpkgs/pull/14309709:08:58
@lourkeur:nixos.devlourkeur (Nix OwO) joined the room.09:30:25
@janne.hess:helsinki-systems.dedas_jimage.png
Download image.png
09:31:26
@janne.hess:helsinki-systems.dedas_jFinal version09:31:33
@moritz.hedtke:matrix.orgmoritz.hedtke
In reply to @vcunat:matrix.org

I haven't poked into details of the error. It looks like it attempts some tests after build and those all end with

Error: The service is no longer running
I think the error is from esbuild which is a JavaScript module bundler.
10:21:59
@moritz.hedtke:matrix.orgmoritz.hedtke
In reply to @vcunat:matrix.org

It still fails, but the error is different; I think it happens a bit earlier than with ext4 (before any tests start)

Generating browser application bundles (phase: building)...node:events:368
      throw er; // Unhandled 'error' event
      ^

Error: write EPIPE
I sometimes got that error locally in my machine and sometimes the other. I could not identify what influences it but I assume it's just the timing whether esbuild is no longer running or it just crashed or so and an EPIPE comes (which means written to closed pipe?)
10:23:41
@moritz.hedtke:matrix.orgmoritz.hedtkeWhat's wrong with the reply feature?!?10:24:06
@vcunat:matrix.orgVladimír Čunát
In reply to @moritz.hedtke:matrix.org
What's wrong with the reply feature?!?
I can't see anything wrong really. Perhaps just not too ergonomic in my opinion (in Element UI at least).
10:25:20
@moritz.hedtke:matrix.orgmoritz.hedtke
In reply to @vcunat:matrix.org
I can't see anything wrong really. Perhaps just not too ergonomic in my opinion (in Element UI at least).
Now it's this small window which I think it's nicer. Maybe it depends on the size of the message or so
10:25:58
@moritz.hedtke:matrix.orgmoritz.hedtkeRegarding the first error are you sure it's when the tests are running? I will check later but I though it was still while building but I didn't really pay attention that closely10:26:56
@vcunat:matrix.orgVladimír Čunát
In reply to @moritz.hedtke:matrix.org
Regarding the first error are you sure it's when the tests are running? I will check later but I though it was still while building but I didn't really pay attention that closely
I'm not sure. I didn't save the log and it got rewritten by the one with tmpfs usage :-/ (there it's when "Generating browser application bundles")
10:30:52
@moritz.hedtke:matrix.orgmoritz.hedtkeYeah ok, that sounds more likely to be while building. I thought that both errors are more or less at the same place and the thing I said above happens (so timing decides whether already crashed or closed pipe)10:32:44
@vcunat:matrix.orgVladimír ČunátNow with ext4 I got the same error as with tmpfs.10:38:02

Show newer messages


Back to Room ListRoom Version: 6