| 18 Jun 2026 |
r-burns | Rebuild count might be bordering a staging target though, I'm seeing 501 although they are mostly small python packages | 00:52:51 |
r-burns | https://github.com/NixOS/nixpkgs/pull/532836 | 00:56:27 |
hexa | that could be as low as 101 | 00:56:45 |
hexa | 492 | 00:57:06 |
hexa | 😉 | 00:57:09 |
r-burns | I did a local nixpkgs-review rev HEAD that reported 501 | 00:57:14 |
hexa | https://github.com/NixOS/nixpkgs/actions/runs/27729394803 | 00:57:26 |
debtquity | hmm? | 01:06:39 |
hexa | https://github.com/NixOS/nixpkgs/pull/528906#issuecomment-4707863514 | 01:07:13 |
debtquity | so if i update valkey, i need to individually update all of these small python libs too? | 01:07:19 |
hexa | you need to test them | 01:07:26 |
hexa | at least some of them | 01:07:43 |
hexa | the ones that are prone to breaking | 01:07:48 |
hexa | like python3.pkgs.valkey | 01:07:51 |
hexa | you can collect them into passthru.tests | 01:08:17 |
hexa | and the build valkey.tests | 01:08:22 |
hexa | Redacted or Malformed Event | 01:08:30 |
debtquity | will just invoking the problematic downstream packages work?
https://github.com/NixOS/nixpkgs/blob/d1a55f0c7b921d541c6142994c96fbd7f1fa562e/pkgs/by-name/va/valkey/package.nix#L110-L113
passthru = {
tests = {
redis = nixosTests.redis;
python3-valkey = callPackage python3.pkgs.valkey;
};
serverBin = "valkey-server";
};
???
| 01:26:27 |
debtquity | surprised there's not much there at the moment, guess the previous maintainers had it in their head? | 01:28:00 |
r-burns | tried a nixpkgs-review and it OOMed after about 125 builds, but didn't see any failures other than the preexisting python3.pkgs.jupytext from that sample. Will try again later | 01:34:42 |
guillaume | I can try a local nixpkgs review if it's needed | 06:56:31 |
guillaume | I have a lot of ram ahhaa | 06:56:45 |
r-burns | I'm having more luck trying it on a less anemic machine than my laptop, haha :)
More eyes are always appreciated so feel free to beat me to the punch if you've got spare cycles but I'll be posting a proper review report soon. | 06:59:03 |
r-burns | nixpkgs-review is done and seems OK: https://github.com/NixOS/nixpkgs/pull/532836#issuecomment-4739270789 ⏩ 10 packages marked as broken and skipped:
❌ 3 packages failed to build:
python313Packages.pyinterp
python314Packages.opensfm
python314Packages.pyinterp
✅ 478 packages built:
| 07:50:29 |
Grimmauld (any/all) | you really don't want to nixpkgs-review staging stuff, that is a glorious waste of resources | 08:08:36 |
Grimmauld (any/all) | you get the exact rebuild count from the actions report | 08:09:01 |
Grimmauld (any/all) | just build a few packages you know have been problematic in the past | 08:09:19 |
r-burns | We were planning to send it to master + backport, so I'm not picking up any unrelated staging builds in this report | 08:10:20 |
r-burns | I can definitely send it to staging like a typical stabilization PR, just thought it might be cleaner to do it this way for an ordinary package bump that master'll want too | 08:11:58 |
Grimmauld (any/all) | even if you're sending it to master, 500 is quite expensive... | 08:19:13 |