| 16 Jun 2026 |
tfc | it would be a bit of a shame if we couldn't have that because CI (re)builds them unnecessarily | 11:40:53 |
leona | * is it important that it gets built by hydra? I mean we can still provide it in Nixpkgs | 11:40:55 |
tfc | not important that hydra builds it | 11:40:59 |
leona | that's my suggestion for that https://github.com/NixOS/nixpkgs/pull/532396 | 18:16:35 |
leona | even makes GHA eval ~1.89% faster ^^ | 18:17:15 |
| 18 Jun 2026 |
r-burns | python3.pkgs.fakeredis fails some tests on staging-next-26.05, bumping to latest seems to fix it. Bump doesn't seem to cause breakage on master so potentially could merge to master -> backport 26.05 -> merge into staging-next-26.05 if that seems cleaner than a cherry-pick. | 00:40:45 |
hexa | master -> release-26.05 sounds fine to me | 00:42:19 |
hexa | probably another fallout from the valkey 9.1 update that surely had no breaking changes | 00:42:57 |
hexa | Redacted or Malformed Event | 00:43:05 |
r-burns | Rebuild count might be bordering a staging target though, I'm seeing 501 although they are mostly small python packages | 00:52:51 |
r-burns | https://github.com/NixOS/nixpkgs/pull/532836 | 00:56:27 |
hexa | that could be as low as 101 | 00:56:45 |
hexa | 492 | 00:57:06 |
hexa | 😉 | 00:57:09 |
r-burns | I did a local nixpkgs-review rev HEAD that reported 501 | 00:57:14 |
hexa | https://github.com/NixOS/nixpkgs/actions/runs/27729394803 | 00:57:26 |
debtquity | hmm? | 01:06:39 |
hexa | https://github.com/NixOS/nixpkgs/pull/528906#issuecomment-4707863514 | 01:07:13 |
debtquity | so if i update valkey, i need to individually update all of these small python libs too? | 01:07:19 |
hexa | you need to test them | 01:07:26 |
hexa | at least some of them | 01:07:43 |
hexa | the ones that are prone to breaking | 01:07:48 |
hexa | like python3.pkgs.valkey | 01:07:51 |
hexa | you can collect them into passthru.tests | 01:08:17 |
hexa | and the build valkey.tests | 01:08:22 |
hexa | Redacted or Malformed Event | 01:08:30 |
debtquity | will just invoking the problematic downstream packages work?
https://github.com/NixOS/nixpkgs/blob/d1a55f0c7b921d541c6142994c96fbd7f1fa562e/pkgs/by-name/va/valkey/package.nix#L110-L113
passthru = {
tests = {
redis = nixosTests.redis;
python3-valkey = callPackage python3.pkgs.valkey;
};
serverBin = "valkey-server";
};
???
| 01:26:27 |
debtquity | surprised there's not much there at the moment, guess the previous maintainers had it in their head? | 01:28:00 |
r-burns | tried a nixpkgs-review and it OOMed after about 125 builds, but didn't see any failures other than the preexisting python3.pkgs.jupytext from that sample. Will try again later | 01:34:42 |
guillaume | I can try a local nixpkgs review if it's needed | 06:56:31 |