| 2 Jan 2025 |
atemu12 | We had some GH actions stuff that broke at some point because nobody bothered | 16:40:55 |
atemu12 | Though I doubt we can build anything of interest in GHA | 16:41:04 |
atemu12 | (x) | 16:41:19 |
oak 🏳️🌈♥️ | Yeah I guess they give some free monthly hours for open source projects, I think there's a cap that one build can take 6 hours at maximum | 16:41:39 |
atemu12 | If the machine is slow, we might exceed that | 16:41:59 |
oak 🏳️🌈♥️ | I'm not completely sure how that works with GitHub, is it organizational or project level | 16:42:05 |
atemu12 | And RAM is probably the more pressing issue | 16:42:10 |
atemu12 | I've got access to some builders that I'm sure we could use | 16:42:57 |
atemu12 | If you want to build some CI, please go right ahead | 16:43:23 |
oak 🏳️🌈♥️ | :) | 16:43:32 |
oak 🏳️🌈♥️ | I think even Hetzner's 25€/month cloud VPS machine would be sufficient for building many things | 16:43:55 |
atemu12 | Yeah but as I mentioned; I have access to builders that we could use and are more than powerful enough | 16:44:59 |
atemu12 | That's not going to be an issue | 16:45:10 |
atemu12 | Building meaningful checks is the harder problem | 16:45:47 |
oak 🏳️🌈♥️ | I saw your PR about enabling LineageOS's prebuilt webview and it taking a lots of disk space | 17:02:07 |
oak 🏳️🌈♥️ | Did you check is the LOS prebuilt webview a trichrome-variant of the Chromium build? | 17:02:32 |
atemu12 | No but I solved that issue | 17:03:31 |
oak 🏳️🌈♥️ | I think Trichrome is a build which has 3 APKs, one for Chromium, one for Webview, and one for shared common parts both of those use | 17:03:34 |
atemu12 | The problem was caused by robotnix; more specifically what I declared it to do | 17:03:45 |
atemu12 | LOS doesn't need a chromium because it has this webview browser | 17:04:03 |
atemu12 | And honestly anyone who wants a chromium for browsing purposes should install one at runtime | 17:04:20 |
oak 🏳️🌈♥️ | (In addition to Trichrome, you can just build either standalone Chromium or standalone Webview, but that then takes more disk space) | 17:05:48 |
oak 🏳️🌈♥️ | * (In addition to Trichrome, you can just build either standalone Chromium or standalone Webview, or both separately as standalone, but that then takes more disk space) | 17:06:00 |
atemu12 | It claims to be a "webview" apk | 17:06:16 |
oak 🏳️🌈♥️ | but yeah, about the CI and testing, I think proper testing would actually be to install the build into some device, and try to run some tests with that | 17:08:54 |
atemu12 | Emulator would be ideal | 17:09:25 |
oak 🏳️🌈♥️ | but even checking that stuff builds successfully is usually a good start | 17:09:25 |
atemu12 | Yes although, at this point, if I can't verify that something works as intended or the author convinced me that they have done so sufficiently, I'm not merging it anyways | 17:10:47 |
atemu12 | CI would be most useful for catching stupid careless mistakes | 17:11:17 |
atemu12 | Or enforcing standards | 17:11:31 |