| 16 Nov 2024 |
 atemu12 | I'd guess https://github.com/LineageOS/android_vendor_lineage | 02:28:42 |
 oak 🏳️🌈♥️ | https://review.lineageos.org/c/LineageOS/android_vendor_lineage/+/356656 I probably found it | 02:28:52 |
| oak 🏳️🌈♥️ | Haven't they also done this for 20 and 21? | 02:29:56 |
| atemu12 | Not sure | 02:30:24 |
| atemu12 | I can't remember seeing this error but I'd have to check the diff for the LOS 20 merge | 02:30:44 |
| atemu12 | Ah | 02:31:41 |
| atemu12 | e1b99ec7a9bf57d4e13e157ed289a1943d1e4849 | 02:31:42 |
| oak 🏳️🌈♥️ | https://review.lineageos.org/c/LineageOS/android_vendor_lineage/+/356657 I see this for 20 | 02:32:08 |
| atemu12 | Wait where's the patch | 02:33:00 |
| atemu12 | Ah, I was on a super old branch on this machine | 02:33:33 |
| atemu12 | 11e02c0ce2452b3822a2f8695ac600b6e245ac9a | 02:34:00 |
| oak 🏳️🌈♥️ | Am I seeing correctly that this commit actually adds a patch and fix for the issue, but it's not used anywhere | 02:37:43 |
| atemu12 | I think I messed up the rebase back then | 02:38:00 |
| atemu12 | It's used but only on 13 | 02:38:04 |
| atemu12 | I thought it was new for 20 | 02:38:23 |
| oak 🏳️🌈♥️ | Okay, so now I can try to go back to the master version, try to do the update.sh again, and add the patch | 02:38:36 |
| atemu12 | So port the patch and adjust the guard | 02:38:41 |
| atemu12 | You should only need the patch | 02:38:56 |
| atemu12 | Does it build now? | 03:05:14 |
| oak 🏳️🌈♥️ | I'm just testing, I see the patch got included | 03:15:52 |
| oak 🏳️🌈♥️ | It's fun how in the end all this gets fixed by decrementing one number in one source code file :D | 03:18:27 |
| oak 🏳️🌈♥️ | I checked from lineage-18.1 and there they had rejected the gerrit patch, but I can make PR about this | 03:18:57 |
| atemu12 | Sure | 03:19:07 |
| oak 🏳️🌈♥️ | Thanks for all the help | 03:21:15 |
| atemu12 | No problem | 03:21:27 |
| oak 🏳️🌈♥️ | Let's see if the next fight is about getting the version 20 to build | 03:21:30 |
| atemu12 | If 20 didn't build that'd be news to me and my device running 20 ;) | 03:21:49 |
| oak 🏳️🌈♥️ | Ah for the PR I would actually need to update the repo.json also to make the problem appear, otherwise it will fail to apply the patch | 03:25:34 |
| atemu12 | Feel free to bump LOS 19 | 03:25:59 |
| atemu12 | (Separate commit though please.) | 03:26:33 |
