!UUYziobKGGxpovWyAN:nixos.org

Robotnix

244 Members
Build Android (AOSP) using Nix | https://github.com/danielfullmer/robotnix75 Servers

Load older messages


SenderMessageTime
28 Jul 2024
@matthewcroughan:defenestrate.itmatthewcroughan - nix.zone This happens even if I define source.dirs."device/samsung/hlte".src = pkgs.fetchgit { ... } 00:25:57
@atemu12:matrix.orgatemu12There is no such logic00:26:17
@matthewcroughan:defenestrate.itmatthewcroughan - nix.zoneBecause robotnix now will read some json file from the lineageos it fetched00:26:17
@atemu12:matrix.orgatemu12The attribute simply isn't there00:26:34
@atemu12:matrix.orgatemu12Use a repl and check eval00:26:46
@matthewcroughan:defenestrate.itmatthewcroughan - nix.zoneNot sure what you mean.00:26:59
@matthewcroughan:defenestrate.itmatthewcroughan - nix.zoneDo you not see what is happening? 00:27:07
@atemu12:matrix.orgatemu12 Use nix repl and then check the value of config.source.dirs 00:27:19
@matthewcroughan:defenestrate.itmatthewcroughan - nix.zoneIt is reading a JSON file from the LineageOS upstream00:27:24
@atemu12:matrix.orgatemu12That's the default00:27:43
@matthewcroughan:defenestrate.itmatthewcroughan - nix.zonehttps://github.com/nix-community/robotnix/blob/master/flavors/lineageos/default.nix#L24-L2600:27:50
@matthewcroughan:defenestrate.itmatthewcroughan - nix.zoneah okay00:27:53
@atemu12:matrix.orgatemu12This is a module system, you can add any source dir you like00:27:54
@atemu12:matrix.orgatemu12You either have a typo here or something else is going on00:28:08
@matthewcroughan:defenestrate.itmatthewcroughan - nix.zone
nix-repl> robotnixConfigurations.brownstone.config.source.dirs
error:
       … while evaluating the attribute 'value'
         at /nix/store/9fpv0kjq9a80isa1wkkvrdqsh9dpcn05-source/lib/modules.nix:807:9:
          806|     in warnDeprecation opt //
          807|       { value = builtins.addErrorContext "while evaluating the option `${showOption loc}':" value;
             |         ^
          808|         inherit (res.defsFinal') highestPrio;

       … while evaluating the option `source.dirs':

       … while evaluating the attribute 'mergedValue'
         at /nix/store/9fpv0kjq9a80isa1wkkvrdqsh9dpcn05-source/lib/modules.nix:842:5:
          841|     # Type-check the remaining definitions, and merge them. Or throw if no definitions.
          842|     mergedValue =
             |     ^
          843|       if isDefined then

       … while evaluating definitions from `/nix/store/0iavq4h1d2mk95fbdrdzashahbqiri9f-source/flavors/lineageos':

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: attribute '"device/samsung/hlte"' missing
       at /nix/store/0iavq4h1d2mk95fbdrdzashahbqiri9f-source/flavors/lineageos/default.nix:132:43:
          131|     relpathWithDeps = relpath: [ relpath ] ++ (
          132|       flatten (map (p: relpathWithDeps p) deviceDirs.${relpath}.deps)
             |                                           ^
          133|     );
00:28:32
@matthewcroughan:defenestrate.itmatthewcroughan - nix.zone I cannot evaluate source.dirs due to it failing earlier 00:28:57
@atemu12:matrix.orgatemu12Then I'm not sure00:29:32
@atemu12:matrix.orgatemu12You'd have to dig into it00:29:37
@samueldr:matrix.orgsamueldr
In reply to @matthewcroughan:defenestrate.it
Is anyone aware that you cannot add new devices to robotnix that aren't supported in upstream due to the logic in flavors/lineageos/default.nix only allowing usage of official lineage devices, without the ability to override this behavior?
explain how I'm building LineageOS for an unsupported device then?
00:30:36
@matthewcroughan:defenestrate.itmatthewcroughan - nix.zoneI am also, an earlier version (11)00:30:49
@samueldr:matrix.orgsamueldr[but that might have broken with the changes since]00:30:50
@matthewcroughan:defenestrate.itmatthewcroughan - nix.zonewhich changes the logic00:30:52
@matthewcroughan:defenestrate.itmatthewcroughan - nix.zoneWhen using androidVersion 12 or 13 things get a bit weirder00:31:05
@samueldr:matrix.orgsamueldrandroidVersion 11 for my part00:31:19
@matthewcroughan:defenestrate.itmatthewcroughan - nix.zonehttps://github.com/DoESLiverpool/nixcfgs/blob/master/hosts/admin-phone/default.nix00:34:37
@matthewcroughan:defenestrate.itmatthewcroughan - nix.zoneHere's an example of my working build for 11 also00:34:43
@matthewcroughan:defenestrate.itmatthewcroughan - nix.zone

My attempt for androidVersion 13 with the current robotnix that fails like above, is here:

{ config, pkgs, ... }:

{
  # Enable F-Droid and the F-Droid privileged extension
  apps.fdroid.enable = true;

  # Disable the LineageOS Updater
  source.dirs."packages/apps/Updater".enable = false;

  source.dirs."device/samsung/hlte-common".src = pkgs.fetchgit {
    rev = "9a1bf8f7b8ca7f6dccc6462b76bf712893bd9d39";
    url = "https://github.com/html6405/android_device_samsung_hlte-common.git";
    sha256 = "";
  };

  source.dirs."device/samsung/hlte".src = pkgs.fetchgit {
    rev = "1ac57aea5ecfe0ef06f24f931e978151a2307731";
    url = "https://github.com/html6405/android_device_samsung_hlte.git";
    sha256 = "";
  };

  source.dirs."kernel/samsung/msm8974".src = pkgs.fetchgit {
    rev = "79c36b7a4b30e1216d9b1d071359f3d4a681d0b2";
    url = "https://github.com/html6405/android_kernel_samsung_msm8974.git";
    sha256 = "";
  };

  source.dirs."hardware/samsung".src = pkgs.fetchgit {
    rev = "05133e22669d90b1b844974b243861a5d8138f51";
    url = "https://github.com/html6405/android_hardware_samsung.git";
    sha256 = "";
  };

  device = "hlte";
  flavor = "lineageos";
  androidVersion = 13;
}
00:35:37
@matthewcroughan:defenestrate.itmatthewcroughan - nix.zonehttps://github.com/nix-community/robotnix/blob/master/flavors/lineageos/lineage-18.1/device-dirs.json#L261000:36:22
@matthewcroughan:defenestrate.itmatthewcroughan - nix.zone hlte occurs in lineage-18.1 00:36:27
@matthewcroughan:defenestrate.itmatthewcroughan - nix.zoneIt ceases to occur in 19.1..00:36:45

Show newer messages


Back to Room ListRoom Version: 6