| 5 Jun 2024 |
 samueldr | and yeah | 06:24:56 |
| samueldr | though I guess you need something else | 06:25:09 |
| samueldr | (haven't touched robotnix in a while) | 06:25:14 |
 erahhal | In reply to @samueldr:matrix.org
the "old trick" is "TOFU"; trust on first use Learned a new term | 06:25:34 |
| samueldr | it's the name of the pattern like with SSH where you are asked to "trust on first use" [though you should also check really] | 06:26:19 |
| samueldr | T&COFU doesn't have a good sound to it | 06:26:32 |
| erahhal | So to be clear, even if the hash is changed, it will ignore the updated properties until it finds a new matching hash? | 06:28:18 |
| erahhal | otherwise erroring out and ignoring the props | 06:28:40 |
| samueldr | it would have tried to fetch the thing, however it's configured to fetch | 06:32:45 |
| samueldr | so it sounds like, from our back and forth, that what youdid is not proper for it to fetch the LFS bits | 06:33:05 |
| samueldr | though sorry, gotta go | 06:33:22 |
| erahhal | yeah definitely, digging into it. | 06:36:26 |
| erahhal | Thanks for your help | 06:36:29 |
| erahhal | Perhaps this is why the google stuff was in gitlab for lineage 2 | 06:39:53 |
| erahhal | * Perhaps this is why the google stuff was in gitlab for lineage 29 | 06:39:55 |
| erahhal | * Perhaps this is why the google stuff was in gitlab for lineage 20 | 06:39:58 |
 atemu12 | In reply to @erahhal:matrix.org
Sorry for spamming here. Please let me know if my level of messaging is inappropriate. Nah, 101% on topic | 07:00:52 |
| atemu12 | In reply to @erahhal:matrix.org
Manually updated the vendor.json entry for cheetah setting fetchLFS to true to no effect. digging into why this is not working. eyJhb implemented LFS support somewhereat some point. Make sure it's used | 07:02:03 |
 eyJhb | https://github.com/nix-community/robotnix/pull/228 | 07:02:26 |
| atemu12 | In reply to @erahhal:matrix.org
Better yet, how should the update_device_dirs.py script know that a repo has LFS files? I guess that would be specifically flagged similar to other devices with special cases? I see no reason to attempt to fetch without LFS honestly | 07:02:53 |
| eyJhb | I think it fixes a bunch of smaller bugs. | 07:03:06 |
| eyJhb | https://github.com/nix-community/robotnix/pull/228/files#diff-d2cdd059d29643c5fe1767c6dcf5203c0dc9b382d1322e3f0a4237eda6066246R57 lets just default to True then :D | 07:03:30 |
| eyJhb | Oh nvm. that patch already defaults to true https://github.com/nix-community/robotnix/pull/228/files#diff-e9564a29073c1c722ed3d8965bd1ff8d51ba08cd780f951944aafe3c30cc498cR173 | 07:04:04 |
| atemu12 | In reply to @erahhal:matrix.org
Perhaps this is why the google stuff was in gitlab for lineage 20 It was on Gitlab because Xiaomi DMCA'd the github repo | 07:04:12 |
| atemu12 | The blobs should have been in LFS from the beginning though | 07:04:48 |
| eyJhb | Would be cool with a test for the LFS PR. | 07:07:13 |
| erahhal | I'm going through the code to get LFS enabled for vendor. I think I'm close. Will continue tomorrow. Late here. Thank all! | 08:24:00 |
| atemu12 | Could you open a draft PR? | 08:25:24 |
| erahhal | Its very messy but sure | 08:27:00 |
| erahhal | https://github.com/nix-community/robotnix/pull/238/commits | 08:31:47 |
