!UUYziobKGGxpovWyAN:nixos.org

Robotnix

244 Members
Build Android (AOSP) using Nix | https://github.com/danielfullmer/robotnix75 Servers

Load older messages


SenderMessageTime
25 May 2024
@atemu12:matrix.orgatemu12No idea w.r.t. Vanadium, I have never used GOS15:29:23
@atemu12:matrix.orgatemu12My view on things is that if nobody has been around to maintain it for years, it's better to just remove it15:30:36
@atemu12:matrix.orgatemu12Neither Vanadium nor GOS have been touched by anyone the past few years 15:31:03
@atemu12:matrix.orgatemu12As for repo, is it really not possible to run it without it attempting to download some other version? I'd prefer to patch it to not download any updates whatsoever15:32:54
@jaen:matrix.orgjaenWell, on the other hand I never used LineageOS ; d What I'm just saying that unless you want to drop GrapheneOS wholesale, then it might need to stay. At least it's how it looks to me. I guess I don't care much either way, since I can try fixing it to the side anyway, or something.18:13:50
@jaen:matrix.orgjaen
In reply to @atemu12:matrix.org
As for repo, is it really not possible to run it without it attempting to download some other version? I'd prefer to patch it to not download any updates whatsoever
I would've preferred to not have done that particular yak shave, but oh well — https://github.com/nix-community/robotnix/pull/236/commits/4a347287aa2812d50ada2c87c7284e59617c9a41. This seems to work and have local sources as far as I can tell. Kind of ugly with the git shenanigans, but didn't see a better way so far.
18:15:06
26 May 2024
@jaen:matrix.orgjaen

Ok, got three basic checks (running nix flake check on flake/templated flake, formatters/linters and pytest) working again — https://github.com/jaen/robotnix/actions/runs/9243699871. Will see if I can get more working, but at least it's something. Two questions re: that:

  • pre-commit hooks yay/nay? When doing those changes I certainly forgot to re–format code once or twice — GHA caught that, but maybe it would be better to have caught that before pushing?
  • I've noticed after adding treefmt-nix and nix-github-actions get propagated down to the client flake as dependencies when running the templated flake test. Do you think it would make sense to try a pattern like https://figsoda.github.io/posts/2023/developing-nix-libraries-with-subflakes/ to avoid it?
13:47:23
@atemu12:matrix.orgatemu12I'm not a fan of pre-commit hooks. When I commit, I should commit precisely what I saw in the staging area. They're also a huge security liability which is why I've disabled them globally and I think that it's insane that git enables them by default.14:06:06
@atemu12:matrix.orgatemu12CI should be red on wrong format, that's good enough.14:06:24
@atemu12:matrix.orgatemu12I have no idea about flakes. 14:06:58
@jaen:matrix.orgjaenYeah, like I said I'm mostly ambivalent on them, so if you don't want them, then I don't feel like I need to add them. If you don't have an opinion re: subflake dependencies, then I'll try adding it and see how it works out, I guess?14:21:02
@atemu12:matrix.orgatemu12Sure, knock yourself out14:21:33
@atemu12:matrix.orgatemu12 As long as I can nix-build, I'm happy. 14:21:51
27 May 2024
@jaen:matrix.orgjaenOkay, changed my mind, forgot how error–prone that is with all the NixCpp corner cases around relative flake paths : V I guess it's better to suffer a superfluous input or two than britleness. So I guess the Python tests PR and the format PR (probably best reviewed after the first goes in; couldn't find a way to stack PRs with forks) are ready from my end. Please let me know if there's still something missing from them on your end (whenever you are able). In the mean time I'll be chipping away at the checks PR an possibly further at GrapheneOS after that's done.19:48:45
28 May 2024
@erahhal:matrix.orgerahhal

I've been trying to get LineageOS 21 to build (discussed here) , and feel like I'm getting close. Updated the python scripts, device and vendor files, and patches. Now when I build I'm running into the following. Not sure where to make a change to address this:

warning: Git tree '/home/erahhal/Code/nix-android' is dirty
warning: creating lock file '/home/erahhal/Code/nix-android/flake.lock'
warning: Git tree '/home/erahhal/Code/nix-android' is dirty
these 3 derivations will be built:
  /nix/store/jp9lghipjq8gym5i4i37i9q7scc8wqlp-robotnix-lineage_cheetah-2024052404.drv
  /nix/store/lmq73sjh1kk0dpfqqhrqkky4cvg7vd0j-ota-tools.drv
  /nix/store/k38ncc9ih0523fsisrm4wcmrwx67diap-cheetah-ota_update-2024052404.zip.drv
robotnix-lineage_cheetah> building '/nix/store/jp9lghipjq8gym5i4i37i9q7scc8wqlp-robotnix-lineage_cheetah-2024052404.drv'
robotnix-lineage_cheetah> unpacking sources
robotnix-lineage_cheetah> patching sources
robotnix-lineage_cheetah> building
robotnix-lineage_cheetah> Build type choices are:
robotnix-lineage_cheetah>      1. release
robotnix-lineage_cheetah>      2. debug
robotnix-lineage_cheetah>
robotnix-lineage_cheetah> Which would you like? [1] release
robotnix-lineage_cheetah> In file included from build/make/core/config.mk:389:
robotnix-lineage_cheetah> In file included from build/make/core/envsetup.mk:51:
robotnix-lineage_cheetah> build/make/core/release_config.mk:100: error: No release config set for target; please set TARGET_RELEASE, or if building on the command line use 'lunch <target>-<release>-<build_type>', where release is one of: ap1a.
robotnix-lineage_cheetah> 00:43:28 dumpvars failed with: exit status 1
error: builder for '/nix/store/jp9lghipjq8gym5i4i37i9q7scc8wqlp-robotnix-lineage_cheetah-2024052404.drv' failed with exit code 1;
       last 10 log lines:
       > building
       > Build type choices are:
       >      1. release
       >      2. debug
       >
       > Which would you like? [1] release
       > In file included from build/make/core/config.mk:389:
       > In file included from build/make/core/envsetup.mk:51:
       > build/make/core/release_config.mk:100: error: No release config set for target; please set TARGET_RELEASE, or if building on the command line use 'lunch <target>-<release>-<build_type>', where release is one of: ap1a.
       > 00:43:28 dumpvars failed with: exit status 1
       For full logs, run 'nix log /nix/store/jp9lghipjq8gym5i4i37i9q7scc8wqlp-robotnix-lineage_cheetah-2024052404.drv'.
error: 1 dependencies of derivation '/nix/store/k38ncc9ih0523fsisrm4wcmrwx67diap-cheetah-ota_update-2024052404.zip.drv' failed to build
┏━ 1 Errors:
┃ error: builder for '/nix/store/jp9lghipjq8gym5i4i37i9q7scc8wqlp-robotnix-lineage_cheetah-2024052404.drv' failed with exit code 1;
┃        last 10 log lines:
┃        > building
┃        > Build type choices are:
┃        >      1. release
┃        >      2. debug
┃        >
┃        > Which would you like? [1] release
┃        > In file included from build/make/core/config.mk:389:
┃        > In file included from build/make/core/envsetup.mk:51:
┃        > build/make/core/release_config.mk:100: error: No release config set for target; please set TARGET_RELEASE, or if building on the command line use 'lunch <target…
┃        > 00:43:28 dumpvars failed with: exit status 1
┃        For full logs, run 'nix log /nix/store/jp9lghipjq8gym5i4i37i9q7scc8wqlp-robotnix-lineage_cheetah-2024052404.drv'.
00:46:48
@erahhal:matrix.orgerahhal Found this thread, but I don't see the release variant being set to "trunk" anywhere. 01:27:15
@atemu12:matrix.orgatemu12Check whether the LOS build instructions have changed 14:34:56
@atemu12:matrix.orgatemu12It's smells like the targets are specified differently now14:35:07
@erahhal:matrix.orgerahhal Looking at https://wiki.lineageos.org/devices/cheetah/build/ I'm not seeing anything obvious. Will need to familiarize more with what Robotnix is doing. I assume base.nix is the right file. 16:12:23
@erahhal:matrix.orgerahhal

I tried explicitly setting the target using export TARGET_RELEASE=ap1a and it goes a little further, with the following error:

robotnix-lineage_cheetah> building '/nix/store/9pnnwqhaz86hy9hlsqvf1ayz9fcp0l91-robotnix-lineage_cheetah-2024052404.drv'
robotnix-lineage_cheetah> unpacking sources
robotnix-lineage_cheetah> patching sources
robotnix-lineage_cheetah> building
robotnix-lineage_cheetah> Build type choices are:
robotnix-lineage_cheetah>      1. release
robotnix-lineage_cheetah>      2. debug
robotnix-lineage_cheetah>
robotnix-lineage_cheetah> Which would you like? [1] release
robotnix-lineage_cheetah>
robotnix-lineage_cheetah>
robotnix-lineage_cheetah> Which product would you like? [aosp_arm] lineage_cheetah
robotnix-lineage_cheetah> In file included from build/make/core/config.mk:389:
robotnix-lineage_cheetah> In file included from build/make/core/envsetup.mk:51:
robotnix-lineage_cheetah> build/make/core/release_config.mk:109: error: No release config found for TARGET_RELEASE: trunk_staging. Available releases are: ap1a.
robotnix-lineage_cheetah> 16:15:11 dumpvars failed with: exit status 1
robotnix-lineage_cheetah> ** Not a valid product: lineage_cheetah

16:16:26
29 May 2024
@raitobezarius:matrix.orgraitobezarius changed their display name from raitobezarius to raitobezarius (DECT: 7248).17:09:57
@erahhal:matrix.orgerahhal Is this line the one that is supposed to set TARGET_PRODUCT? Or is it the envsetup.sh line above? 17:30:22
@erahhal:matrix.orgerahhal * Is this line the one that is supposed to set TARGET_PRODUCT? Or is it the envsetup.sh line above it? 17:30:29
@erahhal:matrix.orgerahhal I would assume it's the envsetup.sh line since it's sourceed, as scripts can't normally set the caller's environment 17:31:01
@erahhal:matrix.orgerahhalAh yeah looks like it17:31:55
@atemu12:matrix.orgatemu12Envsetup loads a bunch of bash functions17:44:39
@atemu12:matrix.orgatemu12The line you linked is probably such a function17:45:10
@atemu12:matrix.orgatemu12So it can indeed load env vars17:45:29
@erahhal:matrix.orgerahhalThanks.18:23:02
@erahhal:matrix.orgerahhal My current strategy is to see what's different from this repo which successfully builds 21. 18:23:27

Show newer messages


Back to Room ListRoom Version: 6