| 1 Apr 2024 |
 eyJhb | In reply to @cybershadow:cy.md
Is the unset variable in our code? If so then it may make sense to keep -u and be explicit about the variable being optional e.g. with ${var-} I don't think it was robotnix code that caused it, but I think it's great to have included. Because we shouldn't be doing that anyways. Can be removed if it becomes troublesome | 14:24:14 |
| eyJhb | In reply to @eyjhb:eyjhb.dk
https://github.com/nix-community/robotnix/pull/232 made a PR for it Finished my built without any issues :) | 14:43:01 |
| eyJhb | Damn it. I tried to build bacon (oneplus one), using robotnix. But I can't do that, since it's on 18.1.. :D And I get this device/oppo/common/common.mk:29: error: _nic.PRODUCTS.[[device/oneplus/bacon/lineage_bacon.mk]]: "vendor/oppo/msm8974-common/msm8974-common-vendor.mk" does not exist. | 16:08:12 |
|  budric joined the room. | 16:12:54 |
 atemu12 | Bacon needs a hack | 17:23:44 |
| atemu12 | This may have broken at some point | 17:23:56 |
| 2 Apr 2024 |
| eyJhb | I don't see any specific mentions of bacon in the source | 07:57:21 |
| eyJhb | Trying to get the emulator to work now on master. Would be nice if that could just be used for testing. However, not sure how useful. | 08:18:56 |
| eyJhb | The kernel building code is... not fun to say the least. | 09:25:30 |
| atemu12 | Emulator hs been broken for a while | 09:34:31 |
| atemu12 | Likely just needs an update? | 09:35:00 |
| atemu12 | Lots of broken stuff :/ | 09:35:38 |
| eyJhb | Android 12 never got the kernel build added. Which means the emulator will not work
https://github.com/nix-community/robotnix/blob/master/flavors/vanilla/12/default.nix#L26-L30 | 09:36:22 |
| eyJhb | :E | 09:36:25 |
| eyJhb | And Android 11 kernel looks quite complicated https://github.com/nix-community/robotnix/tree/master/flavors/vanilla/11/kernel | 09:36:59 |
| eyJhb | But trying to build the emulator for Android 11 now | 09:37:08 |
| atemu12 | That's vanilla though | 09:37:25 |
| eyJhb | Yup | 09:37:33 |
| eyJhb | Would the emulator work for lineageos as well? | 09:37:44 |
| atemu12 | Yeah | 09:39:00 |
| atemu12 | That's what I was referencing | 09:39:15 |
| atemu12 | I have net touched vanilla flavours in many years | 09:39:43 |
| eyJhb |
| 09:40:11 |
| eyJhb | device = "x86_64";
flavor = "lineageos";
| 09:40:14 |
| eyJhb | Would that be the options for emulator Atemu ? | 09:40:23 |
| atemu12 | I think so | 09:45:18 |
| atemu12 | and then the emulator attr | 09:45:30 |
| atemu12 | Not ata | 09:45:37 |
| atemu12 | * Not ota | 09:45:51 |
| eyJhb | trace: warning: lineage-19.1 is unmaintained in robotnix and may break at any time , can't really figure out why it defaults to that based on the metadata | 09:45:57 |
