| 31 Mar 2024 |
 eyJhb | I should just have put a --cores, most of the built respects that :D | 20:27:49 |
| eyJhb | In reply to @atemu12:matrix.org
eyJhb: We could set config.allowInsecure it could be a nice temp fix, but it would most likely be permanent to some degree. | 20:28:07 |
| eyJhb | The way I want to go about it currently, is to replace each python with Python3, and see if it works. But for that I would have to compile many many different versions I think | 20:28:37 |
 samueldr | if it's needed only for some older flavours, make it only for some older flavours? | 20:28:45 |
| eyJhb | OF different Android versions, maybe. | 20:28:46 |
| eyJhb | In reply to @samueldr:matrix.org
if it's needed only for some older flavours, make it only for some older flavours? that would be the ideal case | 20:28:56 |
| eyJhb | Or | 20:28:59 |
| eyJhb | Semi-ideal case. Ideal case would be everything running python3 :D | 20:29:08 |
| samueldr | sure | 20:29:12 |
| eyJhb | But yeah, it might be good to use that to start with. | 20:29:16 |
|  Miles Dyson joined the room. | 23:04:46 |
| 1 Apr 2024 |
| eyJhb | Atemu: any reason for omitting -u/ | 11:54:23 |
| eyJhb | * Atemu: any reason for omitting -u? | 11:54:24 |
 atemu12 | eyJhb: -u? | 12:01:15 |
| eyJhb | unset variables | 12:01:40 |
| eyJhb | https://github.com/nix-community/robotnix/pull/230#issuecomment-2028476496 I can't copy the link to the review I started, but I wanted to have -u added to the set in the PR :D | 12:02:09 |
| atemu12 | None | 12:02:36 |
| atemu12 | Though I didn't write that code ;) | 12:02:47 |
| eyJhb | Would it be welcome with a new PR that adds -u? :D | 12:03:15 |
| atemu12 | I wouldn't oppose it I guess but I don't think that's ever bitten us | 12:05:09 |
| eyJhb | https://github.com/nix-community/robotnix/pull/232 made a PR for it | 12:07:38 |
| eyJhb | I'm not sure if it has, or hasn't. I had a case while bumping, where it actually errored out because of a unset variable :) | 12:08:14 |
| eyJhb | (still finished building, but did not seem ideal) | 12:08:23 |
| eyJhb | Mostly wanted it added, so that it would fit what setup in nixpkgs does. Would make sense to expect the same behaviour | 12:08:50 |
| atemu12 | Sure then | 12:09:30 |
| atemu12 | Did you build this? | 12:09:39 |
| eyJhb | I've built it once before, but I'll validate it once more just to be sure. :) Doesn't hurt anyone double checking that it works :D | 12:10:17 |
| eyJhb | Atemu: Removed one of the -u, but kept it in the place I originally wanted. | 12:20:51 |
| eyJhb | Seems to work fine, currently building, no errors :) I can report back once it's done. | 12:21:04 |
 CyberShadow | Is the unset variable in our code? If so then it may make sense to keep -u and be explicit about the variable being optional e.g. with ${var-} | 12:59:04 |
