| 8 Jul 2023 |
atemu12 | (And its dependencies) | 13:06:43 |
atemu12 | Or you could run the updater script against their manifest I guess but it's probably broken | 13:06:44 |
atemu12 | In reply to * @mwkbarnjbblghgo4gudng:karp.lol is making lineage-20.0 compatibility patch I've got compat working here: https://github.com/atemu/robotnix/tree/los-20 | 13:06:45 |
atemu12 | Haven't updated since April though | 13:06:46 |
atemu12 | It's currently running on my FP4 | 13:06:50 |
Shane on Conduit.rs ⚡️ | In reply to @atemu12:matrix.org I've got compat working here: https://github.com/atemu/robotnix/tree/los-20 why not submit that upstream? Kinda need that for my OnePlus2 :D | 13:37:38 |
Shane on Conduit.rs ⚡️ | in addition to these patches https://github.com/LineageOS/android/compare/lineage-20.0...LineageOS-OP2:android:lineage-20.0 | 13:40:18 |
Shane on Conduit.rs ⚡️ | In reply to @atemu12:matrix.org You need something like https://github.com/LineageOS/android_device_oneplus_oneplus2/ That's this https://github.com/mukul2259/experimental_device_oneplus_oneplus2 for lineage-20.0
Is including source.dirs = builtins.fromJSON (builtins.readFile ...); from https://github.com/LineageOS-OP2/android sufficient?
| 14:52:30 |
| * Shane on Conduit.rs ⚡️ is now sure how is the device_oneplus_oneplus2 supposed to be defined | 14:54:47 |
atemu12 | Shane on Conduit.rs ⚡️: No. Honestly I'd recommend you to start by building it without robotnix first. Robotnix is complexity on top of some already very complex thing | 14:55:16 |
Shane on Conduit.rs ⚡️ | i know how to build it without robotnix already https://wiki.lineageos.org/devices/oneplus2/build | 14:55:47 |
atemu12 | Note that that's for when oneplus2 support was official | 14:56:07 |
atemu12 | There's likely a reason it's got an experimental prefix | 14:56:23 |
atemu12 | Try to do it without robotnix first. | 14:56:52 |
atemu12 | That's already hard enough if you're new to this | 14:57:03 |
Shane on Conduit.rs ⚡️ | In reply to @atemu12:matrix.org There's likely a reason it's got an experimental prefix https://forum.xda-developers.com/t/rom-t-lineageos-20-0-for-oneplus-2-android-13-beta-unofficial-signature-spoofing.4535927/
It's in review for lineageOS, but this is the guy who always maintained the device in lineageOS and marked it as stable.
i already built it manually and have that on the device
| 14:58:01 |
Shane on Conduit.rs ⚡️ | but like doing that manually is real pain and the provided images are broken >_> | 15:04:20 |
atemu12 | Alright, take a look at your source dirs and the structure under it | 15:14:55 |
Shane on Conduit.rs ⚡️ | yes? | 15:15:35 |
atemu12 | You'll see i.e. device/oneplus/oneplus2 | 15:15:56 |
atemu12 | Under it | 15:16:02 |
atemu12 | That relative path is what you set in source.dirs | 15:16:17 |
Shane on Conduit.rs ⚡️ | The JSON generated from the lineageOS 20 repo doesn't have it | 15:16:37 |
Shane on Conduit.rs ⚡️ | In reply to @atemu12:matrix.org That relative path is what you set in source.dirs i see | 15:17:05 |
atemu12 | You don't need it | 15:17:06 |
atemu12 | The JSON just populates source.dirs | 15:17:10 |
Shane on Conduit.rs ⚡️ | The repo has patches for the device though https://github.com/LineageOS/android/compare/lineage-20.0...LineageOS-OP2:android:lineage-20.0 | 15:17:57 |
atemu12 | If you wanna add another dir, just say source.dirs."device/oneplus/oneplus2".source = ...; | 15:19:28 |
atemu12 | Same if you wanna override it | 15:19:32 |
Shane on Conduit.rs ⚡️ | i see | 15:19:46 |